Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0028668Openbravo ERP09. Financial managementpublic2015-01-18 23:172015-05-07 22:17
Reporterrjapoova 
Assigned Toeduardo_Argal 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version3.0PR14Q4 
Target VersionFixed in Versionpi 
Merge Request Status
Review Assigned Toumartirena
OBNetwork customer
Web browserGoogle Chrome
ModulesCore
Support ticket
Regression levelProduction - Confirmed Stable
Regression date
Regression introduced in release3.0PR14Q4
Regression introduced by commit
Triggers an Emergency PackNo
Summary0028668: Pressing Cancel in Match Statement or in Process Reconciliation does not trigger a refresh
DescriptionIn the Financial Account transactions window you can start a reconciliation flow with the Match Statement window.

That window has two buttons: Done (complete the process) and Cancel (abandon the process).

Given that cancel does not return the system in its previous state and that transactions might have been created in the background (see issue 28667), when you Cancel, the system should refresh the screen otherwise the created transactions are not visible to the user.

The same applies to the Confirm Process Reconciliation window.

This is very confusing and a source of many errors.
Steps To ReproduceSee video:
https://drive.google.com/file/d/0B2uCUQlrOPvINlU3VUxNNnJpYVU/view?usp=sharing [^]
Proposed SolutionPlease notice that if issue 28667 is resolved, this issue is not relevant since cancelling will not result in any new transaction.
Additional Information
TagsNo tags attached.
Relationships
depends on backport 00297263.0PR15Q2 closed eduardo_Argal Pressing Cancel in Match Statement or in Process Reconciliation does not trigger a refresh 
depends on backport 00297273.0PR15Q1.4 closed eduardo_Argal Pressing Cancel in Match Statement or in Process Reconciliation does not trigger a refresh 
caused by feature request 00293903.0PR14Q4 closed Sandrahuguet Reconciliation refactor project 
related to design defect 0028669 closed Triage Omni OMS Language in Confim Process Reconciliation window is very confusing 
related to defect 0028667 closed Triage Omni OMS Cancelling a Match Statement flow does not fully return system to previous state 
causes defect 0029810 closed Triage Finance Match statement popup does not show cross button 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-01-18 23:17rjapoovaNew Issue
2015-01-18 23:17rjapoovaAssigned To => dmiguelez
2015-01-18 23:17rjapoovaWeb browser => Google Chrome
2015-01-18 23:17rjapoovaModules => Core
2015-01-18 23:17rjapoovaTriggers an Emergency Pack => No
2015-04-24 19:00dmitry_mezentsevAssigned Todmiguelez => Triage Finance
2015-04-24 19:00dmitry_mezentsevStatusnew => acknowledged
2015-04-24 19:00dmitry_mezentsevWeb browserGoogle Chrome => Google Chrome
2015-04-24 19:00dmitry_mezentsevPrioritynormal => immediate
2015-04-24 19:01dmitry_mezentsevRelationship addedcaused by 0029390
2015-04-24 19:01dmitry_mezentsevWeb browserGoogle Chrome => Google Chrome
2015-04-24 19:01dmitry_mezentsevRegression level => Production - Confirmed Stable
2015-04-24 19:01dmitry_mezentsevRegression introduced in release => 3.0PR14Q4
2015-04-28 13:12eduardo_ArgalStatusacknowledged => scheduled
2015-04-28 13:12eduardo_ArgalAssigned ToTriage Finance => eduardo_Argal
2015-04-28 19:33eduardo_ArgalStatusscheduled => feedback
2015-04-28 19:33eduardo_ArgalStatusfeedback => new
2015-04-28 19:33eduardo_ArgalStatusnew => scheduled
2015-04-29 19:43hgbotCheckin
2015-04-29 19:43hgbotNote Added: 0076891
2015-04-29 19:43hgbotStatusscheduled => resolved
2015-04-29 19:43hgbotResolutionopen => fixed
2015-04-29 19:43hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/5e2441fc0b3cb7d3152a37b44de74d1150d0c84b [^]
2015-04-29 19:44umartirenaReview Assigned To => umartirena
2015-04-29 19:44umartirenaNote Added: 0076892
2015-04-29 19:44umartirenaStatusresolved => closed
2015-04-29 19:44umartirenaFixed in Version => pi
2015-04-29 20:28dmitry_mezentsevRelationship addedrelated to 0028669
2015-04-29 20:32dmitry_mezentsevRelationship addedrelated to 0028667
2015-05-01 11:57hgbotCheckin
2015-05-01 11:57hgbotNote Added: 0076924
2015-05-07 13:06alostaleRelationship addedcauses 0029810
2015-05-07 22:17hudsonbotCheckin
2015-05-07 22:17hudsonbotNote Added: 0077188
2015-05-07 22:17hudsonbotCheckin
2015-05-07 22:17hudsonbotNote Added: 0077194

Notes
(0076891)
hgbot   
2015-04-29 19:43   
Repository: erp/devel/pi
Changeset: 5e2441fc0b3cb7d3152a37b44de74d1150d0c84b
Author: Eduardo Argal Guibert <eduardo.argal <at> openbravo.com>
Date: Wed Apr 29 17:33:40 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/5e2441fc0b3cb7d3152a37b44de74d1150d0c84b [^]

Fixes issue 28668: Pressing Cancel in Match Statement or in Process Reconciliation does not trigger a refresh.
Cancel button has been removed as it was considered confusing. Now there are two buttons, one for closing the window called 'OK', as it was before, and another one called 'Reconcile'.

Both triggers refresh. Messages have been added to improve user understanding on how the window works. New message to inform the user any change will be persisted. This message can be disabled once clear and will not popup again. Message to run algorithm as well improved.

---
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_ELEMENT.xml
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_MESSAGE.xml
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_REFERENCE.xml
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_REF_LIST.xml
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/OBUIAPP_PARAMETER.xml
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/MatchStatementActionHandler.java
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/UnMatchTransactionActionHandler.java
M modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-matchStatement.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-parameter-window-view.js
A modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/MatchStatementOnLoadGetPreferenceActionHandler.java
A modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/MatchStatementOnLoadPreferenceActionHandler.java
---
(0076892)
umartirena   
2015-04-29 19:44   
Code Review + Testing OK
(0076924)
hgbot   
2015-05-01 11:57   
Repository: erp/devel/pi
Changeset: 30de30c4d8093d060116dfc5d404b7377cd15ed6
Author: Eduardo Argal Guibert <eduardo.argal <at> openbravo.com>
Date: Fri May 01 11:56:45 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/30de30c4d8093d060116dfc5d404b7377cd15ed6 [^]

Related to issue 28668: Pressing Cancel in Match Statement or in Process Reconciliation does not trigger a refresh.
Refactor query to use named parameters to avoid this piece to be used as template for other developers as this could be a risky practice due to injections.

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/MatchStatementOnLoadGetPreferenceActionHandler.java
---
(0077188)
hudsonbot   
2015-05-07 22:17   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/a1817f84bd8b [^]
Maturity status: Test
(0077194)
hudsonbot   
2015-05-07 22:17   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/a1817f84bd8b [^]
Maturity status: Test