Project:
View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
ID | ||||||||
0028551 | ||||||||
Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
defect | [Retail Modules] Web POS | major | always | 2015-01-09 13:02 | 2015-03-30 11:31 | |||
Reporter | jecharri | View Status | public | |||||
Assigned To | mario_castello | |||||||
Priority | urgent | Resolution | fixed | Fixed in Version | RR15Q2 | |||
Status | closed | Fix in branch | pi | Fixed in SCM revision | 11a3edf21d4d | |||
Projection | none | ETA | none | Target Version | RR15Q2 | |||
OS | Any | Database | Any | Java version | ||||
OS Version | Database version | Ant version | ||||||
Product Version | SCM revision | |||||||
Merge Request Status | ||||||||
Review Assigned To | malsasua | |||||||
OBNetwork customer | OBPS | |||||||
Support ticket | ||||||||
Regression level | ||||||||
Regression date | ||||||||
Regression introduced in release | ||||||||
Regression introduced by commit | ||||||||
Triggers an Emergency Pack | No | |||||||
Summary | 0028551: Preference Web POS action Apply discount is not working fine the first time | |||||||
Description | Preference Web POS action Apply discount is not working fine the first time | |||||||
Steps To Reproduce | -Configure a role as manual -Go to Web POS -Verify that by default you don't have permission to discount button -Create a preference with property "Web POS action Apply discount" and value "Y" -Refresh the browser -Verify that preference has value true OB.POS.terminal.terminal.attributes.permissions['OBPOS_order.discount'] false but the button still is disabled -Refresh again and button will be enabled | |||||||
Tags | No tags attached. | |||||||
Attached Files | ![]() ![]() ![]() | |||||||
![]() |
|||||||||||||||
|
![]() |
|
(0073795) hgbot (developer) 2015-01-26 20:51 |
Repository: erp/pmods/org.openbravo.mobile.core Changeset: b60cf73b8abef6d15c2486d7e120e059c3967f11 Author: Mario Castello <mario.castello <at> peoplewalking.com> Date: Mon Jan 26 13:51:01 2015 -0600 URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/b60cf73b8abef6d15c2486d7e120e059c3967f11 [^] fixed issue 28551: Preference Web POS action Apply discount is not working fine the first time --- M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js --- |
(0073816) hgbot (developer) 2015-01-27 15:30 |
Repository: erp/pmods/org.openbravo.mobile.core Changeset: d4142ec1a5ec12466f13f646de481845c121d146 Author: Mario Castello <mario.castello <at> peoplewalking.com> Date: Tue Jan 27 08:29:19 2015 -0600 URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/d4142ec1a5ec12466f13f646de481845c121d146 [^] fixed issue 28551: Add validation --- M web/org.openbravo.mobile.core/source/component/ob-keyboard.js --- |
(0074519) migueldejuana (viewer) 2015-02-16 17:17 |
- We must backout the actual fix - I have attached a possible solution, see issue28551.diff file - Do not forget to apply JSBeautyfier and JSLint |
(0074852) hgbot (developer) 2015-02-24 16:09 |
Repository: erp/pmods/org.openbravo.mobile.core Changeset: ff3e2e0bb50898c7a441d36c7fb514e08736ce8a Author: Mario Castello <mario.castello <at> peoplewalking.com> Date: Tue Feb 24 09:08:55 2015 -0600 URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/ff3e2e0bb50898c7a441d36c7fb514e08736ce8a [^] fixed issue 28551: Correct validation and apply JSBeautyfier --- M web/org.openbravo.mobile.core/source/component/ob-keyboard.js --- |
(0074865) hgbot (developer) 2015-02-24 17:25 |
Repository: erp/pmods/org.openbravo.mobile.core Changeset: 9156df3b60fc984d8096ad0154b91e937d00cba4 Author: Mario Castello <mario.castello <at> peoplewalking.com> Date: Tue Feb 24 10:23:55 2015 -0600 URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/9156df3b60fc984d8096ad0154b91e937d00cba4 [^] fixed issue 28551: Display information to the user that need to refresh the page --- M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js --- |
(0075419) mtaal (viewer) 2015-03-10 19:02 |
As far as I can see this fix causes a js error, see attached screenshots. Specifically a call to OB.UTIL.isDisableDiscount like here: https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/ff3e2e0bb508#l1.8 [^] The OB.UTIL.isDisableDiscount function expects a second parameter a callback, this is not passed so it fails inside the OB.UTIL.isDisableDiscount. The OB.UTIL.isDisableDiscount does not return a value so is always false. The js error can be reproduced by setting the apply discount preference and then creating a ticket and adding/removing lines. I attached some screen shots. |
(0075422) hgbot (developer) 2015-03-10 21:37 |
Repository: erp/pmods/org.openbravo.mobile.core Changeset: 7564ee29fa2f328e32f2ae33aa458dee4e89d7d5 Author: Mario Castello <mario.castello <at> peoplewalking.com> Date: Tue Mar 10 14:36:16 2015 -0600 URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/7564ee29fa2f328e32f2ae33aa458dee4e89d7d5 [^] fixed issue 28551: Change validation with OB.UTIL.isDisableDiscount function --- M web/org.openbravo.mobile.core/source/component/ob-keyboard.js --- |
(0076123) hgbot (developer) 2015-03-30 11:30 |
Repository: erp/pmods/org.openbravo.mobile.core Changeset: 11a3edf21d4db9c0e27bf88383bd59b48fab6fd5 Author: Miguel A. Alsasua <miguel.alsasua <at> openbravo.com> Date: Mon Mar 30 11:25:53 2015 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/11a3edf21d4db9c0e27bf88383bd59b48fab6fd5 [^] fixed issue 28551: changed variable name from 'indice' to 'i' + JSLint --- M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js --- |
(0076124) malsasua (viewer) 2015-03-30 11:31 |
verified |
![]() |
|||
Date Modified | Username | Field | Change |
2015-01-09 13:02 | jecharri | New Issue | |
2015-01-09 13:02 | jecharri | Assigned To | => marvintm |
2015-01-09 13:02 | jecharri | OBNetwork customer | => Yes |
2015-01-09 13:02 | jecharri | Resolution time | => 1423004400 |
2015-01-09 13:02 | jecharri | Triggers an Emergency Pack | => No |
2015-01-13 16:02 | mario_castello | Assigned To | marvintm => mario_castello |
2015-01-13 16:02 | mario_castello | Status | new => scheduled |
2015-01-13 16:02 | mario_castello | fix_in_branch | => pi |
2015-01-26 20:51 | hgbot | Checkin | |
2015-01-26 20:51 | hgbot | Note Added: 0073795 | |
2015-01-26 20:51 | hgbot | Status | scheduled => resolved |
2015-01-26 20:51 | hgbot | Resolution | open => fixed |
2015-01-26 20:51 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/b60cf73b8abef6d15c2486d7e120e059c3967f11 [^] |
2015-01-27 15:30 | hgbot | Checkin | |
2015-01-27 15:30 | hgbot | Note Added: 0073816 | |
2015-01-27 15:30 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/b60cf73b8abef6d15c2486d7e120e059c3967f11 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/d4142ec1a5ec12466f13f646de481845c121d146 [^] |
2015-02-16 17:16 | migueldejuana | File Added: issue28551.diff | |
2015-02-16 17:17 | migueldejuana | Note Added: 0074519 | |
2015-02-16 17:17 | migueldejuana | Status | resolved => new |
2015-02-16 17:17 | migueldejuana | Resolution | fixed => open |
2015-02-24 10:32 | Orekaria | Relationship added | related to 0028832 |
2015-02-24 16:09 | hgbot | Checkin | |
2015-02-24 16:09 | hgbot | Note Added: 0074852 | |
2015-02-24 16:09 | hgbot | Status | new => resolved |
2015-02-24 16:09 | hgbot | Resolution | open => fixed |
2015-02-24 16:09 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/d4142ec1a5ec12466f13f646de481845c121d146 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/ff3e2e0bb50898c7a441d36c7fb514e08736ce8a [^] |
2015-02-24 17:25 | hgbot | Checkin | |
2015-02-24 17:25 | hgbot | Note Added: 0074865 | |
2015-02-24 17:25 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/ff3e2e0bb50898c7a441d36c7fb514e08736ce8a [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/9156df3b60fc984d8096ad0154b91e937d00cba4 [^] |
2015-02-27 16:55 | marvintm | Review Assigned To | => marvintm |
2015-02-27 16:55 | marvintm | Status | resolved => closed |
2015-02-27 16:55 | marvintm | Fixed in Version | => RR15Q2 |
2015-03-10 19:02 | mtaal | Note Added: 0075419 | |
2015-03-10 19:02 | mtaal | Status | closed => new |
2015-03-10 19:02 | mtaal | Resolution | fixed => open |
2015-03-10 19:02 | mtaal | Fixed in Version | RR15Q2 => |
2015-03-10 19:02 | mtaal | File Added: Selection_116.png | |
2015-03-10 19:02 | mtaal | File Added: Selection_115.png | |
2015-03-10 21:37 | hgbot | Checkin | |
2015-03-10 21:37 | hgbot | Note Added: 0075422 | |
2015-03-10 21:37 | hgbot | Status | new => resolved |
2015-03-10 21:37 | hgbot | Resolution | open => fixed |
2015-03-10 21:37 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/9156df3b60fc984d8096ad0154b91e937d00cba4 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/7564ee29fa2f328e32f2ae33aa458dee4e89d7d5 [^] |
2015-03-30 11:30 | hgbot | Checkin | |
2015-03-30 11:30 | hgbot | Note Added: 0076123 | |
2015-03-30 11:30 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/7564ee29fa2f328e32f2ae33aa458dee4e89d7d5 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/11a3edf21d4db9c0e27bf88383bd59b48fab6fd5 [^] |
2015-03-30 11:31 | malsasua | Review Assigned To | marvintm => malsasua |
2015-03-30 11:31 | malsasua | Note Added: 0076124 | |
2015-03-30 11:31 | malsasua | Status | resolved => closed |
2015-03-30 11:31 | malsasua | Fixed in Version | => RR15Q2 |
2015-06-10 13:18 | dmitry_mezentsev | Relationship added | causes 0030109 |
Copyright © 2000 - 2009 MantisBT Group |