Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0028469 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] A. Platform | minor | have not tried | 2014-12-22 18:48 | 2015-02-04 20:33 | |||
| Reporter | caristu | View Status | public | |||||
| Assigned To | AugustoMauch | |||||||
| Priority | immediate | Resolution | fixed | Fixed in Version | 3.0PR15Q2 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | b614afc46817 | ||||
| Projection | none | ETA | none | Target Version | 3.0PR15Q2 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | pi | SCM revision | ||||||
| Review Assigned To | alostale | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0028469: It is possible to save a masked string with incorrect length in grid view | |||||||
| Description | It is possible to save a masked string with incorrect length in grid view | |||||||
| Steps To Reproduce | 1) Create a new maked string reference [1]. Use the following pattern for the string: ###. This means the string should consist of 3 digits 2) Create a new column with this reference and the corresponding field for the column. 3) Recompile and restart 4) Access to the window with the new field in form mode. Enter the following value in the field: 12. Notice that an error is thrown and the record is not saved. (see attached screenshot 1) 5) Put the window in grid mode. Enter the following value in the field: 12. It seems that the wrong format is detected, but the record is saved with the wrong value. (see attached screenshot 2) [1] http://wiki.openbravo.com/wiki/How_to_add_a_masked_text_field [^] | |||||||
| Tags | No tags attached. | |||||||
| Attached Files |  s1.png [^] (43,637 bytes) 2014-12-22 18:48
s2.png [^] (56,185 bytes) 2014-12-22 18:49
 issue28469.export [^] (4,729 bytes) 2014-12-24 09:25 | |||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|||||||||||||||
|
|||||||||||||||
 Relationships |
|
Notes |
|
|
(0072806) AugustoMauch (manager) 2014-12-24 09:27 |
A fix has been attached and pushed to try. It will not be included in pi until it is open for changesets targeting PR15Q2 |
|
(0072816) AugustoMauch (manager) 2014-12-24 13:08 |
The changeset went through try succesfully |
|
(0073310) hgbot (developer) 2015-01-05 16:03 |
Repository: erp/devel/pi Changeset: b614afc46817e3d234147b4ff2b74f1b631adf58 Author: Augusto Mauch <augusto.mauch <at> openbravo.com> Date: Mon Jan 05 13:38:32 2015 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/b614afc46817e3d234147b4ff2b74f1b631adf58 [^] Fixes issue 28469: Masked string validation is properly done in editable grid There were several problems that were preventing the handling of masked string validations from working properly: 1- The masked string validations were not being performed in grid view, due to this code in the validate function: if (this.form && this.form.grid && this.form.grid._showingEditor) { return; } That code was put there to prevent doing unneeded validations when a new record was created in the grid view (see issue https://issues.openbravo.com/view.php?id=19176 [^]). This issue remains fixed after re moving these lines. 2- After fixing 1), the Save toolbar button was enabled in the grid view even if the row being edited had masked string validation errores. These happened because of a flaw in the logic to disable the butt on: this.setDisabled(... && !hasErrors && ...); The button was being disabled when the editable form did not have errors, and enabled when the form had errors. Before fixing 1) this did not matter, as hasErrors was always false because the form item was not being validated. This has been fixed by disabling the button when the form had validation errors. 3- Sometimes (i.e. when the validation was performed due to an autosave) the mask validation was not taken into account. This happened because the validation was added to the validation list of the test it em, but not to the validation list of the grid field, that is where it was being taken from. --- M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-text.js M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/toolbar/ob-toolbar.js M modules/org.openbravo.userinterface.smartclient/web/org.openbravo.userinterface.smartclient/js/ob-smartclient.js --- |
|
(0073312) hgbot (developer) 2015-01-05 16:26 |
Repository: erp/devel/pi Changeset: aafc50f0ea12ff86bcf66d2b213516c992356aed Author: Augusto Mauch <augusto.mauch <at> openbravo.com> Date: Mon Jan 05 16:26:06 2015 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/aafc50f0ea12ff86bcf66d2b213516c992356aed [^] Related with issue 28469: Updates copyright year in license text --- M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-text.js M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/toolbar/ob-toolbar.js M modules/org.openbravo.userinterface.smartclient/web/org.openbravo.userinterface.smartclient/js/ob-smartclient.js --- |
|
(0073315) hgbot (developer) 2015-01-05 17:00 |
Repository: erp/devel/pi Changeset: c64817b82a3ecba643bd28c749b9476a1cc1f28b Author: Augusto Mauch <augusto.mauch <at> openbravo.com> Date: Mon Jan 05 16:59:32 2015 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/c64817b82a3ecba643bd28c749b9476a1cc1f28b [^] Related with issue 28469: Removes comment that refers to deleted code --- M modules/org.openbravo.userinterface.smartclient/web/org.openbravo.userinterface.smartclient/js/ob-smartclient.js --- |
|
(0073353) alostale (manager) 2015-01-08 12:06 |
code reviewed tested this case + issue 0019176 |
|
(0074109) hudsonbot (developer) 2015-02-04 20:33 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/f36c91d0ad63 [^] Maturity status: Test |
|
(0074110) hudsonbot (developer) 2015-02-04 20:33 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/f36c91d0ad63 [^] Maturity status: Test |
|
(0074112) hudsonbot (developer) 2015-02-04 20:33 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/f36c91d0ad63 [^] Maturity status: Test |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2014-12-22 18:48 | caristu | New Issue | |
| 2014-12-22 18:48 | caristu | Assigned To | => AugustoMauch |
| 2014-12-22 18:48 | caristu | File Added: s1.png | |
| 2014-12-22 18:48 | caristu | Modules | => Core |
| 2014-12-22 18:48 | caristu | Resolution time | => 1419634800 |
| 2014-12-22 18:48 | caristu | Triggers an Emergency Pack | => No |
| 2014-12-22 18:49 | caristu | File Added: s2.png | |
| 2014-12-23 07:41 | alostale | Relationship added | related to 0028188 |
| 2014-12-23 12:31 | AugustoMauch | Relationship added | caused by 0019176 |
| 2014-12-23 12:44 | AugustoMauch | File Added: issue28469.export | |
| 2014-12-23 12:46 | AugustoMauch | Note Added: 0072796 | |
| 2014-12-23 13:00 | AugustoMauch | File Deleted: issue28469.export | |
| 2014-12-23 13:01 | AugustoMauch | Note Deleted: 0072796 | |
| 2014-12-24 09:25 | AugustoMauch | File Added: issue28469.export | |
| 2014-12-24 09:27 | AugustoMauch | Note Added: 0072806 | |
| 2014-12-24 09:35 | AugustoMauch | Status | new => scheduled |
| 2014-12-24 09:35 | AugustoMauch | fix_in_branch | => pi |
| 2014-12-24 13:08 | AugustoMauch | Note Added: 0072816 | |
| 2015-01-05 13:39 | AugustoMauch | Issue Monitored: alostale | |
| 2015-01-05 13:40 | AugustoMauch | Review Assigned To | => alostale |
| 2015-01-05 13:40 | AugustoMauch | fix_in_branch | pi => |
| 2015-01-05 16:03 | hgbot | Checkin | |
| 2015-01-05 16:03 | hgbot | Note Added: 0073310 | |
| 2015-01-05 16:03 | hgbot | Status | scheduled => resolved |
| 2015-01-05 16:03 | hgbot | Resolution | open => fixed |
| 2015-01-05 16:03 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/b614afc46817e3d234147b4ff2b74f1b631adf58 [^] |
| 2015-01-05 16:26 | hgbot | Checkin | |
| 2015-01-05 16:26 | hgbot | Note Added: 0073312 | |
| 2015-01-05 17:00 | hgbot | Checkin | |
| 2015-01-05 17:00 | hgbot | Note Added: 0073315 | |
| 2015-01-08 12:06 | alostale | Note Added: 0073353 | |
| 2015-01-08 12:06 | alostale | Status | resolved => closed |
| 2015-01-08 12:06 | alostale | Fixed in Version | => 3.0PR15Q2 |
| 2015-02-04 20:33 | hudsonbot | Checkin | |
| 2015-02-04 20:33 | hudsonbot | Note Added: 0074109 | |
| 2015-02-04 20:33 | hudsonbot | Checkin | |
| 2015-02-04 20:33 | hudsonbot | Note Added: 0074110 | |
| 2015-02-04 20:33 | hudsonbot | Checkin | |
| 2015-02-04 20:33 | hudsonbot | Note Added: 0074112 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |