|
Notes |
|
|
|
|
A fix has been attached and pushed to try. It will not be included in pi until it is open for changesets targeting PR15Q2 |
|
|
|
|
|
The changeset went through try succesfully |
|
|
|
(0073310)
|
|
hgbot
|
|
2015-01-05 16:03
|
|
Repository: erp/devel/pi
Changeset: b614afc46817e3d234147b4ff2b74f1b631adf58
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Mon Jan 05 13:38:32 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/b614afc46817e3d234147b4ff2b74f1b631adf58 [^]
Fixes issue 28469: Masked string validation is properly done in editable grid
There were several problems that were preventing the handling of masked string validations from working properly:
1- The masked string validations were not being performed in grid view, due to this code in the validate function:
if (this.form && this.form.grid && this.form.grid._showingEditor) {
return;
}
That code was put there to prevent doing unneeded validations when a new record was created in the grid view (see issue https://issues.openbravo.com/view.php?id=19176 [^]). This issue remains fixed after re
moving these lines.
2- After fixing 1), the Save toolbar button was enabled in the grid view even if the row being edited had masked string validation errores. These happened because of a flaw in the logic to disable the butt
on:
this.setDisabled(... && !hasErrors && ...);
The button was being disabled when the editable form did not have errors, and enabled when the form had errors. Before fixing 1) this did not matter, as hasErrors was always false because the form item
was not being validated. This has been fixed by disabling the button when the form had validation errors.
3- Sometimes (i.e. when the validation was performed due to an autosave) the mask validation was not taken into account. This happened because the validation was added to the validation list of the test it
em, but not to the validation list of the grid field, that is where it was being taken from.
---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-text.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/toolbar/ob-toolbar.js
M modules/org.openbravo.userinterface.smartclient/web/org.openbravo.userinterface.smartclient/js/ob-smartclient.js
---
|
|
|
|
(0073312)
|
|
hgbot
|
|
2015-01-05 16:26
|
|
Repository: erp/devel/pi
Changeset: aafc50f0ea12ff86bcf66d2b213516c992356aed
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Mon Jan 05 16:26:06 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/aafc50f0ea12ff86bcf66d2b213516c992356aed [^]
Related with issue 28469: Updates copyright year in license text
---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-text.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/toolbar/ob-toolbar.js
M modules/org.openbravo.userinterface.smartclient/web/org.openbravo.userinterface.smartclient/js/ob-smartclient.js
---
|
|
|
|
(0073315)
|
|
hgbot
|
|
2015-01-05 17:00
|
|
Repository: erp/devel/pi
Changeset: c64817b82a3ecba643bd28c749b9476a1cc1f28b
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Mon Jan 05 16:59:32 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/c64817b82a3ecba643bd28c749b9476a1cc1f28b [^]
Related with issue 28469: Removes comment that refers to deleted code
---
M modules/org.openbravo.userinterface.smartclient/web/org.openbravo.userinterface.smartclient/js/ob-smartclient.js
---
|
|
|
|
|
code reviewed
tested this case + issue 0019176 |
|
|
|
|
|
|
|
|
|
|
|
|
|
s1.png (43,637) 2014-12-22 18:48
issue28469.export (4,729) 2014-12-24 09:25