Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0028467 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| feature request | [Openbravo ERP] 09. Financial management | major | N/A | 2014-12-22 17:53 | 2015-02-04 20:33 | |||
| Reporter | airaceburu | View Status | public | |||||
| Assigned To | airaceburu | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | 3.0PR15Q2 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | 785864c62605 | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Merge Request Status | ||||||||
| Review Assigned To | gorkaion | |||||||
| OBNetwork customer | No | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Support ticket | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0028467: When a payment is processed through FIN_AddPayment.processPayment the database connection sould not be closed | |||||||
| Description | The Java process implementing the Payment Process always does a rollback and close when there is an exception. This database close causes issues when calling this process from other processes. There should be a public api to process Payment to be called by other processes. This api should throw an OBException when an error happens instead of doing a rollback and closing the connection. | |||||||
| Steps To Reproduce | N/A | |||||||
| Proposed Solution | Modify the FIN_PaymentProcess.java file to create a new public static method to process a financial transaction. The public execute method must be left. Both methods should call a private method with all the logic. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0073445) hgbot (developer) 2015-01-13 09:33 |
Repository: erp/devel/pi Changeset: 785864c626055bb628bdad220907042f37a214c1 Author: Ander Iraceburu <ander.iraceburu <at> openbravo.com> Date: Mon Jan 12 12:34:31 2015 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/785864c626055bb628bdad220907042f37a214c1 [^] Fixes issue 28467: Code refactoring to FIN_TransactionProcess.java & FIN_PaymentProcess.java In order to remove the commitAndClose every time the method processPayment fails a refactoring has been made. Taking advantage of this refactoring also the use of ProcessBundle, OBError, ConnectionProvider and VariablesSecureApps has been reduced to a minimum. --- M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_PaymentProcess.java M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_TransactionProcess.java --- |
|
(0073446) hgbot (developer) 2015-01-13 09:33 |
Repository: erp/devel/pi Changeset: d409ba0d336b7cada374e7c2ffeaddfb7373aaad Author: Ander Iraceburu <ander.iraceburu <at> openbravo.com> Date: Mon Jan 12 16:20:56 2015 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/d409ba0d336b7cada374e7c2ffeaddfb7373aaad [^] Related to issue 28467: FIN_PaymentProcess.java Bugfix --- M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_PaymentProcess.java --- |
|
(0073589) gorkaion (viewer) 2015-01-19 09:54 |
code reviewed |
|
(0074137) hudsonbot (viewer) 2015-02-04 20:33 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/f36c91d0ad63 [^] Maturity status: Test |
|
(0074138) hudsonbot (viewer) 2015-02-04 20:33 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/f36c91d0ad63 [^] Maturity status: Test |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2014-12-22 17:53 | airaceburu | New Issue | |
| 2014-12-22 17:53 | airaceburu | Assigned To | => airaceburu |
| 2014-12-22 17:53 | airaceburu | OBNetwork customer | => No |
| 2014-12-22 17:53 | airaceburu | Modules | => Core |
| 2014-12-22 17:53 | airaceburu | Triggers an Emergency Pack | => No |
| 2015-01-12 10:02 | gorkaion | Issue cloned | 0028559 |
| 2015-01-12 10:02 | gorkaion | Relationship added | related to 0028559 |
| 2015-01-12 10:03 | gorkaion | Category | 07. Sales management => 09. Financial management |
| 2015-01-12 10:03 | gorkaion | Description Updated | View Revisions |
| 2015-01-12 10:03 | gorkaion | Proposed Solution updated | |
| 2015-01-13 09:33 | hgbot | Checkin | |
| 2015-01-13 09:33 | hgbot | Note Added: 0073445 | |
| 2015-01-13 09:33 | hgbot | Status | new => resolved |
| 2015-01-13 09:33 | hgbot | Resolution | open => fixed |
| 2015-01-13 09:33 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/785864c626055bb628bdad220907042f37a214c1 [^] |
| 2015-01-13 09:33 | hgbot | Checkin | |
| 2015-01-13 09:33 | hgbot | Note Added: 0073446 | |
| 2015-01-19 09:27 | airaceburu | Review Assigned To | => gorkaion |
| 2015-01-19 09:54 | gorkaion | Note Added: 0073589 | |
| 2015-01-19 09:54 | gorkaion | Status | resolved => closed |
| 2015-01-19 09:54 | gorkaion | Fixed in Version | => 3.0PR15Q2 |
| 2015-02-04 20:33 | hudsonbot | Checkin | |
| 2015-02-04 20:33 | hudsonbot | Note Added: 0074137 | |
| 2015-02-04 20:33 | hudsonbot | Checkin | |
| 2015-02-04 20:33 | hudsonbot | Note Added: 0074138 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |