Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0028467Openbravo ERP09. Financial managementpublic2014-12-22 17:532015-02-04 20:33
Reporterairaceburu 
Assigned Toairaceburu 
PrioritynormalSeveritymajorReproducibilityN/A
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR15Q2 
Merge Request Status
Review Assigned Togorkaion
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0028467: When a payment is processed through FIN_AddPayment.processPayment the database connection sould not be closed
DescriptionThe Java process implementing the Payment Process always does a rollback and close when there is an exception. This database close causes issues when calling this process from other processes.

There should be a public api to process Payment to be called by other processes. This api should throw an OBException when an error happens instead of doing a rollback and closing the connection.
Steps To ReproduceN/A
Proposed SolutionModify the FIN_PaymentProcess.java file to create a new public static method to process a financial transaction. The public execute method must be left. Both methods should call a private method with all the logic.
Additional Information
TagsNo tags attached.
Relationships
related to feature request 0028559 closed airaceburu When a financial transaction is processed the database connection sould not be closed 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2014-12-22 17:53airaceburuNew Issue
2014-12-22 17:53airaceburuAssigned To => airaceburu
2014-12-22 17:53airaceburuOBNetwork customer => No
2014-12-22 17:53airaceburuModules => Core
2014-12-22 17:53airaceburuTriggers an Emergency Pack => No
2015-01-12 10:02gorkaionIssue cloned0028559
2015-01-12 10:02gorkaionRelationship addedrelated to 0028559
2015-01-12 10:03gorkaionCategory07. Sales management => 09. Financial management
2015-01-12 10:03gorkaionDescription Updatedbug_revision_view_page.php?rev_id=7419#r7419
2015-01-12 10:03gorkaionProposed Solution updated
2015-01-13 09:33hgbotCheckin
2015-01-13 09:33hgbotNote Added: 0073445
2015-01-13 09:33hgbotStatusnew => resolved
2015-01-13 09:33hgbotResolutionopen => fixed
2015-01-13 09:33hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/785864c626055bb628bdad220907042f37a214c1 [^]
2015-01-13 09:33hgbotCheckin
2015-01-13 09:33hgbotNote Added: 0073446
2015-01-19 09:27airaceburuReview Assigned To => gorkaion
2015-01-19 09:54gorkaionNote Added: 0073589
2015-01-19 09:54gorkaionStatusresolved => closed
2015-01-19 09:54gorkaionFixed in Version => 3.0PR15Q2
2015-02-04 20:33hudsonbotCheckin
2015-02-04 20:33hudsonbotNote Added: 0074137
2015-02-04 20:33hudsonbotCheckin
2015-02-04 20:33hudsonbotNote Added: 0074138

Notes
(0073445)
hgbot   
2015-01-13 09:33   
Repository: erp/devel/pi
Changeset: 785864c626055bb628bdad220907042f37a214c1
Author: Ander Iraceburu <ander.iraceburu <at> openbravo.com>
Date: Mon Jan 12 12:34:31 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/785864c626055bb628bdad220907042f37a214c1 [^]

Fixes issue 28467: Code refactoring to FIN_TransactionProcess.java & FIN_PaymentProcess.java
In order to remove the commitAndClose every time the method processPayment fails a refactoring has been made. Taking advantage of this refactoring also the use of ProcessBundle, OBError, ConnectionProvider and VariablesSecureApps has been reduced to a minimum.

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_PaymentProcess.java
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_TransactionProcess.java
---
(0073446)
hgbot   
2015-01-13 09:33   
Repository: erp/devel/pi
Changeset: d409ba0d336b7cada374e7c2ffeaddfb7373aaad
Author: Ander Iraceburu <ander.iraceburu <at> openbravo.com>
Date: Mon Jan 12 16:20:56 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/d409ba0d336b7cada374e7c2ffeaddfb7373aaad [^]

Related to issue 28467: FIN_PaymentProcess.java Bugfix

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_PaymentProcess.java
---
(0073589)
gorkaion   
2015-01-19 09:54   
code reviewed
(0074137)
hudsonbot   
2015-02-04 20:33   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/f36c91d0ad63 [^]
Maturity status: Test
(0074138)
hudsonbot   
2015-02-04 20:33   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/f36c91d0ad63 [^]
Maturity status: Test