Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0028320 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Retail Modules] Web POS | minor | always | 2014-11-28 13:18 | 2014-12-17 19:08 | |||
| Reporter | migueldejuana | View Status | public | |||||
| Assigned To | migueldejuana | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | RR15Q1 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | f50a01fc7fc0 | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Merge Request Status | ||||||||
| Review Assigned To | mtaal | |||||||
| OBNetwork customer | No | |||||||
| Support ticket | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0028320: If we change to a bp without tax ID, we could Invoice an order | |||||||
| Description | Having restrict invoice for bp without tax ID preference enabled if we login with a bp with tax Id, we can check the order to be invoiced. If we change to a bp without tax ID, the order is still checked to be invoiced and it shouldn't. | |||||||
| Steps To Reproduce | - Enable restrict invoice for bp without tax ID preference - Login with a bp by default with tax ID - Check the order to be invoiced - Change to a bp without tax ID - ERROR: The order is still check as to be invoiced | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0072136) hgbot (developer) 2014-11-28 14:13 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: a3b2a40c8102c937d0abb53d8c3590aba5bc4d53 Author: Miguel de Juana <miguel.dejuana <at> openbravo.com> Date: Fri Nov 28 14:12:55 2014 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a3b2a40c8102c937d0abb53d8c3590aba5bc4d53 [^] Fixed issue 0028320: If we change to a bp without tax ID, we could Invoice an order --- M web/org.openbravo.retail.posterminal/js/components/businesspartner.js M web/org.openbravo.retail.posterminal/js/components/menu.js M web/org.openbravo.retail.posterminal/js/model/order.js --- |
|
(0072410) marvintm (viewer) 2014-12-10 17:42 |
There is a problem with the current login when the business partner is changed. Currently, when no restriction applies, the generateInvoice property is changed to the default value, and this is not correct. Take into account the following example: - My default is to not have invoice - I create a ticket and set it to generate invoice - Then I change the business partner to one which has a taxId The current code will change the ticket to not have invoice, and this is wrong. In general, we should only change the generateInvoice property when you change the business partner, if the current value is not correct for the current configuration (ie. if the taxId restriction is activated, and the business partner doesn't have taxId). In other cases, we should not change the property, because we don't know if the user changed it before or not, so we cannot assume that the default is the right value. |
|
(0072423) hgbot (developer) 2014-12-11 13:27 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: f50a01fc7fc09c8c8be6700f2cbc769d6df24915 Author: Miguel de Juana <miguel.dejuana <at> openbravo.com> Date: Thu Dec 11 13:26:49 2014 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f50a01fc7fc09c8c8be6700f2cbc769d6df24915 [^] Fixed issue 0028320: If we change to a bp without tax ID, we could Invoice an order Set invoice value with the value of POS Terminal Type only when we are validating bp taxID --- M web/org.openbravo.retail.posterminal/js/components/businesspartner.js --- |
|
(0072672) mtaal (viewer) 2014-12-17 19:08 |
Reviewed and tested |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2014-11-28 13:18 | migueldejuana | New Issue | |
| 2014-11-28 13:18 | migueldejuana | Assigned To | => migueldejuana |
| 2014-11-28 13:18 | migueldejuana | OBNetwork customer | => No |
| 2014-11-28 13:18 | migueldejuana | Triggers an Emergency Pack | => No |
| 2014-11-28 13:36 | migueldejuana | Relationship added | related to 0028310 |
| 2014-11-28 14:13 | hgbot | Checkin | |
| 2014-11-28 14:13 | hgbot | Note Added: 0072136 | |
| 2014-11-28 14:13 | hgbot | Status | new => resolved |
| 2014-11-28 14:13 | hgbot | Resolution | open => fixed |
| 2014-11-28 14:13 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a3b2a40c8102c937d0abb53d8c3590aba5bc4d53 [^] |
| 2014-12-10 17:42 | marvintm | Note Added: 0072410 | |
| 2014-12-10 17:42 | marvintm | Status | resolved => new |
| 2014-12-10 17:42 | marvintm | Resolution | fixed => open |
| 2014-12-11 13:27 | hgbot | Checkin | |
| 2014-12-11 13:27 | hgbot | Note Added: 0072423 | |
| 2014-12-11 13:27 | hgbot | Status | new => resolved |
| 2014-12-11 13:27 | hgbot | Resolution | open => fixed |
| 2014-12-11 13:27 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a3b2a40c8102c937d0abb53d8c3590aba5bc4d53 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f50a01fc7fc09c8c8be6700f2cbc769d6df24915 [^] |
| 2014-12-17 19:08 | mtaal | Review Assigned To | => mtaal |
| 2014-12-17 19:08 | mtaal | Note Added: 0072672 | |
| 2014-12-17 19:08 | mtaal | Status | resolved => closed |
| 2014-12-17 19:08 | mtaal | Fixed in Version | => RR15Q1 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |