Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0028320Retail ModulesWeb POSpublic2014-11-28 13:182014-12-17 19:08
Reportermigueldejuana 
Assigned Tomigueldejuana 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR15Q1 
Merge Request Status
Review Assigned Tomtaal
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0028320: If we change to a bp without tax ID, we could Invoice an order
DescriptionHaving restrict invoice for bp without tax ID preference enabled if we login with a bp with tax Id, we can check the order to be invoiced. If we change to a bp without tax ID, the order is still checked to be invoiced and it shouldn't.
Steps To Reproduce- Enable restrict invoice for bp without tax ID preference
- Login with a bp by default with tax ID
- Check the order to be invoiced
- Change to a bp without tax ID
- ERROR: The order is still check as to be invoiced
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0028310 closed migueldejuana [RR14Q3.2] Generate invoice for orders feature not working 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2014-11-28 13:18migueldejuanaNew Issue
2014-11-28 13:18migueldejuanaAssigned To => migueldejuana
2014-11-28 13:18migueldejuanaTriggers an Emergency Pack => No
2014-11-28 13:36migueldejuanaRelationship addedrelated to 0028310
2014-11-28 14:13hgbotCheckin
2014-11-28 14:13hgbotNote Added: 0072136
2014-11-28 14:13hgbotStatusnew => resolved
2014-11-28 14:13hgbotResolutionopen => fixed
2014-11-28 14:13hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a3b2a40c8102c937d0abb53d8c3590aba5bc4d53 [^]
2014-12-10 17:42marvintmNote Added: 0072410
2014-12-10 17:42marvintmStatusresolved => new
2014-12-10 17:42marvintmResolutionfixed => open
2014-12-11 13:27hgbotCheckin
2014-12-11 13:27hgbotNote Added: 0072423
2014-12-11 13:27hgbotStatusnew => resolved
2014-12-11 13:27hgbotResolutionopen => fixed
2014-12-11 13:27hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a3b2a40c8102c937d0abb53d8c3590aba5bc4d53 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f50a01fc7fc09c8c8be6700f2cbc769d6df24915 [^]
2014-12-17 19:08mtaalReview Assigned To => mtaal
2014-12-17 19:08mtaalNote Added: 0072672
2014-12-17 19:08mtaalStatusresolved => closed
2014-12-17 19:08mtaalFixed in Version => RR15Q1

Notes
(0072136)
hgbot   
2014-11-28 14:13   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: a3b2a40c8102c937d0abb53d8c3590aba5bc4d53
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Fri Nov 28 14:12:55 2014 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a3b2a40c8102c937d0abb53d8c3590aba5bc4d53 [^]

Fixed issue 0028320: If we change to a bp without tax ID, we could Invoice an order

---
M web/org.openbravo.retail.posterminal/js/components/businesspartner.js
M web/org.openbravo.retail.posterminal/js/components/menu.js
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0072410)
marvintm   
2014-12-10 17:42   
There is a problem with the current login when the business partner is changed. Currently, when no restriction applies, the generateInvoice property is changed to the default value, and this is not correct.

Take into account the following example:
- My default is to not have invoice
- I create a ticket and set it to generate invoice
- Then I change the business partner to one which has a taxId
The current code will change the ticket to not have invoice, and this is wrong.

In general, we should only change the generateInvoice property when you change the business partner, if the current value is not correct for the current configuration (ie. if the taxId restriction is activated, and the business partner doesn't have taxId). In other cases, we should not change the property, because we don't know if the user changed it before or not, so we cannot assume that the default is the right value.
(0072423)
hgbot   
2014-12-11 13:27   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: f50a01fc7fc09c8c8be6700f2cbc769d6df24915
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Thu Dec 11 13:26:49 2014 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f50a01fc7fc09c8c8be6700f2cbc769d6df24915 [^]

Fixed issue 0028320: If we change to a bp without tax ID, we could Invoice an order

Set invoice value with the value of POS Terminal Type only when we are validating bp taxID

---
M web/org.openbravo.retail.posterminal/js/components/businesspartner.js
---
(0072672)
mtaal   
2014-12-17 19:08   
Reviewed and tested