Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0028142
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajorhave not tried2014-11-11 16:482014-12-01 14:35
ReportercaristuView Statuspublic 
Assigned Toaaroncalero 
PriorityurgentResolutionfixedFixed in VersionRR15Q1
StatusclosedFix in branchFixed in SCM revision6e007d9b48e8
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomtaal
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0028142: The organization of a user should be considered for accessing to a terminal

DescriptionThe organization of a user should be considered for accessing to a terminal. In other case a user can access to a terminal that belongs to an organization that is not in the natural tree of the user organization.
Steps To ReproduceHaving two organizations A and B that belongs to the same parent organization
1) Create a user with organization A
2) Create a role for the parent organization and in the [Org Access] tab give access to A and B
3) Having a POS Terminal defined for B, user can log-in on it. The orders created by this user won't be synchronized because wrong access error. This is becasue the user is not defined for an organization in the natural tree of B
Proposed SolutionInclude the restricition for the user organization on the getUserImages() method of the LoginUtilsServlet class
TagsNo tags attached.
Attached Filespng file icon Selection_160.png [^] (283,104 bytes) 2014-12-01 14:34

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0071766)
hgbot (developer)
2014-11-18 16:02

Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 6e007d9b48e80155d644efe6c975a2a13aa758e6
Author: Aaron Calero <aaron.calero <at> openbravo.com>
Date: Tue Nov 18 15:58:26 2014 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/6e007d9b48e80155d644efe6c975a2a13aa758e6 [^]

Fixed issue 28142: The organization of a user should be considered for accessing to a terminal

Changed query in getUserImages method of the LoginUtilsServlet class to check if the user organization is part of the terminal org tree.
Added an additional check in POSLoginHandler to ensure the user's organization belongs to the natural organization tree of the terminal

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M src/org/openbravo/retail/posterminal/LoginUtilsServlet.java
M src/org/openbravo/retail/posterminal/POSLoginHandler.java
---
(0072197)
mtaal (manager)
2014-12-01 14:34

Did a test by adding user as described and disabling the new code in
https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/diff/6e007d9b48e8/src/org/openbravo/retail/posterminal/LoginUtilsServlet.java [^]

See the attached screenshot with the T1 user, with the change this user is not shown (which is correct).
(0072198)
mtaal (manager)
2014-12-01 14:35

Reviewed and tested

- Issue History
Date Modified Username Field Change
2014-11-11 16:48 caristu New Issue
2014-11-11 16:48 caristu Assigned To => marvintm
2014-11-11 16:48 caristu Resolution time => 1418511600
2014-11-11 16:48 caristu Triggers an Emergency Pack => No
2014-11-11 16:48 caristu Issue Monitored: networkb
2014-11-17 15:53 mtaal Assigned To marvintm => aaroncalero
2014-11-18 16:02 hgbot Checkin
2014-11-18 16:02 hgbot Note Added: 0071766
2014-11-18 16:02 hgbot Status new => resolved
2014-11-18 16:02 hgbot Resolution open => fixed
2014-11-18 16:02 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/6e007d9b48e80155d644efe6c975a2a13aa758e6 [^]
2014-12-01 14:34 mtaal Note Added: 0072197
2014-12-01 14:34 mtaal File Added: Selection_160.png
2014-12-01 14:35 mtaal Review Assigned To => mtaal
2014-12-01 14:35 mtaal Note Added: 0072198
2014-12-01 14:35 mtaal Status resolved => closed
2014-12-01 14:35 mtaal Fixed in Version => RR15Q1


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker