Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0028142Retail ModulesWeb POSpublic2014-11-11 16:482014-12-01 14:35
Reportercaristu 
Assigned Toaaroncalero 
PriorityurgentSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR15Q1 
Merge Request Status
Review Assigned Tomtaal
OBNetwork customerOBPS
Support ticket32332
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0028142: The organization of a user should be considered for accessing to a terminal
DescriptionThe organization of a user should be considered for accessing to a terminal. In other case a user can access to a terminal that belongs to an organization that is not in the natural tree of the user organization.
Steps To ReproduceHaving two organizations A and B that belongs to the same parent organization
1) Create a user with organization A
2) Create a role for the parent organization and in the [Org Access] tab give access to A and B
3) Having a POS Terminal defined for B, user can log-in on it. The orders created by this user won't be synchronized because wrong access error. This is becasue the user is not defined for an organization in the natural tree of B
Proposed SolutionInclude the restricition for the user organization on the getUserImages() method of the LoginUtilsServlet class
Additional Information
TagsNo tags attached.
Relationships
Attached Filespng Selection_160.png (283,104) 2014-12-01 14:34
https://issues.openbravo.com/file_download.php?file_id=7566&type=bug
Issue History
Date ModifiedUsernameFieldChange
2014-11-11 16:48caristuNew Issue
2014-11-11 16:48caristuAssigned To => marvintm
2014-11-11 16:48caristuOBNetwork customer => Yes
2014-11-11 16:48caristuSupport ticket => 32332
2014-11-11 16:48caristuResolution time => 1418511600
2014-11-11 16:48caristuTriggers an Emergency Pack => No
2014-11-11 16:48caristuIssue Monitored: networkb
2014-11-17 15:53mtaalAssigned Tomarvintm => aaroncalero
2014-11-18 16:02hgbotCheckin
2014-11-18 16:02hgbotNote Added: 0071766
2014-11-18 16:02hgbotStatusnew => resolved
2014-11-18 16:02hgbotResolutionopen => fixed
2014-11-18 16:02hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/6e007d9b48e80155d644efe6c975a2a13aa758e6 [^]
2014-12-01 14:34mtaalNote Added: 0072197
2014-12-01 14:34mtaalFile Added: Selection_160.png
2014-12-01 14:35mtaalReview Assigned To => mtaal
2014-12-01 14:35mtaalNote Added: 0072198
2014-12-01 14:35mtaalStatusresolved => closed
2014-12-01 14:35mtaalFixed in Version => RR15Q1

Notes
(0071766)
hgbot   
2014-11-18 16:02   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 6e007d9b48e80155d644efe6c975a2a13aa758e6
Author: Aaron Calero <aaron.calero <at> openbravo.com>
Date: Tue Nov 18 15:58:26 2014 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/6e007d9b48e80155d644efe6c975a2a13aa758e6 [^]

Fixed issue 28142: The organization of a user should be considered for accessing to a terminal

Changed query in getUserImages method of the LoginUtilsServlet class to check if the user organization is part of the terminal org tree.
Added an additional check in POSLoginHandler to ensure the user's organization belongs to the natural organization tree of the terminal

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M src/org/openbravo/retail/posterminal/LoginUtilsServlet.java
M src/org/openbravo/retail/posterminal/POSLoginHandler.java
---
(0072197)
mtaal   
2014-12-01 14:34   
Did a test by adding user as described and disabling the new code in
https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/diff/6e007d9b48e8/src/org/openbravo/retail/posterminal/LoginUtilsServlet.java [^]

See the attached screenshot with the T1 user, with the change this user is not shown (which is correct).
(0072198)
mtaal   
2014-12-01 14:35   
Reviewed and tested