Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0028111
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 04. Warehouse managementmajoralways2014-11-06 12:142015-03-20 12:35
ReporterumartirenaView Statuspublic 
Assigned Toumartirena 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision7a7b3954ec59
ProjectionnoneETAnoneTarget Version3.0PR15Q2
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Toeduardo_Argal
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0028111: InitializeMTransCostDateacctData modulescript has several performance issues

Description"InitializeMTransCostDateacctData" modulescript has several performance issues with big amount of data. This happens because modulescripts are executed when the indexes of database are not created yet.
Steps To ReproduceExecute update.database on a database with big amount of data.
Proposed SolutionRemove the "InitializeMTransCostDateacctData" modulescript and implement that functionality in the "Costing Background process". Create a preference when the process has been executed in order to control that only is executed once.
Add a verification on "Valued Stock Report" and on "Sales Invoice Dimensional Report" to be able to run it only after the execution of "Costing Background process".
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
depends on backport 00289513.0PR15Q1.1 closedumartirena InitializeMTransCostDateacctData modulescript has several performance issues 
causes defect 00294403.0PR15Q3 closedumartirena In a environment with costs not calculated the user can not get the sales invoice dimensional report 

-  Notes
(0074515)
hgbot (developer)
2015-02-16 16:02

 Repository: erp/devel/pi
Changeset: 7a7b3954ec5964e56e2ef8e2d3c5d1589204dc4a
Author: Unai Martirena <unai.martirena <at> openbravo.com>
Date: Mon Feb 16 16:00:25 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/7a7b3954ec5964e56e2ef8e2d3c5d1589204dc4a [^]

Fixes bug 28111, Fixes bug 28951: InitCostDateacct modulescript has been removed

The functionality that was being implemented in the modulescript now will be done in Costing Background process. An oncreatedefault has been added in dateacct column because it has a constraint of not null. The date set to the column will be 01-01-1970, and this date will be used as a reference while updating it in Costing Background process

---
M src-db/database/model/tables/M_TRANSACTION_COST.xml
M src-db/database/sourcedata/AD_MESSAGE.xml
M src/org/openbravo/costing/CostingBackground.java
M src/org/openbravo/erpCommon/ad_reports/ReportInvoiceCustomerDimensionalAnalysesJR.java
M src/org/openbravo/erpCommon/ad_reports/ReportValuationStock.java
A build/javasqlc/src/org/openbravo/costing/InitializeCostingMTransCostDateacctData.java
A src/org/openbravo/costing/InitializeCostingMTransCostDateacct_data.xsql
R src-util/modulescript/build/classes/org/openbravo/modulescript/InitializeMTransCostDateacct.class
R src-util/modulescript/build/classes/org/openbravo/modulescript/InitializeMTransCostDateacctData.class
R src-util/modulescript/src/org/openbravo/modulescript/InitializeMTransCostDateacct.java
R src-util/modulescript/src/org/openbravo/modulescript/InitializeMTransCostDateacct_data.xsql
---
(0074544)
hgbot (developer)
2015-02-17 10:30

 Repository: erp/devel/pi
Changeset: e2e44617a15698fd1dbc40a7d50888784bfb41db
Author: Unai Martirena <unai.martirena <at> openbravo.com>
Date: Tue Feb 17 10:28:34 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/e2e44617a15698fd1dbc40a7d50888784bfb41db [^]

Related to bug 28111,related to bug 28951: Remove xsql Data class file

---
R build/javasqlc/src/org/openbravo/costing/InitializeCostingMTransCostDateacctData.java
---
(0074589)
hgbot (developer)
2015-02-18 11:48

 Repository: erp/devel/pi
Changeset: bb5fb83de69573b861872d87fcd01da7a6bf169f
Author: Unai Martirena <unai.martirena <at> openbravo.com>
Date: Wed Feb 18 11:46:11 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/bb5fb83de69573b861872d87fcd01da7a6bf169f [^]

Related to bug 28111,related to bug 28951: Fix on oncreatedefault

oncreatedefault statement of dateacct has been changed in order to work both in oracle and postgres with different date formats.
Also to_date has been removed from background process in order to allways the filter work.

---
M src-db/database/model/tables/M_TRANSACTION_COST.xml
M src/org/openbravo/costing/InitializeCostingMTransCostDateacct_data.xsql
---
(0074601)
hgbot (developer)
2015-02-18 14:06

 Repository: erp/devel/pi
Changeset: 50eefca6fdf24dce85e7fd364e57c85a7b551d73
Author: Unai Martirena <unai.martirena <at> openbravo.com>
Date: Wed Feb 18 14:02:30 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/50eefca6fdf24dce85e7fd364e57c85a7b551d73 [^]

Related to bug 28111,related to bug 28951: Fix on where clause

Filter m_transaction_cost records in Costing Background process using same dateformat that has been used in oncreatedefault to insert values

---
M src/org/openbravo/costing/InitializeCostingMTransCostDateacct_data.xsql
---
(0074763)
hudsonbot (developer)
2015-02-23 05:11

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/6856352d7235 [^]
Maturity status: Test
(0074769)
hudsonbot (developer)
2015-02-23 05:11

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/6856352d7235 [^]
Maturity status: Test
(0074781)
hudsonbot (developer)
2015-02-23 05:11

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/6856352d7235 [^]
Maturity status: Test
(0074784)
hudsonbot (developer)
2015-02-23 05:11

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/6856352d7235 [^]
Maturity status: Test
(0075365)
dmitry_mezentsev (developer)
2015-03-10 09:57

 The issue is resolved but not yet closed for 22 days.
(0075525)
dmitry_mezentsev (developer)
2015-03-13 10:37

 25 days!!!
(0075789)
eduardo_Argal (developer)
2015-03-20 12:35

 Code Reviewed and tested. No module script is run and background process for costing does the computation for dateacct

- Issue History
Date Modified Username Field Change
2014-11-06 12:14 umartirena New Issue
2014-11-06 12:14 umartirena Assigned To => umartirena
2014-11-06 12:14 umartirena Modules => Core
2014-11-06 12:14 umartirena Triggers an Emergency Pack => No
2014-11-06 12:14 umartirena Status new => scheduled
2014-11-06 12:14 umartirena fix_in_branch => pi
2015-02-02 10:46 umartirena Target Version 3.0PR14Q4 => 3.0PR15Q2
2015-02-02 10:46 umartirena fix_in_branch pi =>
2015-02-16 12:29 plujan Status scheduled => acknowledged
2015-02-16 12:30 plujan Status acknowledged => scheduled
2015-02-16 12:30 plujan fix_in_branch => pi
2015-02-16 16:02 hgbot Checkin
2015-02-16 16:02 hgbot Note Added: 0074515
2015-02-16 16:02 hgbot Status scheduled => resolved
2015-02-16 16:02 hgbot Resolution open => fixed
2015-02-16 16:02 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/7a7b3954ec5964e56e2ef8e2d3c5d1589204dc4a [^]
2015-02-17 10:30 hgbot Checkin
2015-02-17 10:30 hgbot Note Added: 0074544
2015-02-18 11:48 hgbot Checkin
2015-02-18 11:48 hgbot Note Added: 0074589
2015-02-18 14:06 hgbot Checkin
2015-02-18 14:06 hgbot Note Added: 0074601
2015-02-23 05:11 hudsonbot Checkin
2015-02-23 05:11 hudsonbot Note Added: 0074763
2015-02-23 05:11 hudsonbot Checkin
2015-02-23 05:11 hudsonbot Note Added: 0074769
2015-02-23 05:11 hudsonbot Checkin
2015-02-23 05:11 hudsonbot Note Added: 0074781
2015-02-23 05:11 hudsonbot Checkin
2015-02-23 05:11 hudsonbot Note Added: 0074784
2015-03-10 09:57 dmitry_mezentsev Note Added: 0075365
2015-03-13 10:37 dmitry_mezentsev Note Added: 0075525
2015-03-18 10:21 umartirena Review Assigned To => eduardo_Argal
2015-03-18 10:21 umartirena fix_in_branch pi =>
2015-03-20 12:35 eduardo_Argal Note Added: 0075789
2015-03-20 12:35 eduardo_Argal Status resolved => closed
2015-03-27 16:33 dmitry_mezentsev Relationship added causes 0029440

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker