Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0028010 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] B. User interface | trivial | always | 2014-10-28 17:52 | 2015-02-04 20:34 | |||
| Reporter | egoitz | View Status | public | |||||
| Assigned To | inigosanchez | |||||||
| Priority | urgent | Resolution | fixed | Fixed in Version | 3.0PR15Q2 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | f8292e9b2d8b | ||||
| Projection | none | ETA | none | Target Version | 3.0PR15Q2 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | alostale | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0028010: Some labels defined on js files can not be traslated. | |||||||
| Description | Some labels defined on js files can not be traslated. The labels are: Configure Sort (Shown when clicking with the right button on the header of the widget grid) Auto fit all columns (right clicking on the header of the grid of a selector) Auto fit (right clicking on the header of the grid of a selector) Theyu are defined at: modules/org.openbravo.userinterface.smartclient/web/org.openbravo.userinterface.smartclient/isomorphic/ISC_Combined.js Other lables defined on the same file are also used at the following url and can be translated: modules/org.openbravo.userinterface.smartclient/web/org.openbravo.userinterface.smartclient/js/ob-smartclient-labels.js | |||||||
| Steps To Reproduce | check the code | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0071720) alostale (manager) 2014-11-17 17:50 |
note: make translatable only those ones that are actually used |
|
(0071921) alostale (manager) 2014-11-24 09:46 |
Please provide the list of non-translatable labels that are actually used in the application. |
|
(0073806) alostale (manager) 2015-01-27 12:34 |
Proposed solution: * "Configure Sort": do not make translatable, it should be removed by 0028776 * "Auto fit all columns" and "Auto fit": make them translatable |
|
(0073949) hgbot (developer) 2015-01-30 14:03 |
Repository: erp/devel/pi Changeset: f8292e9b2d8bbaad9fc5bce9e135add5f7811477 Author: Inigo Sanchez <inigo.sanchez <at> openbravo.com> Date: Fri Jan 30 14:01:23 2015 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/f8292e9b2d8bbaad9fc5bce9e135add5f7811477 [^] Fixes issue 28010: Some labels defined on js files can not be traslated It have been added capability to also translate 'Auto fit all columns' and 'Auto fit' strings. --- M modules/org.openbravo.userinterface.smartclient/src-db/database/sourcedata/AD_MESSAGE.xml M modules/org.openbravo.userinterface.smartclient/web/org.openbravo.userinterface.smartclient/js/ob-smartclient-labels.js --- |
|
(0074011) alostale (manager) 2015-02-03 08:57 edited on: 2015-02-03 08:59 |
tested code review for changeset http://code.openbravo.com/erp/devel/pi/rev/f8292e9b2d8bbaad9fc5bce9e135add5f7811477: [^] -Missing jsBeautifier (incorrect indentation for new properties) -Adding multiple properties to ListGrid can be done in a single sentence to improve readability: isc.ListGrid.addProperties({ autoFitAllText: getLabel('OBUISC_ListGrid.autoFitAllText'), autoFitFieldText: getLabel('OBUISC_ListGrid.autoFitFieldText'), // ... add the rest of properties }); instead of: isc.ListGrid.addProperties({ autoFitAllText: getLabel('OBUISC_ListGrid.autoFitAllText') }); isc.ListGrid.addProperties({ autoFitFieldText: getLabel('OBUISC_ListGrid.autoFitFieldText') }); closing the issue anyway as these are minor style issues. |
|
(0074202) hudsonbot (developer) 2015-02-04 20:34 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/f36c91d0ad63 [^] Maturity status: Test |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2014-10-28 17:52 | egoitz | New Issue | |
| 2014-10-28 17:52 | egoitz | Assigned To | => AugustoMauch |
| 2014-10-28 17:52 | egoitz | Modules | => Core |
| 2014-10-28 17:52 | egoitz | Triggers an Emergency Pack | => No |
| 2014-10-29 13:07 | jonalegriaesarte | Resolution time | => 1418166000 |
| 2014-10-29 13:07 | jonalegriaesarte | Target Version | => 3.0PR15Q1 |
| 2014-11-17 17:49 | alostale | Assigned To | AugustoMauch => NaroaIriarte |
| 2014-11-17 17:50 | alostale | Note Added: 0071720 | |
| 2014-11-19 10:32 | alostale | Severity | major => trivial |
| 2014-11-24 09:46 | alostale | Note Added: 0071921 | |
| 2014-11-24 09:46 | alostale | Status | new => feedback |
| 2014-12-09 13:30 | egoitz | Resolution time | 1418166000 => 1421362800 |
| 2014-12-09 13:30 | egoitz | Target Version | 3.0PR15Q1 => 3.0PR15Q2 |
| 2015-01-14 08:58 | jonalegriaesarte | Assigned To | NaroaIriarte => egoitz |
| 2015-01-26 13:16 | egoitz | Description Updated | View Revisions |
| 2015-01-26 13:24 | egoitz | Description Updated | View Revisions |
| 2015-01-26 13:43 | egoitz | Assigned To | egoitz => alostale |
| 2015-01-26 13:44 | egoitz | Status | feedback => new |
| 2015-01-27 09:12 | alostale | Relationship added | related to 0028776 |
| 2015-01-27 09:12 | alostale | Relationship replaced | depends on 0028776 |
| 2015-01-27 12:34 | alostale | Note Added: 0073806 | |
| 2015-01-28 08:23 | alostale | Assigned To | alostale => inigosanchez |
| 2015-01-29 09:54 | alostale | Status | new => scheduled |
| 2015-01-30 14:02 | inigosanchez | Issue Monitored: alostale | |
| 2015-01-30 14:02 | inigosanchez | Review Assigned To | => alostale |
| 2015-01-30 14:02 | inigosanchez | Resolution | open => fixed |
| 2015-01-30 14:03 | hgbot | Checkin | |
| 2015-01-30 14:03 | hgbot | Note Added: 0073949 | |
| 2015-01-30 14:03 | hgbot | Status | scheduled => resolved |
| 2015-01-30 14:03 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/f8292e9b2d8bbaad9fc5bce9e135add5f7811477 [^] |
| 2015-02-03 08:57 | alostale | Note Added: 0074011 | |
| 2015-02-03 08:57 | alostale | Status | resolved => closed |
| 2015-02-03 08:57 | alostale | Fixed in Version | => 3.0PR15Q2 |
| 2015-02-03 08:57 | alostale | Note Edited: 0074011 | View Revisions |
| 2015-02-03 08:59 | alostale | Note Edited: 0074011 | View Revisions |
| 2015-02-04 20:34 | hudsonbot | Checkin | |
| 2015-02-04 20:34 | hudsonbot | Note Added: 0074202 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |