Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0028010Openbravo ERPB. User interfacepublic2014-10-28 17:522015-02-04 20:34
Reporteregoitz 
Assigned Toinigosanchez 
PriorityurgentSeveritytrivialReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR15Q2Fixed in Version3.0PR15Q2 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0028010: Some labels defined on js files can not be traslated.
DescriptionSome labels defined on
js files can not be traslated.
The labels are:
Configure Sort (Shown when clicking with the right button on the header of the widget grid)
Auto fit all columns (right clicking on the header of the grid of a selector)
Auto fit (right clicking on the header of the grid of a selector)

Theyu are defined at:

modules/org.openbravo.userinterface.smartclient/web/org.openbravo.userinterface.smartclient/isomorphic/ISC_Combined.js

Other lables defined on the same file are also used at the following url and can be translated:

modules/org.openbravo.userinterface.smartclient/web/org.openbravo.userinterface.smartclient/js/ob-smartclient-labels.js
Steps To Reproducecheck the code
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on defect 00287763.0PR15Q2 closed inigosanchez UI shows multi column sort in non standard grids 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2014-10-28 17:52egoitzNew Issue
2014-10-28 17:52egoitzAssigned To => AugustoMauch
2014-10-28 17:52egoitzModules => Core
2014-10-28 17:52egoitzTriggers an Emergency Pack => No
2014-10-29 13:07jonalegriaesarteResolution time => 1418166000
2014-10-29 13:07jonalegriaesarteTarget Version => 3.0PR15Q1
2014-11-17 17:49alostaleAssigned ToAugustoMauch => NaroaIriarte
2014-11-17 17:50alostaleNote Added: 0071720
2014-11-19 10:32alostaleSeveritymajor => trivial
2014-11-24 09:46alostaleNote Added: 0071921
2014-11-24 09:46alostaleStatusnew => feedback
2014-12-09 13:30egoitzResolution time1418166000 => 1421362800
2014-12-09 13:30egoitzTarget Version3.0PR15Q1 => 3.0PR15Q2
2015-01-14 08:58jonalegriaesarteAssigned ToNaroaIriarte => egoitz
2015-01-26 13:16egoitzDescription Updatedbug_revision_view_page.php?rev_id=7534#r7534
2015-01-26 13:24egoitzDescription Updatedbug_revision_view_page.php?rev_id=7535#r7535
2015-01-26 13:43egoitzAssigned Toegoitz => alostale
2015-01-26 13:44egoitzStatusfeedback => new
2015-01-27 09:12alostaleRelationship addedrelated to 0028776
2015-01-27 09:12alostaleRelationship replaceddepends on 0028776
2015-01-27 12:34alostaleNote Added: 0073806
2015-01-28 08:23alostaleAssigned Toalostale => inigosanchez
2015-01-29 09:54alostaleStatusnew => scheduled
2015-01-30 14:02inigosanchezIssue Monitored: alostale
2015-01-30 14:02inigosanchezReview Assigned To => alostale
2015-01-30 14:02inigosanchezResolutionopen => fixed
2015-01-30 14:03hgbotCheckin
2015-01-30 14:03hgbotNote Added: 0073949
2015-01-30 14:03hgbotStatusscheduled => resolved
2015-01-30 14:03hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/f8292e9b2d8bbaad9fc5bce9e135add5f7811477 [^]
2015-02-03 08:57alostaleNote Added: 0074011
2015-02-03 08:57alostaleStatusresolved => closed
2015-02-03 08:57alostaleFixed in Version => 3.0PR15Q2
2015-02-03 08:57alostaleNote Edited: 0074011bug_revision_view_page.php?bugnote_id=0074011#r7587
2015-02-03 08:59alostaleNote Edited: 0074011bug_revision_view_page.php?bugnote_id=0074011#r7588
2015-02-04 20:34hudsonbotCheckin
2015-02-04 20:34hudsonbotNote Added: 0074202

Notes
(0071720)
alostale   
2014-11-17 17:50   
note: make translatable only those ones that are actually used
(0071921)
alostale   
2014-11-24 09:46   
Please provide the list of non-translatable labels that are actually used in the application.
(0073806)
alostale   
2015-01-27 12:34   
Proposed solution:
* "Configure Sort": do not make translatable, it should be removed by 0028776
* "Auto fit all columns" and "Auto fit": make them translatable
(0073949)
hgbot   
2015-01-30 14:03   
Repository: erp/devel/pi
Changeset: f8292e9b2d8bbaad9fc5bce9e135add5f7811477
Author: Inigo Sanchez <inigo.sanchez <at> openbravo.com>
Date: Fri Jan 30 14:01:23 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/f8292e9b2d8bbaad9fc5bce9e135add5f7811477 [^]

Fixes issue 28010: Some labels defined on js files can not be traslated

It have been added capability to also translate 'Auto fit all columns'
and 'Auto fit' strings.

---
M modules/org.openbravo.userinterface.smartclient/src-db/database/sourcedata/AD_MESSAGE.xml
M modules/org.openbravo.userinterface.smartclient/web/org.openbravo.userinterface.smartclient/js/ob-smartclient-labels.js
---
(0074011)
alostale   
2015-02-03 08:57   
(edited on: 2015-02-03 08:59)
tested

code review for changeset http://code.openbravo.com/erp/devel/pi/rev/f8292e9b2d8bbaad9fc5bce9e135add5f7811477: [^]
-Missing jsBeautifier (incorrect indentation for new properties)
-Adding multiple properties to ListGrid can be done in a single sentence to improve readability:

  isc.ListGrid.addProperties({
    autoFitAllText: getLabel('OBUISC_ListGrid.autoFitAllText'),
    autoFitFieldText: getLabel('OBUISC_ListGrid.autoFitFieldText'),
    // ... add the rest of properties
  });

instead of:

  isc.ListGrid.addProperties({
    autoFitAllText: getLabel('OBUISC_ListGrid.autoFitAllText')
  });
  isc.ListGrid.addProperties({
    autoFitFieldText: getLabel('OBUISC_ListGrid.autoFitFieldText')
  });

closing the issue anyway as these are minor style issues.
(0074202)
hudsonbot   
2015-02-04 20:34   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/f36c91d0ad63 [^]
Maturity status: Test