Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0027955
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] Z. Othersminoralways2014-10-23 10:202015-02-04 20:33
ReportermaiteView Statuspublic 
Assigned Toreinaldoguerra 
PriorityhighResolutionfixedFixed in Versionpi
StatusclosedFix in branchFixed in SCM revision5f64300e4811
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Toumartirena
Web browser
ModulesAdvanced Payables and Receivables Mngmt
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0027955: Improve error messages when setting invalid amounts in "Modify Payment Plan" functionality

DescriptionAs described in the wiki (http://wiki.openbravo.com/wiki/Projects/Editable_Payment_Plan/User_Manual [^]) "submit buttons are not available unless all the amounts are correct". However, now buttons are available and error received when running "submit" button is a generic "Process failed during execution"
Steps To Reproduce1. Access as System Administrator ACTIVE "Modify payment plan" field in Purchase Invoice Window | Payment Plan tab
2. Logout and login
3. Access Purchase Invoice window, search for any invoice set as "Payment Complete=No" and access to Payment Plan tab
4. Run "Modify Payment Plan" process and edit existent line to set invalid amount, for example higher outstanding and expected amount that invoice's total. Run "Submit" button and error "Process failed during execution" will be reaised
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0072048)
reinaldoguerra (developer)
2014-11-26 21:09
edited on: 2015-01-09 04:58

Test plan used:
1- Login into Openbravo ERP
2- As System Administrator go to Purchase Invoice Window | Payment Plan tab
3- Display Modify payment plan field
4- Logout and login
5- Access Purchase Invoice window, search for any invoice with "Payment Complete" as "No" and access to Payment Plan tab
6- Select a record and run "Modify Payment Plan" process
7- Edit existent line to set invalid amount, for example higher outstanding amount than the invoice's total.
8- Realize that an error is shown when trying to submit the changes and the grid cell is marked with a red color.
9- However note that it is possible to add a new line and modify existent outstanding amounts in a way that the sum of all records matches with the invoice's total.

(0073408)
hgbot (developer)
2015-01-12 09:47

Repository: erp/devel/pi
Changeset: 5f64300e481181aecbaab774f6fa196e741b8470
Author: Reinaldo Guerra <reinaldo.guerra <at> peoplewalking.com>
Date: Thu Jan 08 22:40:37 2015 -0500
URL: http://code.openbravo.com/erp/devel/pi/rev/5f64300e481181aecbaab774f6fa196e741b8470 [^]

Fixed bug 27955: Improve error msg for invalid amounts in Modify Payment Plan.

On change behaviour for the field Outstanding amount in Modify Payment Out Plan Pick and Execute window, was changed to take into account a javascript validation function named: validateModifyPaymentPlanAmounts.
This validation function launches an error when trying to submit a higher outstanding amount than invoice's total, during payment plan's modification.

---
M src-db/database/sourcedata/AD_FIELD.xml
---
(0073409)
umartirena (reporter)
2015-01-12 09:48

Code review and Testing Done.
(0074133)
hudsonbot (developer)
2015-02-04 20:33

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/f36c91d0ad63 [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2014-10-23 10:20 maite New Issue
2014-10-23 10:20 maite Assigned To => dmiguelez
2014-10-23 10:20 maite Modules => Advanced Payables and Receivables Mngmt
2014-10-23 10:20 maite Resolution time => 1420585200
2014-10-23 10:20 maite Triggers an Emergency Pack => No
2014-10-23 10:20 maite Issue Monitored: networkb
2014-10-31 13:09 dmitry_mezentsev Assigned To dmiguelez => Sandrahuguet
2014-11-25 14:56 reinaldoguerra Assigned To Sandrahuguet => reinaldoguerra
2014-11-25 14:56 reinaldoguerra Status new => scheduled
2014-11-26 21:09 reinaldoguerra Note Added: 0072048
2015-01-09 04:58 reinaldoguerra Note Edited: 0072048 View Revisions
2015-01-12 09:47 hgbot Checkin
2015-01-12 09:47 hgbot Note Added: 0073408
2015-01-12 09:47 hgbot Status scheduled => resolved
2015-01-12 09:47 hgbot Resolution open => fixed
2015-01-12 09:47 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/5f64300e481181aecbaab774f6fa196e741b8470 [^]
2015-01-12 09:48 umartirena Review Assigned To => umartirena
2015-01-12 09:48 umartirena Note Added: 0073409
2015-01-12 09:48 umartirena Status resolved => closed
2015-01-12 09:48 umartirena Fixed in Version => pi
2015-02-04 20:33 hudsonbot Checkin
2015-02-04 20:33 hudsonbot Note Added: 0074133


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker