Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0027955Openbravo ERPZ. Otherspublic2014-10-23 10:202015-02-04 20:33
maite 
reinaldoguerra 
highminoralways
closedfixed 
5
 
pi 
umartirena
Advanced Payables and Receivables Mngmt
No
0027955: Improve error messages when setting invalid amounts in "Modify Payment Plan" functionality
As described in the wiki (http://wiki.openbravo.com/wiki/Projects/Editable_Payment_Plan/User_Manual [^]) "submit buttons are not available unless all the amounts are correct". However, now buttons are available and error received when running "submit" button is a generic "Process failed during execution"
1. Access as System Administrator ACTIVE "Modify payment plan" field in Purchase Invoice Window | Payment Plan tab
2. Logout and login
3. Access Purchase Invoice window, search for any invoice set as "Payment Complete=No" and access to Payment Plan tab
4. Run "Modify Payment Plan" process and edit existent line to set invalid amount, for example higher outstanding and expected amount that invoice's total. Run "Submit" button and error "Process failed during execution" will be reaised
No tags attached.
Issue History
2014-10-23 10:20maiteNew Issue
2014-10-23 10:20maiteAssigned To => dmiguelez
2014-10-23 10:20maiteModules => Advanced Payables and Receivables Mngmt
2014-10-23 10:20maiteResolution time => 1420585200
2014-10-23 10:20maiteTriggers an Emergency Pack => No
2014-10-23 10:20maiteIssue Monitored: networkb
2014-10-31 13:09dmitry_mezentsevAssigned Todmiguelez => Sandrahuguet
2014-11-25 14:56reinaldoguerraAssigned ToSandrahuguet => reinaldoguerra
2014-11-25 14:56reinaldoguerraStatusnew => scheduled
2014-11-26 21:09reinaldoguerraNote Added: 0072048
2015-01-09 04:58reinaldoguerraNote Edited: 0072048bug_revision_view_page.php?bugnote_id=0072048#r7409
2015-01-12 09:47hgbotCheckin
2015-01-12 09:47hgbotNote Added: 0073408
2015-01-12 09:47hgbotStatusscheduled => resolved
2015-01-12 09:47hgbotResolutionopen => fixed
2015-01-12 09:47hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/5f64300e481181aecbaab774f6fa196e741b8470 [^]
2015-01-12 09:48umartirenaReview Assigned To => umartirena
2015-01-12 09:48umartirenaNote Added: 0073409
2015-01-12 09:48umartirenaStatusresolved => closed
2015-01-12 09:48umartirenaFixed in Version => pi
2015-02-04 20:33hudsonbotCheckin
2015-02-04 20:33hudsonbotNote Added: 0074133

Notes
(0072048)
reinaldoguerra   
2014-11-26 21:09   
(edited on: 2015-01-09 04:58)
Test plan used:
1- Login into Openbravo ERP
2- As System Administrator go to Purchase Invoice Window | Payment Plan tab
3- Display Modify payment plan field
4- Logout and login
5- Access Purchase Invoice window, search for any invoice with "Payment Complete" as "No" and access to Payment Plan tab
6- Select a record and run "Modify Payment Plan" process
7- Edit existent line to set invalid amount, for example higher outstanding amount than the invoice's total.
8- Realize that an error is shown when trying to submit the changes and the grid cell is marked with a red color.
9- However note that it is possible to add a new line and modify existent outstanding amounts in a way that the sum of all records matches with the invoice's total.

(0073408)
hgbot   
2015-01-12 09:47   
Repository: erp/devel/pi
Changeset: 5f64300e481181aecbaab774f6fa196e741b8470
Author: Reinaldo Guerra <reinaldo.guerra <at> peoplewalking.com>
Date: Thu Jan 08 22:40:37 2015 -0500
URL: http://code.openbravo.com/erp/devel/pi/rev/5f64300e481181aecbaab774f6fa196e741b8470 [^]

Fixed bug 27955: Improve error msg for invalid amounts in Modify Payment Plan.

On change behaviour for the field Outstanding amount in Modify Payment Out Plan Pick and Execute window, was changed to take into account a javascript validation function named: validateModifyPaymentPlanAmounts.
This validation function launches an error when trying to submit a higher outstanding amount than invoice's total, during payment plan's modification.

---
M src-db/database/sourcedata/AD_FIELD.xml
---
(0073409)
umartirena   
2015-01-12 09:48   
Code review and Testing Done.
(0074133)
hudsonbot   
2015-02-04 20:33   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/f36c91d0ad63 [^]
Maturity status: Test