Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0027717
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSminoralways2014-09-30 13:192014-11-24 06:10
ReportercaristuView Statuspublic 
Assigned Tomarvintm 
PriorityhighResolutionfixedFixed in VersionRR15Q1
StatusclosedFix in branchFixed in SCM revisiona20737724e27
ProjectionnoneETAnoneTarget VersionRR15Q1
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomtaal
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0027717: printDiscount and discountInTotal methods are not being consistent with manual discounts

DescriptionprintDiscount and discountInTotal methods are not being consistent with manual discounts:

- For manual discounts: it is calculating the discount without taking into account the quantity of the line

- For automatic discounts: the getTotalAmountOfPromotions() is returning the correct sum of the discounts for the line
Steps To Reproduce1) Create a print receipt that makes use of the printDiscount function.

2) The discount is calculated different depending on the applied discount.
Proposed Solutionmultiply the calculated discount by the line quantity for the manual discounts. Patch attached.
TagsNo tags attached.
Attached Filesdiff file icon 27717.diff [^] (1,238 bytes) 2014-09-30 13:24 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0071668)
hgbot (developer)
2014-11-16 13:06

Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: a20737724e27a9249a03ec0d15d0fd335751b472
Author: Salvador Zapata <salvador.zapata <at> gmail.com>
Date: Sat Nov 15 14:40:50 2014 -0300
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a20737724e27a9249a03ec0d15d0fd335751b472 [^]

Fixed issue 27717: Multiplied the calculated discount by the line quantity for the manual discounts

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0071906)
mtaal (manager)
2014-11-24 06:10

discountInTotal method which was changed seems not to be used anymore. But maintained for backward combat, change looks good.

tested and reviewed

- Issue History
Date Modified Username Field Change
2014-09-30 13:19 caristu New Issue
2014-09-30 13:19 caristu Assigned To => marvintm
2014-09-30 13:19 caristu Resolution time => 1418338800
2014-09-30 13:19 caristu Triggers an Emergency Pack => No
2014-09-30 13:19 caristu Issue Monitored: networkb
2014-09-30 13:22 caristu Summary printDiscount method is not being consistent with manual discounts => printDiscount and discountInTotal methods are not being consistent with manual discounts
2014-09-30 13:22 caristu Description Updated View Revisions
2014-09-30 13:22 caristu Steps to Reproduce Updated View Revisions
2014-09-30 13:22 caristu Proposed Solution updated
2014-09-30 13:24 caristu File Added: 27717.diff
2014-09-30 14:31 mtaal Target Version RR14Q4 => RR15Q1
2014-11-16 13:06 hgbot Checkin
2014-11-16 13:06 hgbot Note Added: 0071668
2014-11-16 13:06 hgbot Status new => resolved
2014-11-16 13:06 hgbot Resolution open => fixed
2014-11-16 13:06 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a20737724e27a9249a03ec0d15d0fd335751b472 [^]
2014-11-24 06:10 mtaal Review Assigned To => mtaal
2014-11-24 06:10 mtaal Note Added: 0071906
2014-11-24 06:10 mtaal Status resolved => closed
2014-11-24 06:10 mtaal Fixed in Version => RR15Q1


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker