Openbravo Issue Tracking System - Retail Modules
View Issue Details
0027717Retail ModulesWeb POSpublic2014-09-30 13:192014-11-24 06:10
caristu 
marvintm 
highminoralways
closedfixed 
5
 
RR15Q1RR15Q1 
mtaal
No
0027717: printDiscount and discountInTotal methods are not being consistent with manual discounts
printDiscount and discountInTotal methods are not being consistent with manual discounts:

- For manual discounts: it is calculating the discount without taking into account the quantity of the line

- For automatic discounts: the getTotalAmountOfPromotions() is returning the correct sum of the discounts for the line
1) Create a print receipt that makes use of the printDiscount function.

2) The discount is calculated different depending on the applied discount.
multiply the calculated discount by the line quantity for the manual discounts. Patch attached.
No tags attached.
diff 27717.diff (1,238) 2014-09-30 13:24
https://issues.openbravo.com/file_download.php?file_id=7285&type=bug
Issue History
2014-09-30 13:19caristuNew Issue
2014-09-30 13:19caristuAssigned To => marvintm
2014-09-30 13:19caristuResolution time => 1418338800
2014-09-30 13:19caristuTriggers an Emergency Pack => No
2014-09-30 13:19caristuIssue Monitored: networkb
2014-09-30 13:22caristuSummaryprintDiscount method is not being consistent with manual discounts => printDiscount and discountInTotal methods are not being consistent with manual discounts
2014-09-30 13:22caristuDescription Updatedbug_revision_view_page.php?rev_id=6693#r6693
2014-09-30 13:22caristuSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=6695#r6695
2014-09-30 13:22caristuProposed Solution updated
2014-09-30 13:24caristuFile Added: 27717.diff
2014-09-30 14:31mtaalTarget VersionRR14Q4 => RR15Q1
2014-11-16 13:06hgbotCheckin
2014-11-16 13:06hgbotNote Added: 0071668
2014-11-16 13:06hgbotStatusnew => resolved
2014-11-16 13:06hgbotResolutionopen => fixed
2014-11-16 13:06hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a20737724e27a9249a03ec0d15d0fd335751b472 [^]
2014-11-24 06:10mtaalReview Assigned To => mtaal
2014-11-24 06:10mtaalNote Added: 0071906
2014-11-24 06:10mtaalStatusresolved => closed
2014-11-24 06:10mtaalFixed in Version => RR15Q1

Notes
(0071668)
hgbot   
2014-11-16 13:06   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: a20737724e27a9249a03ec0d15d0fd335751b472
Author: Salvador Zapata <salvador.zapata <at> gmail.com>
Date: Sat Nov 15 14:40:50 2014 -0300
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a20737724e27a9249a03ec0d15d0fd335751b472 [^]

Fixed issue 27717: Multiplied the calculated discount by the line quantity for the manual discounts

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0071906)
mtaal   
2014-11-24 06:10   
discountInTotal method which was changed seems not to be used anymore. But maintained for backward combat, change looks good.

tested and reviewed