Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0027685
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 09. Financial managementmajoralways2014-09-25 13:122016-09-30 19:07
ReportermiruritaView Statuspublic 
Assigned Tomarkmm82 
PriorityurgentResolutionfixedFixed in Version3.0PR16Q4
StatusclosedFix in branchFixed in SCM revision1c1d272bdb98
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned Toaferraz
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket43787
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0027685: Undo Close Year does not filter by organization

DescriptionWhen doing a UNDO CLOSE YEAR, Im getting a message that I cant undo the close because a future year is closed. This is not true for this organization.
Steps To ReproduceHave years 2012 and 2013 and organization A and B.
CLOSE 2012 and 2013 for organization A.
CLOSE 2012 for organization B. Try to undo the closing.

Steps to reproduce:
-Create new organization (Initial Organization Setup)
    Name: A
    Type: Organization with Legal Accounting
    Parent: F&B International Group
-Create new organization (Initial Organization Setup)
    Name: B
    Type: Organization with Legal Accounting
    Parent: F&B International Group
-Create new Fiscal Calendar
    Organization: F&B International Group
    Name: Test
    Active: true
    ->Save
-Add Year 2012 to A_Calendar
-Create periods button for year 2012.
-Add Year 2013 to A_Calendar
-Create periods button for year 2013.
-Add Year 2014 to A_Calendar
-Create periods button for year 2014.

-Go to Organization Screen.
-Select Organization A.
    Check th Allow Period checkbox.
    Set Test calendar
    ->Save
    ->Set as Ready Organization A
-Select Organization B.
    Check th Allow Period checkbox.
    Set Test calendar
    ->Save
    ->Set as Ready Organization B

-Go to Open/Close Period Control
    Filter by Test calendar.
    Select all (Note the 36 periods for 2012, 2013 and 2014)
    ->Open periods

-Go to End Year Close window
    Filter by Test calendar.
    ->Close Test calendar for 2012 year and A organization
    ->Close Test calendar for 2013 year and A organization
    ->Close Test calendar for 2012 year and B organization
    ->Undo Year Close for Test calendar, 2012 year and B organization and realize the following error message is shown: In order to undo the closing of a year, all future years must be NOT CLOSED.
Proposed SolutionFilter correctly by organization when checking if the selected organization has a future closing year in selectUndoAllowed method in EndYearCloseUtility_data.xsql file.

TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0034096 closedSanjota End Year Close process does not check by organization if the previous periods are closed 

-  Notes
(0083173)
markmm82 (viewer)
2016-01-07 21:01

 Test Plan

As F&B International Group Admin

In Initial Organization Setup window
Create new organization
 Name: A
 Type: Organization with Legal Accounting
 Parent: F&B International Group
Create new organization
 Name: B
 Type: Organization with Legal Accounting
 Parent: F&B International Group
    
In Fiscal Calendar window
Create new Fiscal Calendar
 Organization: F&B International Group
 Name: Test
 Active: true

In Fiscal Calendar || Year tab
Add Year 2012 to Test calendar
 Create periods button for year 2012.
Add Year 2013 to Test calendar
 Create periods button for year 2013.
Add Year 2014 to Test calendar
 Create periods button for year 2014.

In Organization window
Select Organization A.
 Check th Allow Period checkbox.
 Set Test calendar
 Set as Ready Organization A
Select Organization B.
 Check th Allow Period checkbox.
 Set Test calendar
 Set as Ready Organization B

In Open/Close Period Control window
 Filter by Test calendar.
 Select all (Note the 36 periods for 2012, 2013 and 2014)
 Open periods

In Go to End Year Close window
 Filter by Test calendar.
 Close Test calendar for 2012 year and A organization
 Close Test calendar for 2013 year and A organization
 Close Test calendar for 2012 year and B organization
 Undo Year Close for Test calendar, 2012 year and B organization
 
Check that Undo Year Close proccess was made rightly
(0090419)
hgbot (developer)
2016-09-30 12:42

 Repository: erp/devel/pi
Changeset: 1c1d272bdb98897f794de964d9ed68903e5c7614
Author: Mark <markmm82 <at> gmail.com>
Date: Thu Jan 07 14:50:44 2016 -0500
URL: http://code.openbravo.com/erp/devel/pi/rev/1c1d272bdb98897f794de964d9ed68903e5c7614 [^]

Fixes Issue 27685: The organization id is taken into account when doing Undo Year Close.

A new restriction was added to sql query to filtering by Organization.

---
M src/org/openbravo/erpCommon/businessUtility/EndYearCloseUtility.java
M src/org/openbravo/erpCommon/businessUtility/EndYearCloseUtility_data.xsql
---
(0090420)
hgbot (developer)
2016-09-30 12:43

 Repository: erp/devel/pi
Changeset: f865e486c4a807b0f692e919ace7aabedbfa16cc
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Fri Sep 30 09:24:45 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/f865e486c4a807b0f692e919ace7aabedbfa16cc [^]

Related to issue 27685: Update copyright

---
M src/org/openbravo/erpCommon/businessUtility/EndYearCloseUtility_data.xsql
---
(0090426)
aferraz (viewer)
2016-09-30 12:46

 Code review + Testing OK
(0090444)
hudsonbot (viewer)
2016-09-30 19:07

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/538700cbd709 [^]
Maturity status: Test
(0090445)
hudsonbot (viewer)
2016-09-30 19:07

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/538700cbd709 [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2014-09-25 13:12 mirurita New Issue
2014-09-25 13:12 mirurita Assigned To => dmiguelez
2014-09-25 13:12 mirurita OBNetwork customer => No
2014-09-25 13:12 mirurita Modules => Core
2014-09-25 13:12 mirurita Triggers an Emergency Pack => No
2015-12-28 15:06 markmm82 Status new => scheduled
2015-12-28 15:06 markmm82 Note Added: 0083015
2016-01-05 13:15 aferraz Steps to Reproduce Updated View Revisions
2016-01-05 13:15 aferraz Proposed Solution updated
2016-01-05 13:46 aferraz Assigned To dmiguelez => markmm82
2016-01-07 21:00 markmm82 Note Deleted: 0083015
2016-01-07 21:01 markmm82 Note Added: 0083173
2016-09-26 19:08 ngarcia OBNetwork customer No => Yes
2016-09-26 19:08 ngarcia Support ticket => 43787
2016-09-26 19:08 ngarcia Resolution time => 1476655200
2016-09-26 19:09 ngarcia Issue Monitored: networkb
2016-09-26 19:10 ngarcia Priority normal => urgent
2016-09-26 19:17 ngarcia Relationship added related to 0034096
2016-09-29 13:39 ngarcia Assigned To markmm82 => Triage Finance
2016-09-29 13:40 ngarcia Assigned To Triage Finance => markmm82
2016-09-30 12:42 hgbot Checkin
2016-09-30 12:42 hgbot Note Added: 0090419
2016-09-30 12:42 hgbot Status scheduled => resolved
2016-09-30 12:42 hgbot Resolution open => fixed
2016-09-30 12:42 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/1c1d272bdb98897f794de964d9ed68903e5c7614 [^]
2016-09-30 12:43 hgbot Checkin
2016-09-30 12:43 hgbot Note Added: 0090420
2016-09-30 12:46 aferraz Review Assigned To => aferraz
2016-09-30 12:46 aferraz Note Added: 0090426
2016-09-30 12:46 aferraz Status resolved => closed
2016-09-30 12:46 aferraz Fixed in Version => 3.0PR16Q4
2016-09-30 19:07 hudsonbot Checkin
2016-09-30 19:07 hudsonbot Note Added: 0090444
2016-09-30 19:07 hudsonbot Checkin
2016-09-30 19:07 hudsonbot Note Added: 0090445

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker