Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0027685Openbravo ERP09. Financial managementpublic2014-09-25 13:122016-09-30 19:07
Reportermirurita 
Assigned Tomarkmm82 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR16Q4 
Merge Request Status
Review Assigned Toaferraz
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0027685: Undo Close Year does not filter by organization
DescriptionWhen doing a UNDO CLOSE YEAR, Im getting a message that I cant undo the close because a future year is closed. This is not true for this organization.
Steps To ReproduceHave years 2012 and 2013 and organization A and B.
CLOSE 2012 and 2013 for organization A.
CLOSE 2012 for organization B. Try to undo the closing.

Steps to reproduce:
-Create new organization (Initial Organization Setup)
    Name: A
    Type: Organization with Legal Accounting
    Parent: F&B International Group
-Create new organization (Initial Organization Setup)
    Name: B
    Type: Organization with Legal Accounting
    Parent: F&B International Group
-Create new Fiscal Calendar
    Organization: F&B International Group
    Name: Test
    Active: true
    ->Save
-Add Year 2012 to A_Calendar
-Create periods button for year 2012.
-Add Year 2013 to A_Calendar
-Create periods button for year 2013.
-Add Year 2014 to A_Calendar
-Create periods button for year 2014.

-Go to Organization Screen.
-Select Organization A.
    Check th Allow Period checkbox.
    Set Test calendar
    ->Save
    ->Set as Ready Organization A
-Select Organization B.
    Check th Allow Period checkbox.
    Set Test calendar
    ->Save
    ->Set as Ready Organization B

-Go to Open/Close Period Control
    Filter by Test calendar.
    Select all (Note the 36 periods for 2012, 2013 and 2014)
    ->Open periods

-Go to End Year Close window
    Filter by Test calendar.
    ->Close Test calendar for 2012 year and A organization
    ->Close Test calendar for 2013 year and A organization
    ->Close Test calendar for 2012 year and B organization
    ->Undo Year Close for Test calendar, 2012 year and B organization and realize the following error message is shown: In order to undo the closing of a year, all future years must be NOT CLOSED.
Proposed SolutionFilter correctly by organization when checking if the selected organization has a future closing year in selectUndoAllowed method in EndYearCloseUtility_data.xsql file.

Additional Information
TagsNo tags attached.
Relationships
related to defect 0034096 closed Sanjota End Year Close process does not check by organization if the previous periods are closed 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2014-09-25 13:12miruritaNew Issue
2014-09-25 13:12miruritaAssigned To => dmiguelez
2014-09-25 13:12miruritaModules => Core
2014-09-25 13:12miruritaTriggers an Emergency Pack => No
2015-12-28 15:06markmm82Statusnew => scheduled
2015-12-28 15:06markmm82Note Added: 0083015
2016-01-05 13:15aferrazSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=10577#r10577
2016-01-05 13:15aferrazProposed Solution updated
2016-01-05 13:46aferrazAssigned Todmiguelez => markmm82
2016-01-07 21:00markmm82Note Deleted: 0083015
2016-01-07 21:01markmm82Note Added: 0083173
2016-09-26 19:08ngarciaResolution time => 1476655200
2016-09-26 19:09ngarciaIssue Monitored: networkb
2016-09-26 19:10ngarciaPrioritynormal => urgent
2016-09-26 19:17ngarciaRelationship addedrelated to 0034096
2016-09-29 13:39ngarciaAssigned Tomarkmm82 => Triage Finance
2016-09-29 13:40ngarciaAssigned ToTriage Finance => markmm82
2016-09-30 12:42hgbotCheckin
2016-09-30 12:42hgbotNote Added: 0090419
2016-09-30 12:42hgbotStatusscheduled => resolved
2016-09-30 12:42hgbotResolutionopen => fixed
2016-09-30 12:42hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/1c1d272bdb98897f794de964d9ed68903e5c7614 [^]
2016-09-30 12:43hgbotCheckin
2016-09-30 12:43hgbotNote Added: 0090420
2016-09-30 12:46aferrazReview Assigned To => aferraz
2016-09-30 12:46aferrazNote Added: 0090426
2016-09-30 12:46aferrazStatusresolved => closed
2016-09-30 12:46aferrazFixed in Version => 3.0PR16Q4
2016-09-30 19:07hudsonbotCheckin
2016-09-30 19:07hudsonbotNote Added: 0090444
2016-09-30 19:07hudsonbotCheckin
2016-09-30 19:07hudsonbotNote Added: 0090445

Notes
(0083173)
markmm82   
2016-01-07 21:01   
Test Plan

As F&B International Group Admin

In Initial Organization Setup window
Create new organization
 Name: A
 Type: Organization with Legal Accounting
 Parent: F&B International Group
Create new organization
 Name: B
 Type: Organization with Legal Accounting
 Parent: F&B International Group
    
In Fiscal Calendar window
Create new Fiscal Calendar
 Organization: F&B International Group
 Name: Test
 Active: true

In Fiscal Calendar || Year tab
Add Year 2012 to Test calendar
 Create periods button for year 2012.
Add Year 2013 to Test calendar
 Create periods button for year 2013.
Add Year 2014 to Test calendar
 Create periods button for year 2014.

In Organization window
Select Organization A.
 Check th Allow Period checkbox.
 Set Test calendar
 Set as Ready Organization A
Select Organization B.
 Check th Allow Period checkbox.
 Set Test calendar
 Set as Ready Organization B

In Open/Close Period Control window
 Filter by Test calendar.
 Select all (Note the 36 periods for 2012, 2013 and 2014)
 Open periods

In Go to End Year Close window
 Filter by Test calendar.
 Close Test calendar for 2012 year and A organization
 Close Test calendar for 2013 year and A organization
 Close Test calendar for 2012 year and B organization
 Undo Year Close for Test calendar, 2012 year and B organization
 
Check that Undo Year Close proccess was made rightly
(0090419)
hgbot   
2016-09-30 12:42   
Repository: erp/devel/pi
Changeset: 1c1d272bdb98897f794de964d9ed68903e5c7614
Author: Mark <markmm82 <at> gmail.com>
Date: Thu Jan 07 14:50:44 2016 -0500
URL: http://code.openbravo.com/erp/devel/pi/rev/1c1d272bdb98897f794de964d9ed68903e5c7614 [^]

Fixes Issue 27685: The organization id is taken into account when doing Undo Year Close.

A new restriction was added to sql query to filtering by Organization.

---
M src/org/openbravo/erpCommon/businessUtility/EndYearCloseUtility.java
M src/org/openbravo/erpCommon/businessUtility/EndYearCloseUtility_data.xsql
---
(0090420)
hgbot   
2016-09-30 12:43   
Repository: erp/devel/pi
Changeset: f865e486c4a807b0f692e919ace7aabedbfa16cc
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Fri Sep 30 09:24:45 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/f865e486c4a807b0f692e919ace7aabedbfa16cc [^]

Related to issue 27685: Update copyright

---
M src/org/openbravo/erpCommon/businessUtility/EndYearCloseUtility_data.xsql
---
(0090426)
aferraz   
2016-09-30 12:46   
Code review + Testing OK
(0090444)
hudsonbot   
2016-09-30 19:07   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/538700cbd709 [^]
Maturity status: Test
(0090445)
hudsonbot   
2016-09-30 19:07   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/538700cbd709 [^]
Maturity status: Test