Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0027529
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformmajorhave not tried2014-09-02 16:352014-09-25 11:30
ReporterAugustoMauchView Statuspublic 
Assigned ToAugustoMauch 
PriorityhighResolutionfixedFixed in Version3.0PR14Q4
StatusclosedFix in branchFixed in SCM revision1f2a65622d9d
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Toshankarb
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0027529: Parameter Windows should use the context of its owner tab to initialize the parameters

DescriptionParameter Windows should use the context of its owner tab to initialize the parameters. Currently the context of the active view is used, even if it is not the owner of the button.

This can be a problem if:
- The child tab where the button is opened overwrites its parent tab columns
- A child tab is active but no records are selected.
Steps To ReproduceCheck this line:
- https://code.openbravo.com/erp/devel/pi/file/995ac17cabcc/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-parameter-window-view.js#l298 [^]

this.sourceView is used, but instead this.buttonOwnerView should be used.
TagsNo tags attached.
Attached Files? file icon issue27529.export [^] (240 bytes) 2014-09-04 10:17

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 00380613.0PR18Q2 closedalostale Selector filter expression with OB.isSalesTransaction() doesn't work when called from a Process Definition 
causes defect 0027588 closedAugustoMauch Selectors don't work properly in Parameter Windows if are opened directly from a menu entry 

-  Notes
(0069956)
AugustoMauch (manager)
2014-09-04 10:17

 Fix pushed to try. The patch has been attached to the issue.
(0069967)
hgbot (developer)
2014-09-04 16:16

 Repository: erp/devel/pi
Changeset: 5e8878153d020c7a347832dec1e5513d5b19c2ca
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Thu Sep 04 10:13:18 2014 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/5e8878153d020c7a347832dec1e5513d5b19c2ca [^]

Fixes issue 27529: Param windows use context of owner view, not source view

When in a parameter window the context info of the underlying tab is requested, the tab to be should should be the tab where the parameter window is declared, even if one of its subtabs is currently active.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-parameter-window-view.js
M modules/org.openbravo.userinterface.selector/web/org.openbravo.userinterface.selector/js/ob-selector-item.js
---
(0069987)
hudsonbot (developer)
2014-09-05 14:52

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/31b085cc025e [^]
Maturity status: Test
(0070000)
shankarb (reporter)
2014-09-08 08:16

 Code reviewed and verified in pi changeset cbe3321d8ad2.
(0070277)
hgbot (developer)
2014-09-23 10:37

 Repository: erp/devel/pi
Changeset: 1f2a65622d9da2184a5a5761ff9b63819e9eb4f1
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Wed Sep 03 18:18:49 2014 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/1f2a65622d9da2184a5a5761ff9b63819e9eb4f1 [^]

Fixes issue 27529: Param windows use context of owner view, not source view

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-parameter-window-view.js
M modules/org.openbravo.userinterface.selector/web/org.openbravo.userinterface.selector/js/ob-selector-item.js
---
(0070294)
shankarb (reporter)
2014-09-24 08:03

 Same fix applied again in reconciliation refactor project merge.
(0070358)
hudsonbot (developer)
2014-09-25 11:30

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/63604e8e17b7 [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2014-09-02 16:35 AugustoMauch New Issue
2014-09-02 16:35 AugustoMauch Assigned To => AugustoMauch
2014-09-02 16:35 AugustoMauch Modules => Core
2014-09-02 16:35 AugustoMauch Triggers an Emergency Pack => No
2014-09-04 10:17 AugustoMauch Note Added: 0069956
2014-09-04 10:17 AugustoMauch File Added: issue27529.export
2014-09-04 16:16 hgbot Checkin
2014-09-04 16:16 hgbot Note Added: 0069967
2014-09-04 16:16 hgbot Status new => resolved
2014-09-04 16:16 hgbot Resolution open => fixed
2014-09-04 16:16 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/5e8878153d020c7a347832dec1e5513d5b19c2ca [^]
2014-09-04 16:17 AugustoMauch Issue Monitored: shankarb
2014-09-04 16:18 AugustoMauch Review Assigned To => shankarb
2014-09-05 14:52 hudsonbot Checkin
2014-09-05 14:52 hudsonbot Note Added: 0069987
2014-09-08 08:16 shankarb Note Added: 0070000
2014-09-08 08:16 shankarb Status resolved => closed
2014-09-08 08:16 shankarb Fixed in Version => 3.0PR14Q4
2014-09-11 12:57 AugustoMauch Relationship added causes 0027588
2014-09-23 10:37 hgbot Checkin
2014-09-23 10:37 hgbot Note Added: 0070277
2014-09-23 10:37 hgbot Status closed => resolved
2014-09-23 10:37 hgbot Fixed in SCM revision http://code.openbravo.com/erp/devel/pi/rev/5e8878153d020c7a347832dec1e5513d5b19c2ca [^] => http://code.openbravo.com/erp/devel/pi/rev/1f2a65622d9da2184a5a5761ff9b63819e9eb4f1 [^]
2014-09-24 08:03 shankarb Note Added: 0070294
2014-09-24 08:03 shankarb Status resolved => closed
2014-09-25 11:30 hudsonbot Checkin
2014-09-25 11:30 hudsonbot Note Added: 0070358
2018-03-07 12:35 alostale Relationship added related to 0038061

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker