Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0027529Openbravo ERPA. Platformpublic2014-09-02 16:352014-09-25 11:30
ReporterAugustoMauch 
Assigned ToAugustoMauch 
PriorityhighSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR14Q4 
Merge Request Status
Review Assigned Toshankarb
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0027529: Parameter Windows should use the context of its owner tab to initialize the parameters
DescriptionParameter Windows should use the context of its owner tab to initialize the parameters. Currently the context of the active view is used, even if it is not the owner of the button.

This can be a problem if:
- The child tab where the button is opened overwrites its parent tab columns
- A child tab is active but no records are selected.
Steps To ReproduceCheck this line:
- https://code.openbravo.com/erp/devel/pi/file/995ac17cabcc/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-parameter-window-view.js#l298 [^]

this.sourceView is used, but instead this.buttonOwnerView should be used.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 00380613.0PR18Q2 closed alostale Selector filter expression with OB.isSalesTransaction() doesn't work when called from a Process Definition 
causes defect 0027588 closed AugustoMauch Selectors don't work properly in Parameter Windows if are opened directly from a menu entry 
Attached Files? issue27529.export (240) 2014-09-04 10:17
https://issues.openbravo.com/file_download.php?file_id=7211&type=bug
Issue History
Date ModifiedUsernameFieldChange
2014-09-02 16:35AugustoMauchNew Issue
2014-09-02 16:35AugustoMauchAssigned To => AugustoMauch
2014-09-02 16:35AugustoMauchModules => Core
2014-09-02 16:35AugustoMauchTriggers an Emergency Pack => No
2014-09-04 10:17AugustoMauchNote Added: 0069956
2014-09-04 10:17AugustoMauchFile Added: issue27529.export
2014-09-04 16:16hgbotCheckin
2014-09-04 16:16hgbotNote Added: 0069967
2014-09-04 16:16hgbotStatusnew => resolved
2014-09-04 16:16hgbotResolutionopen => fixed
2014-09-04 16:16hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/5e8878153d020c7a347832dec1e5513d5b19c2ca [^]
2014-09-04 16:17AugustoMauchIssue Monitored: shankarb
2014-09-04 16:18AugustoMauchReview Assigned To => shankarb
2014-09-05 14:52hudsonbotCheckin
2014-09-05 14:52hudsonbotNote Added: 0069987
2014-09-08 08:16shankarbNote Added: 0070000
2014-09-08 08:16shankarbStatusresolved => closed
2014-09-08 08:16shankarbFixed in Version => 3.0PR14Q4
2014-09-11 12:57AugustoMauchRelationship addedcauses 0027588
2014-09-23 10:37hgbotCheckin
2014-09-23 10:37hgbotNote Added: 0070277
2014-09-23 10:37hgbotStatusclosed => resolved
2014-09-23 10:37hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/5e8878153d020c7a347832dec1e5513d5b19c2ca [^] => http://code.openbravo.com/erp/devel/pi/rev/1f2a65622d9da2184a5a5761ff9b63819e9eb4f1 [^]
2014-09-24 08:03shankarbNote Added: 0070294
2014-09-24 08:03shankarbStatusresolved => closed
2014-09-25 11:30hudsonbotCheckin
2014-09-25 11:30hudsonbotNote Added: 0070358
2018-03-07 12:35alostaleRelationship addedrelated to 0038061

Notes
(0069956)
AugustoMauch   
2014-09-04 10:17   
Fix pushed to try. The patch has been attached to the issue.
(0069967)
hgbot   
2014-09-04 16:16   
Repository: erp/devel/pi
Changeset: 5e8878153d020c7a347832dec1e5513d5b19c2ca
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Thu Sep 04 10:13:18 2014 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/5e8878153d020c7a347832dec1e5513d5b19c2ca [^]

Fixes issue 27529: Param windows use context of owner view, not source view

When in a parameter window the context info of the underlying tab is requested, the tab to be should should be the tab where the parameter window is declared, even if one of its subtabs is currently active.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-parameter-window-view.js
M modules/org.openbravo.userinterface.selector/web/org.openbravo.userinterface.selector/js/ob-selector-item.js
---
(0069987)
hudsonbot   
2014-09-05 14:52   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/31b085cc025e [^]
Maturity status: Test
(0070000)
shankarb   
2014-09-08 08:16   
Code reviewed and verified in pi changeset cbe3321d8ad2.
(0070277)
hgbot   
2014-09-23 10:37   
Repository: erp/devel/pi
Changeset: 1f2a65622d9da2184a5a5761ff9b63819e9eb4f1
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Wed Sep 03 18:18:49 2014 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/1f2a65622d9da2184a5a5761ff9b63819e9eb4f1 [^]

Fixes issue 27529: Param windows use context of owner view, not source view

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-parameter-window-view.js
M modules/org.openbravo.userinterface.selector/web/org.openbravo.userinterface.selector/js/ob-selector-item.js
---
(0070294)
shankarb   
2014-09-24 08:03   
Same fix applied again in reconciliation refactor project merge.
(0070358)
hudsonbot   
2014-09-25 11:30   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/63604e8e17b7 [^]
Maturity status: Test