Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0027437 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] 09. Financial management | trivial | have not tried | 2014-08-23 16:01 | 2015-08-20 23:16 | |||
| Reporter | shuehner | View Status | public | |||||
| Assigned To | AtulOpenbravo | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | 8d4487cdedc9 | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | vmromanos | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0027437: Trigger A_AMORTIZATIONLINE_TRG2 is useless and should be deleted | |||||||
| Description | That trigger does not contain any useful body. But all of it is commented out with some comment: mutating table. Hg log shows that to be the case since revision '0' (2007). The trigger should just be deleted as it does serve no purpose as it is. Important note: When deleting it should be checked if that commented code is functionally needed as if so needs to be added elsewhere. Note: If that is needed it should be reported as a separate related issue and fixed there. It should not stop the trigger deletion as it has been like this forever (a long time at least) | |||||||
| Steps To Reproduce | Check trigger body + hg history. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0069640) shuehner (administrator) 2014-08-23 16:01 |
Found by 'Unreachable code' warning of oracle |
|
(0078774) AtulOpenbravo (developer) 2015-07-13 13:28 edited on: 2015-07-13 13:29 |
Commented code in the trigger A_AMORTIZATIONLINE_TRG2 is implemented as a part of the commit https://code.openbravo.com/erp/devel/pi/rev/39a40ec8d089a2075b806fdc2e0175ff1446c4d3 [^] for the issue https://issues.openbravo.com/view.php?id=12460 [^] |
|
(0078784) hgbot (developer) 2015-07-14 09:50 edited on: 2015-07-16 12:04 |
Repository: erp/devel/pi Changeset: 8d4487cdedc9 Author: Atul Gaware <atul.gaware <at> openbravo.com> Date: Mon Jul 13 16:37:22 2015 +0530 URL: http://code.openbravo.com/erp/devel/pi/rev/8d4487cdedc9 [^] Fixes Issue 27437: Trigger A_AMORTIZATIONLINE_TRG2 is useless and should be deleted Removed trigger A_AMORIZATIONLINE_TRG2. Code to update DepreciatedPlan is implemented in A_AMORTIZATIONLINE_TRG so there is no harm in removing this trigger. --- R src-db/database/model/triggers/A_AMORTIZATIONLINE_TRG2.xml --- |
|
(0078785) vmromanos (manager) 2015-07-14 09:51 |
Verified |
|
(0079492) hudsonbot (developer) 2015-08-20 23:16 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/8c91718397a5 [^] Maturity status: Test |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2014-08-23 16:01 | shuehner | New Issue | |
| 2014-08-23 16:01 | shuehner | Assigned To | => dmiguelez |
| 2014-08-23 16:01 | shuehner | Modules | => Core |
| 2014-08-23 16:01 | shuehner | Triggers an Emergency Pack | => No |
| 2014-08-23 16:01 | shuehner | Note Added: 0069640 | |
| 2014-09-03 14:10 | eduardo_Argal | Assigned To | dmiguelez => eduardo_Argal |
| 2015-07-13 13:26 | AtulOpenbravo | Assigned To | eduardo_Argal => AtulOpenbravo |
| 2015-07-13 13:26 | AtulOpenbravo | Status | new => scheduled |
| 2015-07-13 13:28 | AtulOpenbravo | Note Added: 0078774 | |
| 2015-07-13 13:29 | AtulOpenbravo | Note Edited: 0078774 | View Revisions |
| 2015-07-14 09:50 | hgbot | Checkin | |
| 2015-07-14 09:50 | hgbot | Note Added: 0078784 | |
| 2015-07-14 09:50 | hgbot | Status | scheduled => resolved |
| 2015-07-14 09:50 | hgbot | Resolution | open => fixed |
| 2015-07-14 09:50 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/ed5b74af3fa682bd2748163f83f89f6adb423071 [^] |
| 2015-07-14 09:51 | vmromanos | Review Assigned To | => vmromanos |
| 2015-07-14 09:51 | vmromanos | Note Added: 0078785 | |
| 2015-07-14 09:51 | vmromanos | Status | resolved => closed |
| 2015-07-16 12:04 | gorka_gil | Fixed in SCM revision | http://code.openbravo.com/erp/devel/pi/rev/ed5b74af3fa682bd2748163f83f89f6adb423071 [^] => http://code.openbravo.com/erp/devel/pi/rev/8d4487cdedc9 [^] |
| 2015-07-16 12:04 | gorka_gil | Note Edited: 0078784 | View Revisions |
| 2015-08-20 23:16 | hudsonbot | Checkin | |
| 2015-08-20 23:16 | hudsonbot | Note Added: 0079492 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |