Openbravo Issue Tracking System - Openbravo ERP |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0027437 | Openbravo ERP | 09. Financial management | public | 2014-08-23 16:01 | 2015-08-20 23:16 |
|
| Reporter | shuehner | |
| Assigned To | AtulOpenbravo | |
| Priority | normal | Severity | trivial | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | | Fixed in Version | | |
| Merge Request Status | |
| Review Assigned To | vmromanos |
| OBNetwork customer | |
| Web browser | |
| Modules | Core |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0027437: Trigger A_AMORTIZATIONLINE_TRG2 is useless and should be deleted |
| Description | That trigger does not contain any useful body.
But all of it is commented out with some comment: mutating table.
Hg log shows that to be the case since revision '0' (2007).
The trigger should just be deleted as it does serve no purpose as it is.
Important note: When deleting it should be checked if that commented code is functionally needed as if so needs to be added elsewhere.
Note: If that is needed it should be reported as a separate related issue and fixed there. It should not stop the trigger deletion as it has been like this forever (a long time at least) |
| Steps To Reproduce | Check trigger body + hg history. |
| Proposed Solution | |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | |
| Attached Files | |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2014-08-23 16:01 | shuehner | New Issue | |
| 2014-08-23 16:01 | shuehner | Assigned To | => dmiguelez |
| 2014-08-23 16:01 | shuehner | Modules | => Core |
| 2014-08-23 16:01 | shuehner | Triggers an Emergency Pack | => No |
| 2014-08-23 16:01 | shuehner | Note Added: 0069640 | |
| 2014-09-03 14:10 | eduardo_Argal | Assigned To | dmiguelez => eduardo_Argal |
| 2015-07-13 13:26 | AtulOpenbravo | Assigned To | eduardo_Argal => AtulOpenbravo |
| 2015-07-13 13:26 | AtulOpenbravo | Status | new => scheduled |
| 2015-07-13 13:28 | AtulOpenbravo | Note Added: 0078774 | |
| 2015-07-13 13:29 | AtulOpenbravo | Note Edited: 0078774 | bug_revision_view_page.php?bugnote_id=0078774#r9003 |
| 2015-07-14 09:50 | hgbot | Checkin | |
| 2015-07-14 09:50 | hgbot | Note Added: 0078784 | |
| 2015-07-14 09:50 | hgbot | Status | scheduled => resolved |
| 2015-07-14 09:50 | hgbot | Resolution | open => fixed |
| 2015-07-14 09:50 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/ed5b74af3fa682bd2748163f83f89f6adb423071 [^] |
| 2015-07-14 09:51 | vmromanos | Review Assigned To | => vmromanos |
| 2015-07-14 09:51 | vmromanos | Note Added: 0078785 | |
| 2015-07-14 09:51 | vmromanos | Status | resolved => closed |
| 2015-07-16 12:04 | gorka_gil | Fixed in SCM revision | http://code.openbravo.com/erp/devel/pi/rev/ed5b74af3fa682bd2748163f83f89f6adb423071 [^] => http://code.openbravo.com/erp/devel/pi/rev/8d4487cdedc9 [^] |
| 2015-07-16 12:04 | gorka_gil | Note Edited: 0078784 | bug_revision_view_page.php?bugnote_id=0078784#r9052 |
| 2015-08-20 23:16 | hudsonbot | Checkin | |
| 2015-08-20 23:16 | hudsonbot | Note Added: 0079492 | |
|
Notes |
|
|
|
|
Found by 'Unreachable code' warning of oracle |
|
|
|
(0078774)
|
|
AtulOpenbravo
|
2015-07-13 13:28
(edited on: 2015-07-13 13:29) |
|
|
|
|
(0078784)
|
|
hgbot
|
2015-07-14 09:50
(edited on: 2015-07-16 12:04) |
|
Repository: erp/devel/pi
Changeset: 8d4487cdedc9
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Mon Jul 13 16:37:22 2015 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/8d4487cdedc9 [^]
Fixes Issue 27437: Trigger A_AMORTIZATIONLINE_TRG2 is useless and should be
deleted
Removed trigger A_AMORIZATIONLINE_TRG2. Code to update DepreciatedPlan is
implemented in A_AMORTIZATIONLINE_TRG so there is no harm in removing this
trigger.
---
R src-db/database/model/triggers/A_AMORTIZATIONLINE_TRG2.xml
---
|
|
|
|
|
|
|
|
|
|