Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0027436 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] A. Platform | major | have not tried | 2014-08-23 15:54 | 2014-12-30 23:26 | |||
| Reporter | shuehner | View Status | public | |||||
| Assigned To | NaroaIriarte | |||||||
| Priority | high | Resolution | fixed | Fixed in Version | 3.0PR15Q1 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | 0c39b04ae731 | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | AugustoMauch | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0027436: ad_treenode_mod_trg completely broken -> can edit without having modules in development | |||||||
| Description | This trigger is completely broken. As all its code is inside 'currentTree = 10' if clause but that variable is ever assigned any value. Note: That probably means that menu tree can be edited (nodes moved around) without having any module in development which is why reported as 'important'. Note: hg blame seems to show that bug to be there forever. Note: found by checking 'Unreachable code' warnings of oracle. | |||||||
| Steps To Reproduce | Read trigger body. | |||||||
| Proposed Solution | Delete the trigger, as that functionality is now handled by the MenuTreeOperationManager class | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0069708) AugustoMauch (manager) 2014-08-25 13:47 |
At no point in the last few years has been possible to move nodes in the menu tree without having its module in development (easy to check the current behaviour un livebuilds). With the new (Q2) tree infrastructure this check is done using the MenuTreeOperationManagerClass, and before that it used to be checked in the isMenuItemInDev method in the WindowTreeChecks class. |
|
(0072235) hgbot (developer) 2014-12-02 13:04 |
Repository: erp/devel/pi Changeset: 0c39b04ae7314b006e33d55d38c94aee06ab435b Author: Naroa Iriarte <naroa.iriarte <at> openbravo.com> Date: Fri Nov 28 09:19:52 2014 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/0c39b04ae7314b006e33d55d38c94aee06ab435b [^] Fixed issue 27436: A broken trigger needs to be removed. There was a trigger called AD_TREENODE_MOD_TRG that was not working well. It was created to control if a module was in development or not and if it was not in development, it couldn't be possible to move it arround the nodes on the tree view in the "Menu" tree. This feature is handled by the MenuTreeOperationManager.class, and it works well. For fixing the issue the AD_TREENODE_MOG_TRG trigger has been removed from the database. --- R src-db/database/model/triggers/AD_TREENODE_MOD_TRG.xml --- |
|
(0072236) AugustoMauch (manager) 2014-12-02 13:05 |
Code reviewed and verified in pi@0c39b04ae731 |
|
(0073161) hudsonbot (developer) 2014-12-30 23:26 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/6525fe229e06 [^] Maturity status: Test |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2014-08-23 15:54 | shuehner | New Issue | |
| 2014-08-23 15:54 | shuehner | Assigned To | => AugustoMauch |
| 2014-08-23 15:54 | shuehner | Modules | => Core |
| 2014-08-23 15:54 | shuehner | Triggers an Emergency Pack | => No |
| 2014-08-25 13:47 | AugustoMauch | Note Added: 0069708 | |
| 2014-11-27 13:17 | AugustoMauch | Proposed Solution updated | |
| 2014-11-27 13:52 | AugustoMauch | Assigned To | AugustoMauch => NaroaIriarte |
| 2014-12-02 13:02 | AugustoMauch | Issue Monitored: AugustoMauch | |
| 2014-12-02 13:02 | AugustoMauch | Review Assigned To | => AugustoMauch |
| 2014-12-02 13:04 | hgbot | Checkin | |
| 2014-12-02 13:04 | hgbot | Note Added: 0072235 | |
| 2014-12-02 13:04 | hgbot | Status | new => resolved |
| 2014-12-02 13:04 | hgbot | Resolution | open => fixed |
| 2014-12-02 13:04 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/0c39b04ae7314b006e33d55d38c94aee06ab435b [^] |
| 2014-12-02 13:05 | AugustoMauch | Note Added: 0072236 | |
| 2014-12-02 13:05 | AugustoMauch | Status | resolved => closed |
| 2014-12-02 13:05 | AugustoMauch | Fixed in Version | => 3.0PR15Q1 |
| 2014-12-30 23:26 | hudsonbot | Checkin | |
| 2014-12-30 23:26 | hudsonbot | Note Added: 0073161 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |