Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0027436Openbravo ERPA. Platformpublic2014-08-23 15:542014-12-30 23:26
Reportershuehner 
Assigned ToNaroaIriarte 
PriorityhighSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR15Q1 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0027436: ad_treenode_mod_trg completely broken -> can edit without having modules in development
DescriptionThis trigger is completely broken.

As all its code is inside 'currentTree = 10' if clause but that variable is ever assigned any value.

Note: That probably means that menu tree can be edited (nodes moved around) without having any module in development which is why reported as 'important'.

Note: hg blame seems to show that bug to be there forever.

Note: found by checking 'Unreachable code' warnings of oracle.
Steps To ReproduceRead trigger body.

Proposed SolutionDelete the trigger, as that functionality is now handled by the MenuTreeOperationManager class
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2014-08-23 15:54shuehnerNew Issue
2014-08-23 15:54shuehnerAssigned To => AugustoMauch
2014-08-23 15:54shuehnerOBNetwork customer => No
2014-08-23 15:54shuehnerModules => Core
2014-08-23 15:54shuehnerTriggers an Emergency Pack => No
2014-08-25 13:47AugustoMauchNote Added: 0069708
2014-11-27 13:17AugustoMauchProposed Solution updated
2014-11-27 13:52AugustoMauchAssigned ToAugustoMauch => NaroaIriarte
2014-12-02 13:02AugustoMauchIssue Monitored: AugustoMauch
2014-12-02 13:02AugustoMauchReview Assigned To => AugustoMauch
2014-12-02 13:04hgbotCheckin
2014-12-02 13:04hgbotNote Added: 0072235
2014-12-02 13:04hgbotStatusnew => resolved
2014-12-02 13:04hgbotResolutionopen => fixed
2014-12-02 13:04hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/0c39b04ae7314b006e33d55d38c94aee06ab435b [^]
2014-12-02 13:05AugustoMauchNote Added: 0072236
2014-12-02 13:05AugustoMauchStatusresolved => closed
2014-12-02 13:05AugustoMauchFixed in Version => 3.0PR15Q1
2014-12-30 23:26hudsonbotCheckin
2014-12-30 23:26hudsonbotNote Added: 0073161

Notes
(0069708)
AugustoMauch   
2014-08-25 13:47   
At no point in the last few years has been possible to move nodes in the menu tree without having its module in development (easy to check the current behaviour un livebuilds). With the new (Q2) tree infrastructure this check is done using the MenuTreeOperationManagerClass, and before that it used to be checked in the isMenuItemInDev method in the WindowTreeChecks class.
(0072235)
hgbot   
2014-12-02 13:04   
Repository: erp/devel/pi
Changeset: 0c39b04ae7314b006e33d55d38c94aee06ab435b
Author: Naroa Iriarte <naroa.iriarte <at> openbravo.com>
Date: Fri Nov 28 09:19:52 2014 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/0c39b04ae7314b006e33d55d38c94aee06ab435b [^]

Fixed issue 27436: A broken trigger needs to be removed.

There was a trigger called AD_TREENODE_MOD_TRG that was not working well. It was created to control if a module was in development or not
and if it was not in development, it couldn't be possible to move it arround the nodes on the tree view in the "Menu" tree.
This feature is handled by the MenuTreeOperationManager.class, and it works well.

For fixing the issue the AD_TREENODE_MOG_TRG trigger has been removed from the database.

---
R src-db/database/model/triggers/AD_TREENODE_MOD_TRG.xml
---
(0072236)
AugustoMauch   
2014-12-02 13:05   
Code reviewed and verified in pi@0c39b04ae731
(0073161)
hudsonbot   
2014-12-30 23:26   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/6525fe229e06 [^]
Maturity status: Test