Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0027433
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 08. Project and service managementtrivialhave not tried2014-08-23 13:472014-10-16 10:36
ReportershuehnerView Statuspublic 
Assigned Toshuehner 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision43554c8adcf5
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Toeduardo_Argal
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0027433: Trigger S_RESOURCEASSIGNEMENT_TRG has no content and should be deleted.

DescriptionThis trigger file
src-db/database/triggers/S_RESOURCEASSIGNMENT_TRG.xml has not useful content as all code besides the check AD_isTriggerEnabled is commented out.

Checking hg history
 hg blame src-db/database/model/triggers/S_RESOURCEASSIGNMENT_TRG.xml

Points to commit id 94 for modifying most of the code.
However commit 94 is just moving around files (creating src-db folder)

Re-doing blame with base -r 93 and changed filename:
hg blame -r 93 database/model/triggers/S_RESOURCEASSIGNMENT_TRG.xml

Shows that all that body is commented out since revision 0. So a long time ago.
Steps To ReproduceSee description:
- check body of that trigger to see its completely useless right now
- see hg history to verify that it has been like that a long time (2007)
Proposed SolutionJust delete the whole trigger.
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0070804)
hgbot (developer)
2014-10-08 12:44

Repository: erp/devel/pi
Changeset: 43554c8adcf556356777f7b00d50fdba5c5ee233
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Tue Oct 07 18:21:15 2014 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/43554c8adcf556356777f7b00d50fdba5c5ee233 [^]

Fixed 27433. Delete trigger without content: S_RESOURCEASSIGNMENT_TRG
This trigger has all of its useful body commented out.
Checking hg history shows that to be the case since revision 0.

---
R src-db/database/model/triggers/S_RESOURCEASSIGNMENT_TRG.xml
---
(0070984)
eduardo_Argal (developer)
2014-10-16 10:36

Reviewed and closed

- Issue History
Date Modified Username Field Change
2014-08-23 13:47 shuehner New Issue
2014-08-23 13:47 shuehner Assigned To => dmiguelez
2014-08-23 13:47 shuehner Modules => Core
2014-08-23 13:47 shuehner Triggers an Emergency Pack => No
2014-09-03 13:57 eduardo_Argal Assigned To dmiguelez => shuehner
2014-10-07 18:21 shuehner Review Assigned To => eduardo_Argal
2014-10-08 12:44 hgbot Checkin
2014-10-08 12:44 hgbot Note Added: 0070804
2014-10-08 12:44 hgbot Status new => resolved
2014-10-08 12:44 hgbot Resolution open => fixed
2014-10-08 12:44 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/43554c8adcf556356777f7b00d50fdba5c5ee233 [^]
2014-10-16 10:36 eduardo_Argal Note Added: 0070984
2014-10-16 10:36 eduardo_Argal Status resolved => closed


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker