Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0027433Openbravo ERP08. Project and service managementpublic2014-08-23 13:472014-10-16 10:36
Reportershuehner 
Assigned Toshuehner 
PrioritynormalSeveritytrivialReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Toeduardo_Argal
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0027433: Trigger S_RESOURCEASSIGNEMENT_TRG has no content and should be deleted.
DescriptionThis trigger file
src-db/database/triggers/S_RESOURCEASSIGNMENT_TRG.xml has not useful content as all code besides the check AD_isTriggerEnabled is commented out.

Checking hg history
 hg blame src-db/database/model/triggers/S_RESOURCEASSIGNMENT_TRG.xml

Points to commit id 94 for modifying most of the code.
However commit 94 is just moving around files (creating src-db folder)

Re-doing blame with base -r 93 and changed filename:
hg blame -r 93 database/model/triggers/S_RESOURCEASSIGNMENT_TRG.xml

Shows that all that body is commented out since revision 0. So a long time ago.
Steps To ReproduceSee description:
- check body of that trigger to see its completely useless right now
- see hg history to verify that it has been like that a long time (2007)
Proposed SolutionJust delete the whole trigger.
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2014-08-23 13:47shuehnerNew Issue
2014-08-23 13:47shuehnerAssigned To => dmiguelez
2014-08-23 13:47shuehnerOBNetwork customer => No
2014-08-23 13:47shuehnerModules => Core
2014-08-23 13:47shuehnerTriggers an Emergency Pack => No
2014-09-03 13:57eduardo_ArgalAssigned Todmiguelez => shuehner
2014-10-07 18:21shuehnerReview Assigned To => eduardo_Argal
2014-10-08 12:44hgbotCheckin
2014-10-08 12:44hgbotNote Added: 0070804
2014-10-08 12:44hgbotStatusnew => resolved
2014-10-08 12:44hgbotResolutionopen => fixed
2014-10-08 12:44hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/43554c8adcf556356777f7b00d50fdba5c5ee233 [^]
2014-10-16 10:36eduardo_ArgalNote Added: 0070984
2014-10-16 10:36eduardo_ArgalStatusresolved => closed

Notes
(0070804)
hgbot   
2014-10-08 12:44   
Repository: erp/devel/pi
Changeset: 43554c8adcf556356777f7b00d50fdba5c5ee233
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Tue Oct 07 18:21:15 2014 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/43554c8adcf556356777f7b00d50fdba5c5ee233 [^]

Fixed 27433. Delete trigger without content: S_RESOURCEASSIGNMENT_TRG
This trigger has all of its useful body commented out.
Checking hg history shows that to be the case since revision 0.

---
R src-db/database/model/triggers/S_RESOURCEASSIGNMENT_TRG.xml
---
(0070984)
eduardo_Argal   
2014-10-16 10:36   
Reviewed and closed