0027415: Stabilization: alert("") should never be used

diff --git a/src-db/database/model/modifiedTables/AD_ORG.xml b/src-db/database/model/modifiedTables/AD_ORG.xml
--- a/src-db/database/model/modifiedTables/AD_ORG.xml
+++ b/src-db/database/model/modifiedTables/AD_ORG.xml
@@ -57,6 +57,9 @@
       <foreign-key foreignTable="OBPOS_PRINT_TEMPLATE" name="EM_OBPOS_ORG_LAYAWAYTEMP">
         <reference local="EM_OBPOS_LAYAWAY_TEMPLATE_ID" foreign="OBPOS_PRINT_TEMPLATE_ID"/>
       </foreign-key>
+      <foreign-key foreignTable="OBPOS_PRINT_TEMPLATE" name="EM_OBPOS_ORG_QUOTTEMP">
+        <reference local="EM_OBPOS_QUOT_TEMPLATE_ID" foreign="OBPOS_PRINT_TEMPLATE_ID"/>
+      </foreign-key>
       <foreign-key foreignTable="OBPOS_PRINT_TEMPLATE" name="EM_OBPOS_ORG_RETINVTEMP">
         <reference local="EM_OBPOS_RET_INV_TEMPLATE_ID" foreign="OBPOS_PRINT_TEMPLATE_ID"/>
       </foreign-key>
@@ -66,9 +69,6 @@
       <foreign-key foreignTable="OBPOS_PRINT_TEMPLATE" name="EM_OBPOS_ORG_TICKETTEMP">
         <reference local="EM_OBPOS_TICKET_TEMPLATE_ID" foreign="OBPOS_PRINT_TEMPLATE_ID"/>
       </foreign-key>
-      <foreign-key foreignTable="OBPOS_PRINT_TEMPLATE" name="EM_OBPOS_ORG_QUOTTEMP">
-        <reference local="EM_OBPOS_QUOT_TEMPLATE_ID" foreign="OBPOS_PRINT_TEMPLATE_ID"/>
-      </foreign-key>
       <check name="EM_OBPOS_ORG_FORMAT"><![CDATA[((EM_OBPOS_FORMAT_DECIMAL IS NULL) AND (EM_OBPOS_FORMAT_GROUP IS NULL)) OR ((EM_OBPOS_FORMAT_DECIMAL IS NOT NULL) AND (EM_OBPOS_FORMAT_GROUP IS NOT NULL))]]></check>
     </table>
   </database>
diff --git a/src-db/database/sourcedata/AD_MESSAGE.xml b/src-db/database/sourcedata/AD_MESSAGE.xml
--- a/src-db/database/sourcedata/AD_MESSAGE.xml
+++ b/src-db/database/sourcedata/AD_MESSAGE.xml
@@ -282,7 +282,7 @@
 <!--0FA21BFB69CC4ACE9140703D4AC9611E-->  <AD_ORG_ID><![CDATA[0]]></AD_ORG_ID>
 <!--0FA21BFB69CC4ACE9140703D4AC9611E-->  <ISACTIVE><![CDATA[Y]]></ISACTIVE>
 <!--0FA21BFB69CC4ACE9140703D4AC9611E-->  <VALUE><![CDATA[OBPOS_MsgPaymentAmountError]]></VALUE>
-<!--0FA21BFB69CC4ACE9140703D4AC9611E-->  <MSGTEXT><![CDATA[Payment amount not valid.\nContact your administrator.]]></MSGTEXT>
+<!--0FA21BFB69CC4ACE9140703D4AC9611E-->  <MSGTEXT><![CDATA[Payment amount not valid. Contact your administrator.]]></MSGTEXT>
 <!--0FA21BFB69CC4ACE9140703D4AC9611E-->  <MSGTYPE><![CDATA[I]]></MSGTYPE>
 <!--0FA21BFB69CC4ACE9140703D4AC9611E-->  <AD_MODULE_ID><![CDATA[FF808181326CC34901326D53DBCF0018]]></AD_MODULE_ID>
 <!--0FA21BFB69CC4ACE9140703D4AC9611E-->  <ISINCLUDEINI18N><![CDATA[N]]></ISINCLUDEINI18N>
diff --git a/web/org.openbravo.retail.posterminal/js/model/order.js b/web/org.openbravo.retail.posterminal/js/model/order.js
--- a/web/org.openbravo.retail.posterminal/js/model/order.js
+++ b/web/org.openbravo.retail.posterminal/js/model/order.js
@@ -792,9 +792,9 @@
       if (p.get('obposScale')) {
         OB.POS.hwserver.getWeight(function (data) {
           if (data.exception) {
-            alert(data.exception.message);
+        	OB.UTIL.showConfirmation.display('', data.exception.message);
           } else if (data.result === 0) {
-            alert(OB.I18N.getLabel('OBPOS_WeightZero'));
+        	OB.UTIL.showConfirmation.display('', OB.I18N.getLabel('OBPOS_WeightZero'));
           } else {
             line = me.createLine(p, data.result, options, attrs);
           }
@@ -1461,7 +1461,7 @@
     },
 
     rejectQuotation: function () {
-      alert('reject!!');
+      OB.UTIL.showWarning('reject!!');
     },
 
     resetOrderInvoice: function () {
@@ -1562,7 +1562,7 @@
       var i, max, p, order;
 
       if (!OB.DEC.isNumber(payment.get('amount'))) {
-        alert(OB.I18N.getLabel('OBPOS_MsgPaymentAmountError'));
+        OB.UTIL.showWarning(OB.I18N.getLabel('OBPOS_MsgPaymentAmountError'));
         return;
       }
 
@@ -2552,7 +2552,7 @@
       var i, max, p, order;
 
       if (!OB.DEC.isNumber(payment.get('amount'))) {
-        alert(OB.I18N.getLabel('OBPOS_MsgPaymentAmountError'));
+        OB.UTIL.showWarning(OB.I18N.getLabel('OBPOS_MsgPaymentAmountError'));
         return;
       }
 

diff --git a/src-db/database/sourcedata/AD_MESSAGE.xml b/src-db/database/sourcedata/AD_MESSAGE.xml
--- a/src-db/database/sourcedata/AD_MESSAGE.xml
+++ b/src-db/database/sourcedata/AD_MESSAGE.xml
@@ -84,6 +84,19 @@
 <!--0BA24B8217B04C7DBCCFE0DEAF498679-->  <ISINCLUDEINI18N><![CDATA[N]]></ISINCLUDEINI18N>
 <!--0BA24B8217B04C7DBCCFE0DEAF498679--></AD_MESSAGE>
 
+<!--0D7FDBB45051473A8245CB21A6039F38--><AD_MESSAGE>
+<!--0D7FDBB45051473A8245CB21A6039F38-->  <AD_MESSAGE_ID><![CDATA[0D7FDBB45051473A8245CB21A6039F38]]></AD_MESSAGE_ID>
+<!--0D7FDBB45051473A8245CB21A6039F38-->  <AD_CLIENT_ID><![CDATA[0]]></AD_CLIENT_ID>
+<!--0D7FDBB45051473A8245CB21A6039F38-->  <AD_ORG_ID><![CDATA[0]]></AD_ORG_ID>
+<!--0D7FDBB45051473A8245CB21A6039F38-->  <ISACTIVE><![CDATA[Y]]></ISACTIVE>
+<!--0D7FDBB45051473A8245CB21A6039F38-->  <VALUE><![CDATA[OBMOBC_NotTerminalOrNotUser]]></VALUE>
+<!--0D7FDBB45051473A8245CB21A6039F38-->  <MSGTEXT><![CDATA[There are no users for the %0 terminal or the terminal does not exist.
+Please contact the system administrator.]]></MSGTEXT>
+<!--0D7FDBB45051473A8245CB21A6039F38-->  <MSGTYPE><![CDATA[I]]></MSGTYPE>
+<!--0D7FDBB45051473A8245CB21A6039F38-->  <AD_MODULE_ID><![CDATA[08943B85ADF64E708797A753E5B6AAEE]]></AD_MODULE_ID>
+<!--0D7FDBB45051473A8245CB21A6039F38-->  <ISINCLUDEINI18N><![CDATA[N]]></ISINCLUDEINI18N>
+<!--0D7FDBB45051473A8245CB21A6039F38--></AD_MESSAGE>
+
 <!--0EE7DA62B0AE4F3CA99837B1CD8FD1F7--><AD_MESSAGE>
 <!--0EE7DA62B0AE4F3CA99837B1CD8FD1F7-->  <AD_MESSAGE_ID><![CDATA[0EE7DA62B0AE4F3CA99837B1CD8FD1F7]]></AD_MESSAGE_ID>
 <!--0EE7DA62B0AE4F3CA99837B1CD8FD1F7-->  <AD_CLIENT_ID><![CDATA[0]]></AD_CLIENT_ID>
@@ -888,6 +901,18 @@
 <!--C4BC9A9586804E1DB5F6F373102A45BB-->  <ISINCLUDEINI18N><![CDATA[N]]></ISINCLUDEINI18N>
 <!--C4BC9A9586804E1DB5F6F373102A45BB--></AD_MESSAGE>
 
+<!--C4E1B578B13840ADA3BC8092798E743A--><AD_MESSAGE>
+<!--C4E1B578B13840ADA3BC8092798E743A-->  <AD_MESSAGE_ID><![CDATA[C4E1B578B13840ADA3BC8092798E743A]]></AD_MESSAGE_ID>
+<!--C4E1B578B13840ADA3BC8092798E743A-->  <AD_CLIENT_ID><![CDATA[0]]></AD_CLIENT_ID>
+<!--C4E1B578B13840ADA3BC8092798E743A-->  <AD_ORG_ID><![CDATA[0]]></AD_ORG_ID>
+<!--C4E1B578B13840ADA3BC8092798E743A-->  <ISACTIVE><![CDATA[Y]]></ISACTIVE>
+<!--C4E1B578B13840ADA3BC8092798E743A-->  <VALUE><![CDATA[OBMOBC_InvalidUserPassword]]></VALUE>
+<!--C4E1B578B13840ADA3BC8092798E743A-->  <MSGTEXT><![CDATA[Invalid user name or password. Please try again.]]></MSGTEXT>
+<!--C4E1B578B13840ADA3BC8092798E743A-->  <MSGTYPE><![CDATA[I]]></MSGTYPE>
+<!--C4E1B578B13840ADA3BC8092798E743A-->  <AD_MODULE_ID><![CDATA[08943B85ADF64E708797A753E5B6AAEE]]></AD_MODULE_ID>
+<!--C4E1B578B13840ADA3BC8092798E743A-->  <ISINCLUDEINI18N><![CDATA[N]]></ISINCLUDEINI18N>
+<!--C4E1B578B13840ADA3BC8092798E743A--></AD_MESSAGE>
+
 <!--C88B6F2C58B3477BAEA816BF54559E50--><AD_MESSAGE>
 <!--C88B6F2C58B3477BAEA816BF54559E50-->  <AD_MESSAGE_ID><![CDATA[C88B6F2C58B3477BAEA816BF54559E50]]></AD_MESSAGE_ID>
 <!--C88B6F2C58B3477BAEA816BF54559E50-->  <AD_CLIENT_ID><![CDATA[0]]></AD_CLIENT_ID>
@@ -1116,17 +1141,4 @@
 <!--FED607CB920046AEAD41C88670FDE09F-->  <ISINCLUDEINI18N><![CDATA[N]]></ISINCLUDEINI18N>
 <!--FED607CB920046AEAD41C88670FDE09F--></AD_MESSAGE>
 
-<!--0D7FDBB45051473A8245CB21A6039F38--><AD_MESSAGE>
-<!--0D7FDBB45051473A8245CB21A6039F38-->  <AD_MESSAGE_ID><![CDATA[0D7FDBB45051473A8245CB21A6039F38]]></AD_MESSAGE_ID>
-<!--0D7FDBB45051473A8245CB21A6039F38-->  <AD_CLIENT_ID><![CDATA[0]]></AD_CLIENT_ID>
-<!--0D7FDBB45051473A8245CB21A6039F38-->  <AD_ORG_ID><![CDATA[0]]></AD_ORG_ID>
-<!--0D7FDBB45051473A8245CB21A6039F38-->  <ISACTIVE><![CDATA[Y]]></ISACTIVE>
-<!--0D7FDBB45051473A8245CB21A6039F38-->  <VALUE><![CDATA[OBMOBC_NotTerminalOrNotUser]]></VALUE>
-<!--0D7FDBB45051473A8245CB21A6039F38-->  <MSGTEXT><![CDATA[There are no users for the %0 terminal or the terminal does not exist.
-Please contact the system administrator.]]></MSGTEXT>
-<!--0D7FDBB45051473A8245CB21A6039F38-->  <MSGTYPE><![CDATA[I]]></MSGTYPE>
-<!--0D7FDBB45051473A8245CB21A6039F38-->  <AD_MODULE_ID><![CDATA[08943B85ADF64E708797A753E5B6AAEE]]></AD_MODULE_ID>
-<!--0D7FDBB45051473A8245CB21A6039F38-->  <ISINCLUDEINI18N><![CDATA[N]]></ISINCLUDEINI18N>
-<!--0D7FDBB45051473A8245CB21A6039F38--></AD_MESSAGE>
-
 </data>
diff --git a/web/org.openbravo.mobile.core/source/component/ob-login.js b/web/org.openbravo.mobile.core/source/component/ob-login.js
--- a/web/org.openbravo.mobile.core/source/component/ob-login.js
+++ b/web/org.openbravo.mobile.core/source/component/ob-login.js
@@ -307,7 +307,7 @@
     var u = this.$.username.getValue(),
         p = this.$.password.getValue();
     if (!u || !p) {
-      alert('Please enter your username and password');
+      OB.UTIL.showWarning(OB.I18N.getLabel('OBMOBC_EmptyUserPassword'));
     } else {
       OB.MobileApp.model.login(u, p);
     }
@@ -364,7 +364,7 @@
     if (name.length === 0) {
       this.$.loginInputsContainer.hide();
       this.$.loginHeaderCompany.hide();
-      alert(OB.I18N.getLabel('OBMOBC_NotTerminalOrNotUser', [OB.MobileApp.model.get('terminalName')]));
+      OB.UTIL.showConfirmation.display('', OB.I18N.getLabel('OBMOBC_NotTerminalOrNotUser', [OB.MobileApp.model.get('terminalName')]));
     }
     for (i = 0; i < name.length; i++) {
       target.createComponent({
@@ -391,8 +391,8 @@
       if (data && data.messageText) {
         msg += (msg ? '\n' : '') + data.messageText;
       }
-      msg = msg || 'Invalid user name or password.\nPlease try again.';
-      alert(msg);
+      msg = msg || OB.I18N.getLabel('OBMOBC_InvalidUserPassword');
+      OB.UTIL.showConfirmation.display('', msg);
       if (this.$.password) {
         this.$.password.setValue('');
       }
diff --git a/web/org.openbravo.mobile.core/source/component/obpos-approval.js b/web/org.openbravo.mobile.core/source/component/obpos-approval.js
--- a/web/org.openbravo.mobile.core/source/component/obpos-approval.js
+++ b/web/org.openbravo.mobile.core/source/component/obpos-approval.js
@@ -209,11 +209,11 @@
         p = this.$.bodyContent.$.password.getValue();
 
     if (!u || !p) {
-      alert(OB.I18N.getLabel('OBMOBC_EmptyUserPassword'));
+      OB.UTIL.showWarning(OB.I18N.getLabel('OBMOBC_EmptyUserPassword'));
     } else {
       this.model.checkApproval(this.approvalType, u, p, this.callback);
-      this.waterfall('onHideThisPopup', {});
     }
+    this.waterfall('onHideThisPopup', {});
   }
 });
 
diff --git a/web/org.openbravo.mobile.core/source/model/ob-terminal-model.js b/web/org.openbravo.mobile.core/source/model/ob-terminal-model.js
--- a/web/org.openbravo.mobile.core/source/model/ob-terminal-model.js
+++ b/web/org.openbravo.mobile.core/source/model/ob-terminal-model.js
@@ -1001,8 +1001,11 @@
     }, function (users) {
       var user;
       if (users.models.length === 0) {
-        alert(OB.I18N.getLabel('OBMOBC_OfflinePasswordNotCorrect'));
-        window.location.reload();
+        OB.UTIL.showConfirmation.display('', OB.I18N.getLabel('OBMOBC_OfflinePasswordNotCorrect'), null, {
+          onHideFunction: function () {
+            window.location.reload();
+          }
+        });
       } else {
         if (users.models[0].get('password') === me.generate_sha1(me.password + users.models[0].get('created'))) {
           me.usermodel = users.models[0];
@@ -1010,8 +1013,11 @@
           me.updateSession(me.usermodel);
           me.renderTerminalMain();
         } else {
-          alert(OB.I18N.getLabel('OBMOBC_OfflinePasswordNotCorrect'));
-          window.location.reload();
+          OB.UTIL.showConfirmation.display('', OB.I18N.getLabel('OBMOBC_OfflinePasswordNotCorrect'), null, {
+            onHideFunction: function () {
+              window.location.reload();
+            }
+          });
         }
       }
     }, function () {});