0027415: Stabilization: alert("") should never be used

Openbravo Issue Tracking System - Retail Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0027415

Retail Modules

Web POS

public

2014-08-22 10:19

2015-03-06 16:57

Reporter

Orekaria

Assigned To

aaroncalero

Priority

normal

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

RR15Q2

Fixed in Version

RR15Q2

Merge Request Status

Review Assigned To

marvintm

OBNetwork customer

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0027415: Stabilization: alert("") should never be used

Description

It stops the javascript heap
The browser alert is not shown in the screenshots
The test logic to detect when one is present is almost a hack. Also, the tests cannot access the content of the alert
Is also not seen when in a hangout call

Steps To Reproduce

In the WebPOS login page
Try to login with wrong credentials

Verify that an alert is shown

Proposed Solution

in ob-login.js change this code:

    var params;
    OB.UTIL.showLoggingOut(false);
    OB.MobileApp.model.on('loginfail', function (status, data) {
      var msg;
      if (data && data.messageTitle) {
        msg = data.messageTitle;
      }

      if (data && data.messageText) {
        msg += (msg ? '\n' : '') + data.messageText;
      }
      msg = msg || 'Invalid user name or password.\nPlease try again.';
      alert(msg);
      if (this.$.password) {
        this.$.password.setValue('');
      }
      if (this.$.username) {
        this.$.username.focus();
      }
    }, this);

for this one:

OB.MobileApp.model.on('loginfail', function (status, data) {
      var me = this;
      var msgTittle = 'Error';
      var msgText = 'Invalid user name or password. Please try again.';
      if (data && data.messageTitle) {
        msgTittle = data.messageTitle;
      }
      if (data && data.messageText) {
        msgText = data.messageText;
      }
      OB.UTIL.showConfirmation.display(msgTittle, msgText, [{
        label: 'OK',
        isConfirmButton: true,
        action: function () {
          if (me.$.password) {
            me.$.password.setValue('');
          }
          OB.MobileApp.model.navigate('login');
        }
      }], {
        onHideFunction: function () {
          if (me.$.password) {
            me.$.password.setValue('');
          }
          OB.MobileApp.model.navigate('login');
        }
      });
    }, this);

Additional Information

Tags

No tags attached.

Relationships

has duplicate	design defect	0022172		closed	adrianromero	Information messages must be consolidated (javascript alerts)
has duplicate	design defect	0021087		closed	adrianromero	Different application messages formats
blocks	feature request	0027329		new	Retail	Stabilization: Overhaul the loading process (since the url is entered until the webpos has loaded)
blocks	feature request	0026771	RR14Q3	closed	Orekaria	TestCases. Work in progress
blocks	feature request	0028933	RR16Q1	closed	Retail	QA: RR15Q2: Add tests for Mobile applications