Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0027359
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajoralways2014-08-18 14:492014-10-01 18:59
ReporterjecharriView Statuspublic 
Assigned Tomtaal 
PriorityurgentResolutionfixedFixed in VersionRR14Q4
StatusclosedFix in branchpiFixed in SCM revision82b51249f7b8
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomarvintm
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0027359: Web POS is calculating the returns using the gross instead of qty

DescriptionWeb POS is calculating the returns using the gross instead of qty
Steps To ReproduceIn file org.openbraov.retail.posterminal.js.pointofsale.view.editline.js

line 437: if (this.line.get('gross') < OB.DEC.Zero) {
if (!_.isUndefined(this.line.get('returnReason'))) {
selectedReason = _.filter(this.$.returnreason.children, function (reason) {
return reason.getValue() === me.line.get('returnReason');
})[0];
this.$.returnreason.setSelected(selectedReason.getNodeProperty('index'));
}
this.$.returnreason.show();
} else {
this.$.returnreason.hide();
}


it should not use "gross" to tell which is return or not, it should use "qty" to tell
So, when we use the product which is negative price (like special service or discount) the return reason can not choose.
TagsNo tags attached.
Attached Filespng file icon a.return.png [^] (53,627 bytes) 2014-08-31 21:49


png file icon a.cahsup2of5 (with 100 deposit).png [^] (103,528 bytes) 2014-08-31 21:49


png file icon a.cashup5of5Return.png [^] (107,231 bytes) 2014-08-31 21:50


png file icon b.returnNegative.png [^] (53,332 bytes) 2014-08-31 21:50


png file icon b.cahsup2of5.png [^] (105,220 bytes) 2014-08-31 21:50


png file icon b.cashup5of5NegativeReturn.png [^] (103,173 bytes) 2014-08-31 21:51


png file icon Selection_030.png [^] (80,683 bytes) 2014-09-03 17:44


png file icon Selection_031.png [^] (78,956 bytes) 2014-09-03 17:44

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0026512RR14Q3 closedszapata amounts in return receipts are wrong calculated 

-  Notes
(0069517)
hgbot (developer)
2014-08-19 15:30

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 82b51249f7b8fe9e977d57805a43ef432094badb
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Tue Aug 19 15:30:21 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/82b51249f7b8fe9e977d57805a43ef432094badb [^]

Fixes issue 27359: Web POS is calculating the returns using the gross instead of qty
Use qty instead of the amount (gross) to check if something is a return

---
M web/org.openbravo.retail.posterminal/js/data/dataordersave.js
M web/org.openbravo.retail.posterminal/js/model/order.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/editline.js
M web/org.openbravo.retail.posterminal/res/printreceipt.xml
---
(0069586)
hgbot (developer)
2014-08-21 22:43

 Repository: tools/automation/pi-mobile
Changeset: 6db590b4b6ce46c109221083c41875d96500b3be
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Thu Aug 21 22:43:23 2014 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/6db590b4b6ce46c109221083c41875d96500b3be [^]

Fixed CashupWithSaleAndReturn with the new values after the fix for issue 27359

---
M src-test/org/openbravo/retail/integrationtest/tests/general/cashup/CashupWithSaleAndReturn.java
---
(0069587)
hgbot (developer)
2014-08-21 22:58

 Repository: tools/automation/pi-mobile
Changeset: 6c3d1b3441c2cf25b3a9b1cd4d4692b0a52cb976
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Thu Aug 21 22:58:32 2014 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/6c3d1b3441c2cf25b3a9b1cd4d4692b0a52cb976 [^]

Fixed I26806_CashupTotalNotShown with the new values after the fix for issue 27359

---
M src-test/org/openbravo/retail/integrationtest/tests/issues/I26806_CashupTotalNotShown.java
---
(0069863)
Orekaria (administrator)
2014-08-31 21:49
edited on: 2014-08-31 21:52

 The cashup is not correctly calculated.

See attached screenshots.

The cashup with the regular return has a deposit made of 100€ because is necessary to have any cash to finish the return.

- Step 2 of 3 does show the amount inverted because expected amount is negative (should be possitive)

- Total withdrawals does show the amount inverted
(0070543)
migueldejuana (developer)
2014-09-30 11:41

 The fix is ok but one file was wrongly changed. This error is fixed in the issue:
https://issues.openbravo.com/view.php?id=26512 [^]
(0070628)
marvintm (manager)
2014-10-01 18:59

 The change in the initial commit in dataordersave is wrong. However, it has been fixed afterwards by a subsequent commit (https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e40925774f15 [^]). So now the code is finally correct.

- Issue History
Date Modified Username Field Change
2014-08-18 14:49 jecharri New Issue
2014-08-18 14:49 jecharri Assigned To => marvintm
2014-08-18 14:49 jecharri Resolution time => 1411077600
2014-08-18 14:49 jecharri Triggers an Emergency Pack => No
2014-08-19 15:30 hgbot Checkin
2014-08-19 15:30 hgbot Note Added: 0069517
2014-08-19 15:30 hgbot Status new => resolved
2014-08-19 15:30 hgbot Resolution open => fixed
2014-08-19 15:30 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/82b51249f7b8fe9e977d57805a43ef432094badb [^]
2014-08-21 22:43 hgbot Checkin
2014-08-21 22:43 hgbot Note Added: 0069586
2014-08-21 22:58 hgbot Checkin
2014-08-21 22:58 hgbot Note Added: 0069587
2014-08-31 21:49 Orekaria Assigned To marvintm => mtaal
2014-08-31 21:49 Orekaria Note Added: 0069863
2014-08-31 21:49 Orekaria Status resolved => new
2014-08-31 21:49 Orekaria Resolution fixed => open
2014-08-31 21:49 Orekaria File Added: a.return.png
2014-08-31 21:49 Orekaria File Added: a.cahsup2of5 (with 100 deposit).png
2014-08-31 21:50 Orekaria File Added: a.cashup5of5Return.png
2014-08-31 21:50 Orekaria File Added: b.returnNegative.png
2014-08-31 21:50 Orekaria File Added: b.cahsup2of5.png
2014-08-31 21:51 Orekaria File Added: b.cashup5of5NegativeReturn.png
2014-08-31 21:52 Orekaria Note Edited: 0069863 View Revisions
2014-09-03 17:44 mtaal File Added: Selection_030.png
2014-09-03 17:44 mtaal File Added: Selection_031.png
2014-09-27 01:11 mtaal Relationship added related to 0026512
2014-09-30 11:37 migueldejuana Status new => scheduled
2014-09-30 11:37 migueldejuana fix_in_branch => pi
2014-09-30 11:41 migueldejuana Note Added: 0070543
2014-09-30 11:41 migueldejuana Status scheduled => resolved
2014-09-30 11:41 migueldejuana Fixed in Version => RR14Q4
2014-09-30 11:41 migueldejuana Resolution open => fixed
2014-10-01 18:59 marvintm Review Assigned To => marvintm
2014-10-01 18:59 marvintm Note Added: 0070628
2014-10-01 18:59 marvintm Status resolved => closed

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker