Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0027282
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformmajoralways2014-08-06 10:392014-09-09 12:57
ReportervmromanosView Statuspublic 
Assigned ToAugustoMauch 
PriorityurgentResolutionfixedFixed in Version3.0PR14Q4
StatusclosedFix in branchFixed in SCM revision5e4ddc5f2219
ProjectionnoneETAnoneTarget Version
OSLinux 32 bitDatabasePostgreSQLJava version1.6.0_12
OS VersionDebian 5.0Database version8.3.8Ant version1.7.0
Product VersionpiSCM revision 
Review Assigned Toalostale
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0027282: package-info file is not compiled from the Module Management

DescriptionThe SEPA Credit Transfer and Direct Debit modules provide several package-info.java [1] files to declare some package level annotations that are used at runtime to populate the namespace of the generated XML files.

We have detected that these files are NOT compiled only when the compilation process is done through the Module Management window. However, if we manually compile from the command line running "ant smartbuild -Dlocal=no", the files are properly compiled and their .class files deployed to Tomcat.

If these files are not compiled, the generated XML file won't have the right namespace, so the banks reject the files.


[1] Example: https://code.openbravo.com/erp/pmods/org.openbravo.sepa.iso20022.credittransfer.customertobank/file/3c9a690b4004/src/org/openbravo/sepa/iso20022/credittransfer/customertobank/pain/x001/x001/x03/package-info.java [^]
Steps To Reproduce1. Login as System Administrator
2. Activate the instance
3. Go to the Module Management window.
4. Ensure you accept modules in QAA status
5. Search SEPA
6. Install the SEPA Credit Transfer Customer-to-Bank module
7. Rebuild the system from the Module Management window
8. Go to the command line and run:
find $CATALINA_BASE/webapps/openbravo -name package-info.class
9. Realize no files are found. WRONG: it should find 2 files
10. Run:
ant smartbuild
11. Run again:
find $CATALINA_BASE/webapps/openbravo -name package-info.class
12. Realize 2 files are found
Proposed SolutionI have found that there are some general issues with the compilation of this kind of files using ant that may be related (or not) with this bug:
1. http://stackoverflow.com/questions/4877097/jaxb-2-x-and-ant [^]
2. http://ant.apache.org/manual/Tasks/javac.html [^] (see "Note on package-info.java" at the end)

According to the links, the package-info.java files are only compiled when it contains runtime annotations (as in the SEPA package-info.java files) and depending on the timestamp of the directory that will contain the .class file.

Note: My ant version is 1.8.2


As far as I have checked, both requirements are fulfilled here, so the .class file should be generated; so I think in this particular case, the problem should be located in the way the compilation is done into the Module Management console.
TagsNo tags attached.
Attached Files? file icon issue27282.export [^] (2,413,212 bytes) 2014-09-04 16:05

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to backport 00384993.0PR18Q2 closedalostale raise minimum required ant 
related to feature request 0038500 closedalostale raise minimum required ant 

-  Notes
(0069966)
AugustoMauch (manager)
2014-09-04 16:05

 Fix pushed to try, also attached to this issue.
(0069976)
hgbot (developer)
2014-09-05 09:52

 Repository: erp/devel/pi
Changeset: 5e4ddc5f221920b5091883da9859c0cdbebde4de
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Thu Sep 04 16:03:57 2014 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/5e4ddc5f221920b5091883da9859c0cdbebde4de [^]

Fixes issue 27282: package-info file is not compiled from the Module Management

The problem was a but in the ant versions prior to 1.8 (see [1]). To fix this, the ant library included in lib/runtime has been upgraded to 1.9.2., along with the ant-apache-log4j and ant-launcher libraries.

[1] http://ant.apache.org/manual/Tasks/javac.html [^]

---
M build.xml
M src-core/.classpath
M src-wad/.classpath
A lib/runtime/ant-1.9.2.jar
A lib/runtime/ant-apache-log4j-1.9.2.jar
A lib/runtime/ant-launcher-1.9.2.jar
R lib/runtime/ant-1.7.1.jar
R lib/runtime/ant-apache-log4j.jar
R lib/runtime/ant-launcher.jar
---
(0069989)
hudsonbot (developer)
2014-09-06 03:15

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9d3377dd39d4 [^]
Maturity status: Test
(0070004)
hgbot (developer)
2014-09-08 10:04

 Repository: erp/devel/pi
Changeset: ae09ff1bb7568d63e1acc94175617933ce685bbb
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Mon Sep 08 10:04:27 2014 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/ae09ff1bb7568d63e1acc94175617933ce685bbb [^]

Related with issue 27282: Updates Licensing.txt

Updates LIcensing.txt to keep it up to date with the changes in lib/runtime

---
M legal/Licensing.txt
---
(0070024)
hudsonbot (developer)
2014-09-08 17:52

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/e8e54dd5de31 [^]
Maturity status: Test
(0070050)
alostale (manager)
2014-09-09 12:57

 tested from ui and command line in both cases .class files are generated

- Issue History
Date Modified Username Field Change
2014-08-06 10:39 vmromanos New Issue
2014-08-06 10:39 vmromanos Assigned To => AugustoMauch
2014-08-06 10:39 vmromanos Modules => Core
2014-08-06 10:39 vmromanos Triggers an Emergency Pack => No
2014-08-06 10:52 ngarcia Resolution time => 1408831200
2014-08-06 10:56 ngarcia Issue Monitored: ngarcia
2014-09-04 16:05 AugustoMauch Note Added: 0069966
2014-09-04 16:05 AugustoMauch File Added: issue27282.export
2014-09-05 09:50 AugustoMauch Issue Monitored: alostale
2014-09-05 09:50 AugustoMauch Review Assigned To => alostale
2014-09-05 09:52 hgbot Checkin
2014-09-05 09:52 hgbot Note Added: 0069976
2014-09-05 09:52 hgbot Status new => resolved
2014-09-05 09:52 hgbot Resolution open => fixed
2014-09-05 09:52 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/5e4ddc5f221920b5091883da9859c0cdbebde4de [^]
2014-09-06 03:15 hudsonbot Checkin
2014-09-06 03:15 hudsonbot Note Added: 0069989
2014-09-08 10:04 hgbot Checkin
2014-09-08 10:04 hgbot Note Added: 0070004
2014-09-08 17:52 hudsonbot Checkin
2014-09-08 17:52 hudsonbot Note Added: 0070024
2014-09-09 12:57 alostale Note Added: 0070050
2014-09-09 12:57 alostale Status resolved => closed
2014-09-09 12:57 alostale Fixed in Version => 3.0PR14Q4
2018-05-08 08:50 alostale Relationship added related to 0038499
2018-05-08 09:00 alostale Relationship added related to 0038500

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker