Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0027202
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminoralways2014-07-25 13:072014-08-08 18:54
ReporterVictorVillarView Statuspublic 
Assigned ToAugustoMauch 
PriorityhighResolutionfixedFixed in Version3.0PR14Q4
StatusclosedFix in branchFixed in SCM revisionb4c15099de6b
ProjectionnoneETAnoneTarget Version3.0PR14Q4
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionpiSCM revision 
Review Assigned Todbaz
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0027202: Tab title is not taking into account the Openbravo.Properties date time format

DescriptionTab title is not taking into account the Openbravo.Properties date time format
Steps To ReproduceEither install the Resource and Reservations Management module or just create Absolute DateTime or Absolute Time fields as part of the identifier.

Openbravo Properties as follow:

dateFormat.js=%m-%d-%Y
dateFormat.sql=MM-DD-YYYY
dateFormat.java=MM/dd/yyyy
dateTimeFormat.java=MM/dd/yyyy hh:mm a
dateTimeFormat.sql=MM-DD-YYYY HH24:MI:SS


Check the Visits Management window and please have a look at the screenshot attached.
TagsNo tags attached.
Attached Filespng file icon identifier (1).png [^] (19,137 bytes) 2014-07-25 13:07


png file icon Config.png [^] (53,950 bytes) 2014-08-04 21:23


png file icon Result.png [^] (54,160 bytes) 2014-08-04 21:23

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0069063)
hgbot (developer)
2014-08-04 11:26

 Repository: erp/devel/pi
Changeset: 28068c12e140a0c14315287fe636327d305280e3
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Mon Aug 04 11:24:21 2014 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/28068c12e140a0c14315287fe636327d305280e3 [^]

Fixes issue 27202: AbsoluteDateTime properties are formatted in the identifier

The getIdentifier method of the IdentifierProvider class was only formatting the dates of the properties that used the Date or DateTime references. Now it also applies the proper date format for the properties that use the AbsoluteDateTime reference.

---
M src/org/openbravo/base/structure/IdentifierProvider.java
---
(0069064)
AugustoMauch (manager)
2014-08-04 11:28

 Quick Steps to Reproduce:
As System Admin:
- Open Tables and Columns
- Select the Order table
- Change the reference of the Updated column to Absolute Date Time
- Include this column in the identifier of the table

As F&B Admin:
- Open Sales Order and select a record. Check that the proper identifier is shown in the title.
(0069083)
dbaz (developer)
2014-08-04 21:23

 With the following configuration:

dateFormat.js=%d-%m-%Y
dateFormat.sql=DD-MM-YYYY
dateFormat.java=dd-MM-yyyy
dateTimeFormat.java=dd-MM-yyyy hh:mm:ss a
dateTimeFormat.sql=DD-MM-YYYY HH24:MI:SS

Install the following module:

https://code.openbravo.com/erp/mods/org.openbravo.platform.features/ [^]

As "System Administrator"
* Go to "Tables and Columns"
* Leave in "C_Order" table the "Used as Record Indenfifier" and its associated "Sequence Number" as shown in attached [Config.png]

Do ant.smartbuild

As "Openbravo Admin"
* Go to "Sales Order"
* Create a record with the values attached in [Result.png]

Notice that the shown text in the tab is:
"Sales Order - 2014-08-04 05:00:00.0 - 06-08-2014 12:00:00 AM - 1000108 - 2014-08-04 19:00:00.0 - 05-08-2014 08:00:00 PM"

and it should be:
"Sales Order - 5:00:00 AM - 06-08-2014 12:00:00 AM - 1000108 - 7:00:00 PM - 05-08-2014 08:00:00 PM"

So the tabs text should display exactly the same that is visualized in the form

It can be conclided that there is still a problem with the text of the Absolute Time (specified in the original issue) and with the Relative Time (not specified in the original issue) one.
(0069088)
hgbot (developer)
2014-08-05 12:38

 Repository: erp/devel/pi
Changeset: b4c15099de6b5946b8d52335e7920d06a7c12672
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Tue Aug 05 12:37:18 2014 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/b4c15099de6b5946b8d52335e7920d06a7c12672 [^]

Fixes issue 27202: Time properties are formatted in the identifier

The previous changeset only fixed the problem for AbsoluteDateTime properties. This new changeset also applies the proper format for the Time and AbsoluteTime properties.

---
M src/org/openbravo/base/model/Property.java
M src/org/openbravo/base/structure/IdentifierProvider.java
---
(0069091)
dbaz (developer)
2014-08-05 14:59

 The solution is not still perfect, because I see:
"Sales Order - 05:00:00 AM - 06-08-2014 12:00:00 AM - 1000108 - 07:00:00 PM - 05-08-2014 08:00:00 PM"

and I expect to see, as said before, the same than in the form, so:
"Sales Order - 5:00:00 AM - 06-08-2014 12:00:00 AM - 1000108 - 7:00:00 PM - 05-08-2014 08:00:00 PM"

Anyway, I think it could be good enough for the moment, so it can be closed.

Reviewed @ changeset 24214 - ca197a91d631
(0069258)
hudsonbot (developer)
2014-08-08 18:54

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/4450016dee64 [^]
Maturity status: Test
(0069265)
hudsonbot (developer)
2014-08-08 18:54

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/4450016dee64 [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2014-07-25 13:07 VictorVillar New Issue
2014-07-25 13:07 VictorVillar Assigned To => AugustoMauch
2014-07-25 13:07 VictorVillar File Added: identifier (1).png
2014-07-25 13:07 VictorVillar Modules => Core
2014-07-25 13:07 VictorVillar Resolution time => 1412632800
2014-07-25 13:07 VictorVillar Triggers an Emergency Pack => No
2014-07-25 13:07 VictorVillar Issue Monitored: networkb
2014-07-28 11:22 VictorVillar Steps to Reproduce Updated View Revisions
2014-08-04 11:19 AugustoMauch Issue Monitored: dbaz
2014-08-04 11:20 AugustoMauch Review Assigned To => dbaz
2014-08-04 11:26 hgbot Checkin
2014-08-04 11:26 hgbot Note Added: 0069063
2014-08-04 11:26 hgbot Status new => resolved
2014-08-04 11:26 hgbot Resolution open => fixed
2014-08-04 11:26 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/28068c12e140a0c14315287fe636327d305280e3 [^]
2014-08-04 11:28 AugustoMauch Note Added: 0069064
2014-08-04 21:08 dbaz Status resolved => new
2014-08-04 21:08 dbaz Resolution fixed => open
2014-08-04 21:23 dbaz Note Added: 0069083
2014-08-04 21:23 dbaz File Added: Config.png
2014-08-04 21:23 dbaz File Added: Result.png
2014-08-05 12:38 hgbot Checkin
2014-08-05 12:38 hgbot Note Added: 0069088
2014-08-05 12:38 hgbot Status new => resolved
2014-08-05 12:38 hgbot Resolution open => fixed
2014-08-05 12:38 hgbot Fixed in SCM revision http://code.openbravo.com/erp/devel/pi/rev/28068c12e140a0c14315287fe636327d305280e3 [^] => http://code.openbravo.com/erp/devel/pi/rev/b4c15099de6b5946b8d52335e7920d06a7c12672 [^]
2014-08-05 14:59 dbaz Note Added: 0069091
2014-08-05 14:59 dbaz Status resolved => closed
2014-08-05 14:59 dbaz Fixed in Version => 3.0PR14Q4
2014-08-08 18:54 hudsonbot Checkin
2014-08-08 18:54 hudsonbot Note Added: 0069258
2014-08-08 18:54 hudsonbot Checkin
2014-08-08 18:54 hudsonbot Note Added: 0069265

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker