Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0027202Openbravo ERPA. Platformpublic2014-07-25 13:072014-08-08 18:54
VictorVillar 
AugustoMauch 
highminoralways
closedfixed 
5
pi 
3.0PR14Q43.0PR14Q4 
dbaz
Core
No
0027202: Tab title is not taking into account the Openbravo.Properties date time format
Tab title is not taking into account the Openbravo.Properties date time format
Either install the Resource and Reservations Management module or just create Absolute DateTime or Absolute Time fields as part of the identifier.

Openbravo Properties as follow:

dateFormat.js=%m-%d-%Y
dateFormat.sql=MM-DD-YYYY
dateFormat.java=MM/dd/yyyy
dateTimeFormat.java=MM/dd/yyyy hh:mm a
dateTimeFormat.sql=MM-DD-YYYY HH24:MI:SS


Check the Visits Management window and please have a look at the screenshot attached.
No tags attached.
png identifier (1).png (19,137) 2014-07-25 13:07
https://issues.openbravo.com/file_download.php?file_id=7089&type=bug
png

png Config.png (53,950) 2014-08-04 21:23
https://issues.openbravo.com/file_download.php?file_id=7122&type=bug
png

png Result.png (54,160) 2014-08-04 21:23
https://issues.openbravo.com/file_download.php?file_id=7123&type=bug
png
Issue History
2014-07-25 13:07VictorVillarNew Issue
2014-07-25 13:07VictorVillarAssigned To => AugustoMauch
2014-07-25 13:07VictorVillarFile Added: identifier (1).png
2014-07-25 13:07VictorVillarModules => Core
2014-07-25 13:07VictorVillarResolution time => 1412632800
2014-07-25 13:07VictorVillarTriggers an Emergency Pack => No
2014-07-25 13:07VictorVillarIssue Monitored: networkb
2014-07-28 11:22VictorVillarSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=6189#r6189
2014-08-04 11:19AugustoMauchIssue Monitored: dbaz
2014-08-04 11:20AugustoMauchReview Assigned To => dbaz
2014-08-04 11:26hgbotCheckin
2014-08-04 11:26hgbotNote Added: 0069063
2014-08-04 11:26hgbotStatusnew => resolved
2014-08-04 11:26hgbotResolutionopen => fixed
2014-08-04 11:26hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/28068c12e140a0c14315287fe636327d305280e3 [^]
2014-08-04 11:28AugustoMauchNote Added: 0069064
2014-08-04 21:08dbazStatusresolved => new
2014-08-04 21:08dbazResolutionfixed => open
2014-08-04 21:23dbazNote Added: 0069083
2014-08-04 21:23dbazFile Added: Config.png
2014-08-04 21:23dbazFile Added: Result.png
2014-08-05 12:38hgbotCheckin
2014-08-05 12:38hgbotNote Added: 0069088
2014-08-05 12:38hgbotStatusnew => resolved
2014-08-05 12:38hgbotResolutionopen => fixed
2014-08-05 12:38hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/28068c12e140a0c14315287fe636327d305280e3 [^] => http://code.openbravo.com/erp/devel/pi/rev/b4c15099de6b5946b8d52335e7920d06a7c12672 [^]
2014-08-05 14:59dbazNote Added: 0069091
2014-08-05 14:59dbazStatusresolved => closed
2014-08-05 14:59dbazFixed in Version => 3.0PR14Q4
2014-08-08 18:54hudsonbotCheckin
2014-08-08 18:54hudsonbotNote Added: 0069258
2014-08-08 18:54hudsonbotCheckin
2014-08-08 18:54hudsonbotNote Added: 0069265

Notes
(0069063)
hgbot   
2014-08-04 11:26   
Repository: erp/devel/pi
Changeset: 28068c12e140a0c14315287fe636327d305280e3
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Mon Aug 04 11:24:21 2014 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/28068c12e140a0c14315287fe636327d305280e3 [^]

Fixes issue 27202: AbsoluteDateTime properties are formatted in the identifier

The getIdentifier method of the IdentifierProvider class was only formatting the dates of the properties that used the Date or DateTime references. Now it also applies the proper date format for the properties that use the AbsoluteDateTime reference.

---
M src/org/openbravo/base/structure/IdentifierProvider.java
---
(0069064)
AugustoMauch   
2014-08-04 11:28   
Quick Steps to Reproduce:
As System Admin:
- Open Tables and Columns
- Select the Order table
- Change the reference of the Updated column to Absolute Date Time
- Include this column in the identifier of the table

As F&B Admin:
- Open Sales Order and select a record. Check that the proper identifier is shown in the title.
(0069083)
dbaz   
2014-08-04 21:23   
With the following configuration:

dateFormat.js=%d-%m-%Y
dateFormat.sql=DD-MM-YYYY
dateFormat.java=dd-MM-yyyy
dateTimeFormat.java=dd-MM-yyyy hh:mm:ss a
dateTimeFormat.sql=DD-MM-YYYY HH24:MI:SS

Install the following module:

https://code.openbravo.com/erp/mods/org.openbravo.platform.features/ [^]

As "System Administrator"
* Go to "Tables and Columns"
* Leave in "C_Order" table the "Used as Record Indenfifier" and its associated "Sequence Number" as shown in attached [Config.png]

Do ant.smartbuild

As "Openbravo Admin"
* Go to "Sales Order"
* Create a record with the values attached in [Result.png]

Notice that the shown text in the tab is:
"Sales Order - 2014-08-04 05:00:00.0 - 06-08-2014 12:00:00 AM - 1000108 - 2014-08-04 19:00:00.0 - 05-08-2014 08:00:00 PM"

and it should be:
"Sales Order - 5:00:00 AM - 06-08-2014 12:00:00 AM - 1000108 - 7:00:00 PM - 05-08-2014 08:00:00 PM"

So the tabs text should display exactly the same that is visualized in the form

It can be conclided that there is still a problem with the text of the Absolute Time (specified in the original issue) and with the Relative Time (not specified in the original issue) one.
(0069088)
hgbot   
2014-08-05 12:38   
Repository: erp/devel/pi
Changeset: b4c15099de6b5946b8d52335e7920d06a7c12672
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Tue Aug 05 12:37:18 2014 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/b4c15099de6b5946b8d52335e7920d06a7c12672 [^]

Fixes issue 27202: Time properties are formatted in the identifier

The previous changeset only fixed the problem for AbsoluteDateTime properties. This new changeset also applies the proper format for the Time and AbsoluteTime properties.

---
M src/org/openbravo/base/model/Property.java
M src/org/openbravo/base/structure/IdentifierProvider.java
---
(0069091)
dbaz   
2014-08-05 14:59   
The solution is not still perfect, because I see:
"Sales Order - 05:00:00 AM - 06-08-2014 12:00:00 AM - 1000108 - 07:00:00 PM - 05-08-2014 08:00:00 PM"

and I expect to see, as said before, the same than in the form, so:
"Sales Order - 5:00:00 AM - 06-08-2014 12:00:00 AM - 1000108 - 7:00:00 PM - 05-08-2014 08:00:00 PM"

Anyway, I think it could be good enough for the moment, so it can be closed.

Reviewed @ changeset 24214 - ca197a91d631
(0069258)
hudsonbot   
2014-08-08 18:54   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/4450016dee64 [^]
Maturity status: Test
(0069265)
hudsonbot   
2014-08-08 18:54   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/4450016dee64 [^]
Maturity status: Test