Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0026887
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Modules] Warehouse Pickingminorhave not tried2014-06-17 10:532015-01-21 15:44
ReporterjonalegriaesarteView Statuspublic 
Assigned Toumartirena 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchpiFixed in SCM revisionfe0deba2f493
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Regression date
Regression introduced by commit
Regression level
Review Assigned ToSandrahuguet
Regression introduced in release
Summary

0026887: Generate picking list is generating stock reservation event though there is not stock in the warehouse for the product

DescriptionGenerate picking list is generating stock reservation event though there is not stock in the warehouse for the product
Steps To Reproduce- Create a new product with sales price
- Create a sales order
- Two lines, one for the new product and the second one using a product with stock
- Book it
- Generate picking list
The system is creating stock reservation line for the product without stock with qty reserved 0.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
causes defect 0027457 closedAtulOpenbravo Openbravo ERP Stock Reservations are not processed when generating a picking list 

-  Notes
(0069462)
hgbot (developer)
2014-08-18 15:04

 Repository: erp/pmods/org.openbravo.warehouse.pickinglist
Changeset: cd1a58e4bbb63c40e38ce509ca0142f3243f0404
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Wed Aug 13 14:01:32 2014 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.pickinglist/rev/cd1a58e4bbb63c40e38ce509ca0142f3243f0404 [^]

Fixes Issue 26887:Generate WPL creates Stock reservation for no stock product

---
M src/org/openbravo/warehouse/pickinglist/CreateActionHandler.java
---
(0069463)
hgbot (developer)
2014-08-18 15:04

 Repository: erp/devel/pi
Changeset: e414f3f0e2986c28db926b692d9747b80cb7857a
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Wed Aug 13 14:03:09 2014 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/e414f3f0e2986c28db926b692d9747b80cb7857a [^]

Related To Issue 26887:Generate PL creates Stock reservation for no stock prod

---
M src-db/database/model/functions/M_RESERVATION_POST.xml
---
(0069466)
rafaroda (manager)
2014-08-18 16:33

 Properly completed test: see screenshots at https://drive.google.com/folderview?id=0B649lz4ZYJcHbDRPUXRMbkdFVk0&usp=sharing [^]

1) Created sales order with 2 lines: a product with stock and another one without stock

2) Generated Picking List with message: There is not enough stock in warehouses to create the whole Picking List. : [PL307]

3) Goods shipment created just included product with stock

4) Stock reservation generated only for product with stock
(0069522)
hudsonbot (developer)
2014-08-19 19:44

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/dfa98e390e6a [^]
Maturity status: Test
(0069791)
hgbot (developer)
2014-08-27 10:44

 Repository: erp/pmods/org.openbravo.warehouse.pickinglist
Changeset: 78727f0c017abe429b0b3c45acbc50053e9ad165
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Wed Aug 27 14:13:37 2014 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.pickinglist/rev/78727f0c017abe429b0b3c45acbc50053e9ad165 [^]

Backout Issue 26887

---
M src/org/openbravo/warehouse/pickinglist/CreateActionHandler.java
---
(0069805)
AtulOpenbravo (developer)
2014-08-27 13:03

 Re-open, backout changeset to publish a version with out Core module dependency.
(0070987)
AtulOpenbravo (developer)
2014-10-16 11:47
edited on: 2014-10-16 11:53

 Test Plan
- Enable Stock Reservation = Yes in the preferences.
- Create a new product and add price to it in Sales Price List Version.
- Create a sales order header.
- Create two lines, one for the new product and the second one using a product with stock [Reservation type can be set as Automatic in the order line]. Book it.
- Click on Generate picking list. Choose Direct Picking option. Process it.
- Check that system is creating stock reservation only for the product with stock.
(0070988)
AtulOpenbravo (developer)
2014-10-16 11:52

 Alternate Test Plan
- Enable Stock Reservation = Yes in the preferences.
- In Warehouse and Storage bin, set Type as Outbound to one of Storage Bin.
- Create a new product and add price to it in Sales Price List Version.
- Create a Sales Order with two lines, one for new product, one for existing product which has stock.[Reservation type can be set as Automatic in the order line] Book it.
- Using Generate picking list button, select Outbound type and choose appropriate bin, process it.
- Check that system is creating stock reservation only for product with stock.
(0073393)
hgbot (developer)
2015-01-09 12:11

 Repository: erp/pmods/org.openbravo.warehouse.pickinglist
Changeset: fe0deba2f493c5691003f87e7fea57ecb0c13a96
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Fri Jan 09 00:26:29 2015 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.pickinglist/rev/fe0deba2f493c5691003f87e7fea57ecb0c13a96 [^]

Fixes Issue 26887:Generate picking list is generating stock reservation even
though there is not stock in the warehouse for the product

Get Reservation from SO Line is skipped by checking whether stock for product
exists or not for both options Direct Picking and Outbound Picking List

---
M src/org/openbravo/warehouse/pickinglist/CreateActionHandler.java
M src/org/openbravo/warehouse/pickinglist/SelectOrdersHandler.java
M src/org/openbravo/warehouse/pickinglist/Utilities.java
---
(0073395)
umartirena (reporter)
2015-01-09 12:25

 Code Review and Testing Done.

The solution implemented finally is not core dependent, so is not necessary to update the dependency to it.
(0073487)
Sandrahuguet (developer)
2015-01-14 12:42
edited on: 2015-01-14 16:51

 Reopened because this test case is not working:

As group admin role:
   Check F&B España organization has both warehouses (Norte and Sur) defined as on hand
   Select a product which has stock only in one of that warehouses
   Create an order for the other warehouse (the one without stock of that product)
   Add the product to it and book it
   Try to generate the Picking List and check the following error message is shown:
      "There is not enough stock"
   The warehouse defined in the header should be the one where the stock is taken from, but in case it doesn't have stock, other on hand warehouses should be checked
(0073498)
hgbot (developer)
2015-01-14 16:44

 Repository: erp/pmods/org.openbravo.warehouse.pickinglist
Changeset: 841cb816dd724be7a98ba7a14453f037a2138b73
Author: Unai Martirena <unai.martirena <at> openbravo.com>
Date: Wed Jan 14 16:43:15 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.pickinglist/rev/841cb816dd724be7a98ba7a14453f037a2138b73 [^]

Related to Bug 26887:getstock should not be filtered by warehouse in dir picking

For direct picking the callGetStock method should not filter by warehouse of the Sales Order Header. But for Outbound picking it has to, so a boolean parameter has been added to the method in order to manage this. As this is a private method there is no api change doing this change.
Also a change has been added in catch code inside CreateActionHandler to return properly the error messages obtained.

---
M src/org/openbravo/warehouse/pickinglist/CreateActionHandler.java
M src/org/openbravo/warehouse/pickinglist/Utilities.java
---
(0073688)
Sandrahuguet (developer)
2015-01-21 15:44

 Code review + testing OK

- Issue History
Date Modified Username Field Change
2014-06-17 10:53 jonalegriaesarte New Issue
2014-06-17 10:53 jonalegriaesarte Assigned To => naiaramartinez
2014-06-17 10:53 jonalegriaesarte Resolution time => 1409522400
2014-08-12 10:52 AtulOpenbravo Assigned To naiaramartinez => AtulOpenbravo
2014-08-12 10:52 AtulOpenbravo Status new => scheduled
2014-08-12 10:52 AtulOpenbravo fix_in_branch => pi
2014-08-13 13:20 AtulOpenbravo Review Assigned To => rafaroda
2014-08-13 13:20 AtulOpenbravo fix_in_branch pi =>
2014-08-18 15:04 hgbot Checkin
2014-08-18 15:04 hgbot Note Added: 0069462
2014-08-18 15:04 hgbot Status scheduled => resolved
2014-08-18 15:04 hgbot Resolution open => fixed
2014-08-18 15:04 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.pickinglist/rev/cd1a58e4bbb63c40e38ce509ca0142f3243f0404 [^]
2014-08-18 15:04 hgbot Checkin
2014-08-18 15:04 hgbot Note Added: 0069463
2014-08-18 16:33 rafaroda Note Added: 0069466
2014-08-18 16:33 rafaroda Status resolved => closed
2014-08-19 19:44 hudsonbot Checkin
2014-08-19 19:44 hudsonbot Note Added: 0069522
2014-08-25 08:13 ngarcia Relationship added causes 0027457
2014-08-27 10:44 hgbot Checkin
2014-08-27 10:44 hgbot Note Added: 0069791
2014-08-27 13:03 AtulOpenbravo Note Added: 0069805
2014-08-27 13:03 AtulOpenbravo Status closed => new
2014-08-27 13:03 AtulOpenbravo Resolution fixed => open
2014-08-27 13:03 AtulOpenbravo Status new => scheduled
2014-08-27 13:03 AtulOpenbravo fix_in_branch => pi
2014-10-16 11:47 AtulOpenbravo Note Added: 0070987
2014-10-16 11:47 AtulOpenbravo Note Edited: 0070987 View Revisions
2014-10-16 11:52 AtulOpenbravo Note Added: 0070988
2014-10-16 11:53 AtulOpenbravo Note Edited: 0070987 View Revisions
2014-10-20 08:18 AtulOpenbravo File Added: FinalFix26887.diff
2014-10-20 08:18 AtulOpenbravo File Added: RelatedToIssue26887.diff
2014-10-20 08:21 AtulOpenbravo Note Added: 0071038
2015-01-02 13:47 ngarcia Issue Monitored: ngarcia
2015-01-09 12:09 AtulOpenbravo Review Assigned To rafaroda => umartirena
2015-01-09 12:09 AtulOpenbravo fix_in_branch pi =>
2015-01-09 12:10 AtulOpenbravo File Deleted: FinalFix26887.diff
2015-01-09 12:10 AtulOpenbravo File Deleted: RelatedToIssue26887.diff
2015-01-09 12:10 AtulOpenbravo Note Deleted: 0071038
2015-01-09 12:11 hgbot Checkin
2015-01-09 12:11 hgbot Note Added: 0073393
2015-01-09 12:11 hgbot Status scheduled => resolved
2015-01-09 12:11 hgbot Resolution open => fixed
2015-01-09 12:11 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.pickinglist/rev/cd1a58e4bbb63c40e38ce509ca0142f3243f0404 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.warehouse.pickinglist/rev/fe0deba2f493c5691003f87e7fea57ecb0c13a96 [^]
2015-01-09 12:25 umartirena Note Added: 0073395
2015-01-09 12:25 umartirena Status resolved => closed
2015-01-14 12:42 Sandrahuguet Assigned To AtulOpenbravo => umartirena
2015-01-14 12:42 Sandrahuguet Note Added: 0073487
2015-01-14 12:42 Sandrahuguet Status closed => new
2015-01-14 12:42 Sandrahuguet Resolution fixed => open
2015-01-14 16:44 hgbot Checkin
2015-01-14 16:44 hgbot Note Added: 0073498
2015-01-14 16:51 umartirena Note Edited: 0073487 View Revisions
2015-01-21 15:43 Sandrahuguet Status new => scheduled
2015-01-21 15:43 Sandrahuguet fix_in_branch => pi
2015-01-21 15:43 Sandrahuguet Status scheduled => resolved
2015-01-21 15:43 Sandrahuguet Resolution open => fixed
2015-01-21 15:44 Sandrahuguet Review Assigned To umartirena => Sandrahuguet
2015-01-21 15:44 Sandrahuguet Note Added: 0073688
2015-01-21 15:44 Sandrahuguet Status resolved => closed

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker