Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0026349
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformmajorhave not tried2014-04-23 22:542015-12-17 08:32
ReportermtaalView Statuspublic 
Assigned Toinigosanchez 
PriorityhighResolutionfixedFixed in Version3.0PR16Q1
StatusclosedFix in branchFixed in SCM revision67bf31e6746a
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Toalostale
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0026349: Make triggerhandler more robust/fail earlier to prevent triggers to remain disabled

DescriptionSee the attached diff with my proposed changes.
Steps To ReproduceSee diff
TagsNo tags attached.
Attached Filesdiff file icon triggerhandler.diff [^] (1,621 bytes) 2014-04-23 22:54 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]
related to defect 0026352 closedmtaal Retail Modules Robustness: Improve handling of disabling triggers, make orderloader also handle throwables 

-  Notes
(0082721)
hgbot (developer)
2015-12-14 14:13

Repository: erp/devel/pi
Changeset: 67bf31e6746a1fcf1e6c435cd37aa1c0fa2b098f
Author: Inigo Sanchez <inigo.sanchez <at> openbravo.com>
Date: Mon Dec 14 14:11:12 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/67bf31e6746a1fcf1e6c435cd37aa1c0fa2b098f [^]

Fixed issue 26349: Robustness:Improve handling of disabling triggers.

It has been improved the handling of disabling triggers by throwing
exceptions in enable() and disable() methods instead of error logs.

Now an exception is thrown if there is a problem in enable() and
disable() methods.

Besides it has been added a change to improve where clear() method
is invoked.

---
M src/org/openbravo/dal/core/TriggerHandler.java
M src/org/openbravo/service/system/SystemService.java
---
(0082789)
hudsonbot (developer)
2015-12-15 23:49

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/ecd185534f50 [^]
Maturity status: Test
(0082812)
alostale (manager)
2015-12-17 08:32

code reviewed

- Issue History
Date Modified Username Field Change
2014-04-23 22:54 mtaal New Issue
2014-04-23 22:54 mtaal Assigned To => AugustoMauch
2014-04-23 22:54 mtaal File Added: triggerhandler.diff
2014-04-23 22:54 mtaal Modules => Core
2014-04-23 22:54 mtaal Triggers an Emergency Pack => No
2014-04-23 23:19 mtaal Relationship added related to 0026352
2015-03-11 13:38 alostale Priority normal => high
2015-03-11 13:38 alostale Status new => acknowledged
2015-03-17 14:37 alostale Assigned To AugustoMauch => platform
2015-12-14 11:45 inigosanchez Assigned To platform => inigosanchez
2015-12-14 11:45 inigosanchez Status acknowledged => scheduled
2015-12-14 14:11 inigosanchez Review Assigned To => alostale
2015-12-14 14:13 hgbot Checkin
2015-12-14 14:13 hgbot Note Added: 0082721
2015-12-14 14:13 hgbot Status scheduled => resolved
2015-12-14 14:13 hgbot Resolution open => fixed
2015-12-14 14:13 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/67bf31e6746a1fcf1e6c435cd37aa1c0fa2b098f [^]
2015-12-15 23:49 hudsonbot Checkin
2015-12-15 23:49 hudsonbot Note Added: 0082789
2015-12-17 08:32 alostale Note Added: 0082812
2015-12-17 08:32 alostale Status resolved => closed
2015-12-17 08:32 alostale Fixed in Version => 3.0PR16Q1


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker