Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0026349Openbravo ERPA. Platformpublic2014-04-23 22:542015-12-17 08:32
Reportermtaal 
Assigned Toinigosanchez 
PriorityhighSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR16Q1 
Merge Request Status
Review Assigned Toalostale
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0026349: Make triggerhandler more robust/fail earlier to prevent triggers to remain disabled
DescriptionSee the attached diff with my proposed changes.
Steps To ReproduceSee diff
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0026352 closed mtaal Retail Modules Robustness: Improve handling of disabling triggers, make orderloader also handle throwables 
Attached Filesdiff triggerhandler.diff (1,621) 2014-04-23 22:54
https://issues.openbravo.com/file_download.php?file_id=6872&type=bug
Issue History
Date ModifiedUsernameFieldChange
2014-04-23 22:54mtaalNew Issue
2014-04-23 22:54mtaalAssigned To => AugustoMauch
2014-04-23 22:54mtaalFile Added: triggerhandler.diff
2014-04-23 22:54mtaalModules => Core
2014-04-23 22:54mtaalOBNetwork customer => No
2014-04-23 22:54mtaalTriggers an Emergency Pack => No
2014-04-23 23:19mtaalRelationship addedrelated to 0026352
2015-03-11 13:38alostalePrioritynormal => high
2015-03-11 13:38alostaleStatusnew => acknowledged
2015-03-17 14:37alostaleAssigned ToAugustoMauch => platform
2015-12-14 11:45inigosanchezAssigned Toplatform => inigosanchez
2015-12-14 11:45inigosanchezStatusacknowledged => scheduled
2015-12-14 14:11inigosanchezReview Assigned To => alostale
2015-12-14 14:13hgbotCheckin
2015-12-14 14:13hgbotNote Added: 0082721
2015-12-14 14:13hgbotStatusscheduled => resolved
2015-12-14 14:13hgbotResolutionopen => fixed
2015-12-14 14:13hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/67bf31e6746a1fcf1e6c435cd37aa1c0fa2b098f [^]
2015-12-15 23:49hudsonbotCheckin
2015-12-15 23:49hudsonbotNote Added: 0082789
2015-12-17 08:32alostaleNote Added: 0082812
2015-12-17 08:32alostaleStatusresolved => closed
2015-12-17 08:32alostaleFixed in Version => 3.0PR16Q1

Notes
(0082721)
hgbot   
2015-12-14 14:13   
Repository: erp/devel/pi
Changeset: 67bf31e6746a1fcf1e6c435cd37aa1c0fa2b098f
Author: Inigo Sanchez <inigo.sanchez <at> openbravo.com>
Date: Mon Dec 14 14:11:12 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/67bf31e6746a1fcf1e6c435cd37aa1c0fa2b098f [^]

Fixed issue 26349: Robustness:Improve handling of disabling triggers.

It has been improved the handling of disabling triggers by throwing
exceptions in enable() and disable() methods instead of error logs.

Now an exception is thrown if there is a problem in enable() and
disable() methods.

Besides it has been added a change to improve where clear() method
is invoked.

---
M src/org/openbravo/dal/core/TriggerHandler.java
M src/org/openbravo/service/system/SystemService.java
---
(0082789)
hudsonbot   
2015-12-15 23:49   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/ecd185534f50 [^]
Maturity status: Test
(0082812)
alostale   
2015-12-17 08:32   
code reviewed