Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0026226 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Retail Modules] Web POS | major | always | 2014-04-09 16:03 | 2014-05-20 13:51 | |||
| Reporter | dbaz | View Status | public | |||||
| Assigned To | Orekaria | |||||||
| Priority | high | Resolution | fixed | Fixed in Version | RR14Q3 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | b3972b1db99d | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | adrianromero | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0026226: [UX] Ticket customer/address button should be narrower | |||||||
| Description | Ticket customer/address button should be narrower. Right now it seems that the buttons has a lot of margin, so they can be really big, and this is causing visualization problems in a 4:3 screen (iPad) The buttons should adapt its size to its text and reduce the right/left margin. I attach one screenshot of the current visualization and another one of how it should look like. This solution is not perfect, because if the text is too large in any of the two buttons, the problem will be there again, but this is a more corner case than the actual scenario where it can be reproduced almost always. | |||||||
| Steps To Reproduce | Open the WebPOS and look at the ticket | |||||||
| Tags | No tags attached. | |||||||
| Attached Files |  WebPOS-1.png [^] (110,580 bytes) 2014-04-09 16:04
WebPOS-2.png [^] (103,374 bytes) 2014-04-09 16:04
| |||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0066677) hgbot (developer) 2014-04-29 14:03 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 0a542b9d6a7409eb60b625064ec8d598dda1e643 Author: Orekaria <ral <at> openbravo.com> Date: Tue Apr 29 14:03:12 2014 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0a542b9d6a7409eb60b625064ec8d598dda1e643 [^] Fixed issue 26226: customer/address button redesigned --- M web/org.openbravo.retail.posterminal/js/components/bplocation.js M web/org.openbravo.retail.posterminal/js/components/businesspartner.js M web/org.openbravo.retail.posterminal/js/components/order.js M web/org.openbravo.retail.posterminal/js/components/orderdetails.js --- |
|
(0066769) hgbot (developer) 2014-05-01 17:46 |
Repository: erp/pmods/org.openbravo.retail.posterminal.unstablenetworks Changeset: 0a542b9d6a7409eb60b625064ec8d598dda1e643 Author: Orekaria <ral <at> openbravo.com> Date: Tue Apr 29 14:03:12 2014 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal.unstablenetworks/rev/0a542b9d6a7409eb60b625064ec8d598dda1e643 [^] Fixed issue 26226: customer/address button redesigned --- M web/org.openbravo.retail.posterminal/js/components/bplocation.js M web/org.openbravo.retail.posterminal/js/components/businesspartner.js M web/org.openbravo.retail.posterminal/js/components/order.js M web/org.openbravo.retail.posterminal/js/components/orderdetails.js --- |
|
(0067137) dbaz (developer) 2014-05-14 17:50 |
Thare are now two new problems: 1) Button padding: The current solution has almost no padding in the right-left side of the buttons. This is not what is was shown in the attached screenshot. Following the rules applied to the "Delete", "Description", "Return Line", in the following lines: https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0a542b9d6a7409eb60b625064ec8d598dda1e643#l1.8 [^] https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0a542b9d6a7409eb60b625064ec8d598dda1e643#l2.8 [^] The padding should be padding: 5px 15px; instead of padding: 5px; 2) Button margins: Also, before this changeset the buttons were not so near to the corner. To fix them, change here: https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0a542b9d6a7409eb60b625064ec8d598dda1e643#l1.8 [^] The margin should be margin: 10px 10px 10px 2px; instead of margin: 5px 0px 5px 3px; and here: https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0a542b9d6a7409eb60b625064ec8d598dda1e643#l2.8 [^] The margin should be margin: 10px 2px 10px 10px; instead of margin: 5px 2px 5px 0px; |
|
(0067138) dbaz (developer) 2014-05-14 17:51 |
A better solution, just REMOVE the padding and margin attributes and values from the lines https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0a542b9d6a7409eb60b625064ec8d598dda1e643#l1.8 [^] https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0a542b9d6a7409eb60b625064ec8d598dda1e643#l2.8 [^] and automatically the component will apply the ones defined in the "btnlink-small" class, which are the ones that we need here. Regards. |
|
(0067236) hgbot (developer) 2014-05-17 19:13 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: b3972b1db99dbe4bffc74592836e0a0fca49d19c Author: Rafa Alonso <rafael.alonso <at> openbravo.com> Date: Sat May 17 19:12:32 2014 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b3972b1db99dbe4bffc74592836e0a0fca49d19c [^] Fixed issue 26226: [UX] Ticket customer/address button should be narrower --- M web/org.openbravo.retail.posterminal/js/components/bplocation.js M web/org.openbravo.retail.posterminal/js/components/businesspartner.js --- |
|
(0067273) adrianromero (manager) 2014-05-19 18:12 |
Reviewed |
|
(0067281) hgbot (developer) 2014-05-20 08:49 |
Repository: erp/pmods/org.openbravo.retail.posterminal.unstablenetworks Changeset: b3972b1db99dbe4bffc74592836e0a0fca49d19c Author: Rafa Alonso <rafael.alonso <at> openbravo.com> Date: Sat May 17 19:12:32 2014 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal.unstablenetworks/rev/b3972b1db99dbe4bffc74592836e0a0fca49d19c [^] Fixed issue 26226: [UX] Ticket customer/address button should be narrower --- M web/org.openbravo.retail.posterminal/js/components/bplocation.js M web/org.openbravo.retail.posterminal/js/components/businesspartner.js --- |
|
(0067317) mtaal (manager) 2014-05-20 13:51 |
comment: reclosing as only re-opened by merge |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2014-04-09 16:03 | dbaz | New Issue | |
| 2014-04-09 16:03 | dbaz | Assigned To | => malsasua |
| 2014-04-09 16:03 | dbaz | Triggers an Emergency Pack | => No |
| 2014-04-09 16:04 | dbaz | File Added: WebPOS-1.png | |
| 2014-04-09 16:04 | dbaz | File Added: WebPOS-2.png | |
| 2014-04-29 14:03 | hgbot | Checkin | |
| 2014-04-29 14:03 | hgbot | Note Added: 0066677 | |
| 2014-04-29 14:03 | hgbot | Status | new => resolved |
| 2014-04-29 14:03 | hgbot | Resolution | open => fixed |
| 2014-04-29 14:03 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0a542b9d6a7409eb60b625064ec8d598dda1e643 [^] |
| 2014-05-01 17:46 | hgbot | Checkin | |
| 2014-05-01 17:46 | hgbot | Note Added: 0066769 | |
| 2014-05-01 17:46 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0a542b9d6a7409eb60b625064ec8d598dda1e643 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal.unstablenetworks/rev/0a542b9d6a7409eb60b625064ec8d598dda1e643 [^] |
| 2014-05-14 17:50 | dbaz | Note Added: 0067137 | |
| 2014-05-14 17:50 | dbaz | Status | resolved => new |
| 2014-05-14 17:50 | dbaz | Resolution | fixed => open |
| 2014-05-14 17:51 | dbaz | Note Added: 0067138 | |
| 2014-05-14 18:04 | malsasua | Assigned To | malsasua => Orekaria |
| 2014-05-17 19:13 | hgbot | Checkin | |
| 2014-05-17 19:13 | hgbot | Note Added: 0067236 | |
| 2014-05-17 19:13 | hgbot | Status | new => resolved |
| 2014-05-17 19:13 | hgbot | Resolution | open => fixed |
| 2014-05-17 19:13 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal.unstablenetworks/rev/0a542b9d6a7409eb60b625064ec8d598dda1e643 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b3972b1db99dbe4bffc74592836e0a0fca49d19c [^] |
| 2014-05-19 18:12 | adrianromero | Review Assigned To | => adrianromero |
| 2014-05-19 18:12 | adrianromero | Note Added: 0067273 | |
| 2014-05-19 18:12 | adrianromero | Status | resolved => closed |
| 2014-05-19 18:12 | adrianromero | Fixed in Version | => RR14Q3 |
| 2014-05-20 08:49 | hgbot | Checkin | |
| 2014-05-20 08:49 | hgbot | Note Added: 0067281 | |
| 2014-05-20 08:49 | hgbot | Status | closed => resolved |
| 2014-05-20 08:49 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b3972b1db99dbe4bffc74592836e0a0fca49d19c [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal.unstablenetworks/rev/b3972b1db99dbe4bffc74592836e0a0fca49d19c [^] |
| 2014-05-20 13:51 | mtaal | Note Added: 0067317 | |
| 2014-05-20 13:51 | mtaal | Status | resolved => closed |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |