Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0026226Retail ModulesWeb POSpublic2014-04-09 16:032014-05-20 13:51
Reporterdbaz 
Assigned ToOrekaria 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR14Q3 
Merge Request Status
Review Assigned Toadrianromero
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0026226: [UX] Ticket customer/address button should be narrower
DescriptionTicket customer/address button should be narrower. Right now it seems that the buttons has a lot of margin, so they can be really big, and this is causing visualization problems in a 4:3 screen (iPad)

The buttons should adapt its size to its text and reduce the right/left margin.

I attach one screenshot of the current visualization and another one of how it should look like.

This solution is not perfect, because if the text is too large in any of the two buttons, the problem will be there again, but this is a more corner case than the actual scenario where it can be reproduced almost always.
Steps To ReproduceOpen the WebPOS and look at the ticket
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Filespng WebPOS-1.png (110,580) 2014-04-09 16:04
https://issues.openbravo.com/file_download.php?file_id=6818&type=bug
png

png WebPOS-2.png (103,374) 2014-04-09 16:04
https://issues.openbravo.com/file_download.php?file_id=6819&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2014-04-09 16:03dbazNew Issue
2014-04-09 16:03dbazAssigned To => malsasua
2014-04-09 16:03dbazTriggers an Emergency Pack => No
2014-04-09 16:04dbazFile Added: WebPOS-1.png
2014-04-09 16:04dbazFile Added: WebPOS-2.png
2014-04-29 14:03hgbotCheckin
2014-04-29 14:03hgbotNote Added: 0066677
2014-04-29 14:03hgbotStatusnew => resolved
2014-04-29 14:03hgbotResolutionopen => fixed
2014-04-29 14:03hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0a542b9d6a7409eb60b625064ec8d598dda1e643 [^]
2014-05-01 17:46hgbotCheckin
2014-05-01 17:46hgbotNote Added: 0066769
2014-05-01 17:46hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0a542b9d6a7409eb60b625064ec8d598dda1e643 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal.unstablenetworks/rev/0a542b9d6a7409eb60b625064ec8d598dda1e643 [^]
2014-05-14 17:50dbazNote Added: 0067137
2014-05-14 17:50dbazStatusresolved => new
2014-05-14 17:50dbazResolutionfixed => open
2014-05-14 17:51dbazNote Added: 0067138
2014-05-14 18:04malsasuaAssigned Tomalsasua => Orekaria
2014-05-17 19:13hgbotCheckin
2014-05-17 19:13hgbotNote Added: 0067236
2014-05-17 19:13hgbotStatusnew => resolved
2014-05-17 19:13hgbotResolutionopen => fixed
2014-05-17 19:13hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal.unstablenetworks/rev/0a542b9d6a7409eb60b625064ec8d598dda1e643 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b3972b1db99dbe4bffc74592836e0a0fca49d19c [^]
2014-05-19 18:12adrianromeroReview Assigned To => adrianromero
2014-05-19 18:12adrianromeroNote Added: 0067273
2014-05-19 18:12adrianromeroStatusresolved => closed
2014-05-19 18:12adrianromeroFixed in Version => RR14Q3
2014-05-20 08:49hgbotCheckin
2014-05-20 08:49hgbotNote Added: 0067281
2014-05-20 08:49hgbotStatusclosed => resolved
2014-05-20 08:49hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b3972b1db99dbe4bffc74592836e0a0fca49d19c [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal.unstablenetworks/rev/b3972b1db99dbe4bffc74592836e0a0fca49d19c [^]
2014-05-20 13:51mtaalNote Added: 0067317
2014-05-20 13:51mtaalStatusresolved => closed

Notes
(0066677)
hgbot   
2014-04-29 14:03   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 0a542b9d6a7409eb60b625064ec8d598dda1e643
Author: Orekaria <ral <at> openbravo.com>
Date: Tue Apr 29 14:03:12 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0a542b9d6a7409eb60b625064ec8d598dda1e643 [^]

Fixed issue 26226: customer/address button redesigned

---
M web/org.openbravo.retail.posterminal/js/components/bplocation.js
M web/org.openbravo.retail.posterminal/js/components/businesspartner.js
M web/org.openbravo.retail.posterminal/js/components/order.js
M web/org.openbravo.retail.posterminal/js/components/orderdetails.js
---
(0066769)
hgbot   
2014-05-01 17:46   
Repository: erp/pmods/org.openbravo.retail.posterminal.unstablenetworks
Changeset: 0a542b9d6a7409eb60b625064ec8d598dda1e643
Author: Orekaria <ral <at> openbravo.com>
Date: Tue Apr 29 14:03:12 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal.unstablenetworks/rev/0a542b9d6a7409eb60b625064ec8d598dda1e643 [^]

Fixed issue 26226: customer/address button redesigned

---
M web/org.openbravo.retail.posterminal/js/components/bplocation.js
M web/org.openbravo.retail.posterminal/js/components/businesspartner.js
M web/org.openbravo.retail.posterminal/js/components/order.js
M web/org.openbravo.retail.posterminal/js/components/orderdetails.js
---
(0067137)
dbaz   
2014-05-14 17:50   
Thare are now two new problems:

1) Button padding:

The current solution has almost no padding in the right-left side of the buttons. This is not what is was shown in the attached screenshot.

Following the rules applied to the "Delete", "Description", "Return Line", in the following lines:

https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0a542b9d6a7409eb60b625064ec8d598dda1e643#l1.8 [^]

https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0a542b9d6a7409eb60b625064ec8d598dda1e643#l2.8 [^]

The padding should be
padding: 5px 15px;
instead of
padding: 5px;


2) Button margins:

Also, before this changeset the buttons were not so near to the corner. To fix them, change here:

https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0a542b9d6a7409eb60b625064ec8d598dda1e643#l1.8 [^]

The margin should be
margin: 10px 10px 10px 2px;
instead of
margin: 5px 0px 5px 3px;

and here:

https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0a542b9d6a7409eb60b625064ec8d598dda1e643#l2.8 [^]

The margin should be
margin: 10px 2px 10px 10px;
instead of
margin: 5px 2px 5px 0px;
(0067138)
dbaz   
2014-05-14 17:51   
A better solution, just REMOVE the padding and margin attributes and values from the lines

https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0a542b9d6a7409eb60b625064ec8d598dda1e643#l1.8 [^]

https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0a542b9d6a7409eb60b625064ec8d598dda1e643#l2.8 [^]

and automatically the component will apply the ones defined in the "btnlink-small" class, which are the ones that we need here.

Regards.
(0067236)
hgbot   
2014-05-17 19:13   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: b3972b1db99dbe4bffc74592836e0a0fca49d19c
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Sat May 17 19:12:32 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b3972b1db99dbe4bffc74592836e0a0fca49d19c [^]

Fixed issue 26226: [UX] Ticket customer/address button should be narrower

---
M web/org.openbravo.retail.posterminal/js/components/bplocation.js
M web/org.openbravo.retail.posterminal/js/components/businesspartner.js
---
(0067273)
adrianromero   
2014-05-19 18:12   
Reviewed
(0067281)
hgbot   
2014-05-20 08:49   
Repository: erp/pmods/org.openbravo.retail.posterminal.unstablenetworks
Changeset: b3972b1db99dbe4bffc74592836e0a0fca49d19c
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Sat May 17 19:12:32 2014 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal.unstablenetworks/rev/b3972b1db99dbe4bffc74592836e0a0fca49d19c [^]

Fixed issue 26226: [UX] Ticket customer/address button should be narrower

---
M web/org.openbravo.retail.posterminal/js/components/bplocation.js
M web/org.openbravo.retail.posterminal/js/components/businesspartner.js
---
(0067317)
mtaal   
2014-05-20 13:51   
comment: reclosing as only re-opened by merge