Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0026138
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. PlatformtrivialN/A2014-04-02 09:162014-06-05 09:00
ReporteralostaleView Statuspublic 
Assigned Toshankarb 
PrioritynormalResolutionfixedFixed in Version3.0PR14Q3
StatusclosedFix in branchFixed in SCM revisionfee9a7256fe8
ProjectionnoneETAnoneTarget Version3.0PR14Q3
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Toalostale
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0026138: Small code clean up in HSAS

DescriptionAfter patch to fix issue 0026095, some minor changes in HSAS are still pending:

-There are two renderJR methods (lines 1197 and 1210) which body is duplicated: the one without forceRefresh param should invoke the other one.
-There is a private renderJR method (line 1239) which solely calls the bigger renderJR (line 1247): private method can be completely removed changing its invocations to the bigger one
Steps To Reproduce-
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
related to defect 00260953.0PR14Q2 closedshankarb Add Infrastructure to refresh record after printing record 

-  Notes
(0067444)
hgbot (developer)
2014-05-26 12:54

Repository: erp/devel/pi
Changeset: fee9a7256fe8337582284d5d594b336bb79b80d0
Author: Shankar Balachandran <shankar.balachandran <at> openbravo.com>
Date: Mon May 26 13:27:53 2014 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/fee9a7256fe8337582284d5d594b336bb79b80d0 [^]

Fixes Issue 26138: Small code clean up in HSAS

Removed unneeded private method.
Removed duplicate code.

---
M src/org/openbravo/base/secureApp/HttpSecureAppServlet.java
---
(0067497)
hudsonbot (developer)
2014-05-27 23:09

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/15bdf44a37ae [^]
Maturity status: Test
(0067770)
alostale (manager)
2014-06-05 09:00

code reviewed

- Issue History
Date Modified Username Field Change
2014-04-02 09:16 alostale New Issue
2014-04-02 09:16 alostale Assigned To => shankarb
2014-04-02 09:16 alostale Modules => Core
2014-04-02 09:16 alostale Triggers an Emergency Pack => No
2014-04-02 09:16 alostale Relationship added related to 0026095
2014-05-26 05:44 shankarb Status new => scheduled
2014-05-26 05:44 shankarb fix_in_branch => pi
2014-05-26 12:43 shankarb Review Assigned To => alostale
2014-05-26 12:43 shankarb fix_in_branch pi =>
2014-05-26 12:54 hgbot Checkin
2014-05-26 12:54 hgbot Note Added: 0067444
2014-05-26 12:54 hgbot Status scheduled => resolved
2014-05-26 12:54 hgbot Resolution open => fixed
2014-05-26 12:54 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/fee9a7256fe8337582284d5d594b336bb79b80d0 [^]
2014-05-27 23:09 hudsonbot Checkin
2014-05-27 23:09 hudsonbot Note Added: 0067497
2014-06-05 09:00 alostale Note Added: 0067770
2014-06-05 09:00 alostale Status resolved => closed
2014-06-05 09:00 alostale Fixed in Version => PR14Q3


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker