Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0026138Openbravo ERPA. Platformpublic2014-04-02 09:162014-06-05 09:00
Reporteralostale 
Assigned Toshankarb 
PrioritynormalSeveritytrivialReproducibilityN/A
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR14Q3Fixed in Version3.0PR14Q3 
Merge Request Status
Review Assigned Toalostale
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0026138: Small code clean up in HSAS
DescriptionAfter patch to fix issue 0026095, some minor changes in HSAS are still pending:

-There are two renderJR methods (lines 1197 and 1210) which body is duplicated: the one without forceRefresh param should invoke the other one.
-There is a private renderJR method (line 1239) which solely calls the bigger renderJR (line 1247): private method can be completely removed changing its invocations to the bigger one
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 00260953.0PR14Q2 closed shankarb Add Infrastructure to refresh record after printing record 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2014-04-02 09:16alostaleNew Issue
2014-04-02 09:16alostaleAssigned To => shankarb
2014-04-02 09:16alostaleModules => Core
2014-04-02 09:16alostaleOBNetwork customer => No
2014-04-02 09:16alostaleTriggers an Emergency Pack => No
2014-04-02 09:16alostaleRelationship addedrelated to 0026095
2014-05-26 05:44shankarbStatusnew => scheduled
2014-05-26 05:44shankarbfix_in_branch => pi
2014-05-26 12:43shankarbReview Assigned To => alostale
2014-05-26 12:43shankarbfix_in_branchpi =>
2014-05-26 12:54hgbotCheckin
2014-05-26 12:54hgbotNote Added: 0067444
2014-05-26 12:54hgbotStatusscheduled => resolved
2014-05-26 12:54hgbotResolutionopen => fixed
2014-05-26 12:54hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/fee9a7256fe8337582284d5d594b336bb79b80d0 [^]
2014-05-27 23:09hudsonbotCheckin
2014-05-27 23:09hudsonbotNote Added: 0067497
2014-06-05 09:00alostaleNote Added: 0067770
2014-06-05 09:00alostaleStatusresolved => closed
2014-06-05 09:00alostaleFixed in Version => PR14Q3

Notes
(0067444)
hgbot   
2014-05-26 12:54   
Repository: erp/devel/pi
Changeset: fee9a7256fe8337582284d5d594b336bb79b80d0
Author: Shankar Balachandran <shankar.balachandran <at> openbravo.com>
Date: Mon May 26 13:27:53 2014 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/fee9a7256fe8337582284d5d594b336bb79b80d0 [^]

Fixes Issue 26138: Small code clean up in HSAS

Removed unneeded private method.
Removed duplicate code.

---
M src/org/openbravo/base/secureApp/HttpSecureAppServlet.java
---
(0067497)
hudsonbot   
2014-05-27 23:09   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/15bdf44a37ae [^]
Maturity status: Test
(0067770)
alostale   
2014-06-05 09:00   
code reviewed