Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0026092 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] B. User interface | minor | have not tried | 2014-03-26 17:06 | 2014-10-01 16:10 | |||
| Reporter | AugustoMauch | View Status | public | |||||
| Assigned To | dbaz | |||||||
| Priority | immediate | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | a0ffafde2f77 | ||||
| Projection | none | ETA | none | Target Version | 3.0PR14Q2 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | alostale | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | Pre packaging ( pi ) | |||||||
| Regression date | 2014-02-26 | |||||||
| Regression introduced in release | pi | |||||||
| Regression introduced by commit | https://code.openbravo.com/erp/devel/pi/rev/20eb3426d990 [^] | |||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0026092: Styling issues while editing a row in the grid | |||||||
| Description | The styling of the edited grid has been affected by the smartclient upgrade: - The fields are missing the left margin - The right border of the text fields is missing - The drop icons are shown truncated - The checkboxes are not aligned vertically All these problems are solved (except the last problem, that gets worse) if the size of a column is modified while the grid is being edited Two images have been attached to compare the current style with the previous one. Also, if a checkbox is checked/unchecked and the focus is moved to another row, the checkboxes are centered, when they should be aligned to the left. | |||||||
| Steps To Reproduce | - Open any window - Click the Edit in Grid button. - Check that the style is wrong To reproduce the last problem: - Open Organization - Edit in grid view any organization - Change the state of the summary level checkbox - While still editing, click on another row - Check that the checkboxes are now centered. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files |  EditingGridBefore.png [^] (42,292 bytes) 2014-03-26 17:06
EditingGridAfter.png [^] (41,879 bytes) 2014-03-26 17:06
CheckboxVerticalAlignment.png [^] (14,722 bytes) 2014-04-01 21:17
| |||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0065548) dbaz (developer) 2014-03-27 22:31 |
The issue has been reported to Isomorphic: http://forums.smartclient.com/showthread.php?p=118031 [^] |
|
(0065637) hgbot (developer) 2014-03-31 22:34 |
Repository: erp/devel/pi Changeset: a0ffafde2f77e0b28e9c3cce9163801954fd4d0b Author: David Baz Fayos <david.baz <at> openbravo.com> Date: Mon Mar 31 22:33:47 2014 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/a0ffafde2f77e0b28e9c3cce9163801954fd4d0b [^] Related to issue 26092: avoid input icons be cropped --- M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js --- |
|
(0065642) hudsonbot (developer) 2014-04-01 09:16 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/648c4d0c52f8 [^] Maturity status: Test |
|
(0065684) hgbot (developer) 2014-04-01 21:13 |
Repository: erp/devel/pi Changeset: 003cc8c257f78ff5d5f905ff1048e289b45fbd5d Author: David Baz Fayos <david.baz <at> openbravo.com> Date: Tue Apr 01 21:11:15 2014 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/003cc8c257f78ff5d5f905ff1048e289b45fbd5d [^] Related to issue 26092: Checkboxes are now always left-aligned in grid view even after column resizing --- M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js --- |
|
(0065685) hgbot (developer) 2014-04-01 21:14 |
Repository: erp/devel/pi Changeset: c0811054ce65644965eec4eedb478e5da1c75950 Author: David Baz Fayos <david.baz <at> openbravo.com> Date: Tue Apr 01 21:13:44 2014 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/c0811054ce65644965eec4eedb478e5da1c75950 [^] Related to issue 26092: inputs are now always centered while editing records in the grid --- M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js --- |
|
(0065686) dbaz (developer) 2014-04-01 21:24 |
All the issues have been fixed except "The checkboxes are not aligned vertically". This issue is due to the way Smartclient now manages checkboxes position. Anyway, as you can see in the attached "CheckboxVerticalAlignment.png" screenshot, inputs are not vertically aligned (due that the input height minus the grid row height has a odd value) and they were like this also in MP31, so now, the checkbox is aligned with the inputs. A solution for both vertical alignment problems (checkbox + inputs) could be add (or substract) one pixel to the row heights, but this could break other components like query widgets where the grid just fits the container. Summarizing: the vertical alignment problem is out of the scope. |
|
(0065999) plujan (manager) 2014-04-02 09:04 |
Closed as it was in Resolved for too long |
|
(0066064) plujan (manager) 2014-04-02 12:19 |
Reverted as wrongly closed |
|
(0066078) alostale (manager) 2014-04-02 15:19 |
code reviewed + tested |
|
(0066870) hudsonbot (developer) 2014-05-07 18:10 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/02ca2648bcdc [^] Maturity status: Test |
|
(0066871) hudsonbot (developer) 2014-05-07 18:10 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/02ca2648bcdc [^] Maturity status: Test |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2014-03-26 17:06 | AugustoMauch | New Issue | |
| 2014-03-26 17:06 | AugustoMauch | Assigned To | => dbaz |
| 2014-03-26 17:06 | AugustoMauch | Modules | => Core |
| 2014-03-26 17:06 | AugustoMauch | Triggers an Emergency Pack | => No |
| 2014-03-26 17:06 | AugustoMauch | File Added: EditingGridBefore.png | |
| 2014-03-26 17:06 | AugustoMauch | File Added: EditingGridAfter.png | |
| 2014-03-26 17:19 | AugustoMauch | Description Updated | View Revisions |
| 2014-03-26 17:19 | AugustoMauch | Steps to Reproduce Updated | View Revisions |
| 2014-03-27 07:53 | alostale | Regression level | => Pre packaging ( pi ) |
| 2014-03-27 07:53 | alostale | Regression date | => 2014-02-26 |
| 2014-03-27 07:53 | alostale | Regression introduced by commit | => https://code.openbravo.com/erp/devel/pi/rev/20eb3426d990 [^] |
| 2014-03-27 07:54 | alostale | Severity | critical => minor |
| 2014-03-27 07:55 | alostale | Relationship added | related to 0025574 |
| 2014-03-27 22:31 | dbaz | Note Added: 0065548 | |
| 2014-03-31 22:34 | hgbot | Checkin | |
| 2014-03-31 22:34 | hgbot | Note Added: 0065637 | |
| 2014-04-01 09:16 | hudsonbot | Checkin | |
| 2014-04-01 09:16 | hudsonbot | Note Added: 0065642 | |
| 2014-04-01 21:13 | hgbot | Checkin | |
| 2014-04-01 21:13 | hgbot | Note Added: 0065684 | |
| 2014-04-01 21:14 | hgbot | Checkin | |
| 2014-04-01 21:14 | hgbot | Note Added: 0065685 | |
| 2014-04-01 21:17 | dbaz | File Added: CheckboxVerticalAlignment.png | |
| 2014-04-01 21:24 | dbaz | Note Added: 0065686 | |
| 2014-04-01 21:25 | dbaz | Review Assigned To | => alostale |
| 2014-04-01 21:25 | dbaz | Status | new => scheduled |
| 2014-04-01 21:25 | dbaz | fix_in_branch | => pi |
| 2014-04-01 21:25 | dbaz | Status | scheduled => resolved |
| 2014-04-01 21:25 | dbaz | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/a0ffafde2f77e0b28e9c3cce9163801954fd4d0b [^] |
| 2014-04-01 21:25 | dbaz | Resolution | open => fixed |
| 2014-04-02 09:04 | plujan | Note Added: 0065999 | |
| 2014-04-02 09:04 | plujan | Status | resolved => closed |
| 2014-04-02 12:19 | plujan | Note Added: 0066064 | |
| 2014-04-02 12:19 | plujan | Status | closed => new |
| 2014-04-02 12:19 | plujan | Resolution | fixed => open |
| 2014-04-02 12:19 | plujan | Status | new => scheduled |
| 2014-04-02 12:19 | plujan | Status | scheduled => resolved |
| 2014-04-02 12:19 | plujan | Resolution | open => fixed |
| 2014-04-02 15:19 | alostale | Note Added: 0066078 | |
| 2014-04-02 15:19 | alostale | Status | resolved => closed |
| 2014-05-07 18:10 | hudsonbot | Checkin | |
| 2014-05-07 18:10 | hudsonbot | Note Added: 0066870 | |
| 2014-05-07 18:10 | hudsonbot | Checkin | |
| 2014-05-07 18:10 | hudsonbot | Note Added: 0066871 | |
| 2014-10-01 16:10 | plujan | Regression introduced in release | => pi |
| 2014-10-01 16:10 | plujan | fix_in_branch | pi => |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |