Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0026092Openbravo ERPB. User interfacepublic2014-03-26 17:062014-10-01 16:10
ReporterAugustoMauch 
Assigned Todbaz 
PriorityimmediateSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR14Q2Fixed in Version 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelPre packaging ( pi )
Regression date2014-02-26
Regression introduced in releasepi
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/20eb3426d990 [^]
Triggers an Emergency PackNo
Summary0026092: Styling issues while editing a row in the grid
DescriptionThe styling of the edited grid has been affected by the smartclient upgrade:
- The fields are missing the left margin
- The right border of the text fields is missing
- The drop icons are shown truncated
- The checkboxes are not aligned vertically

All these problems are solved (except the last problem, that gets worse) if the size of a column is modified while the grid is being edited

Two images have been attached to compare the current style with the previous one.

Also, if a checkbox is checked/unchecked and the focus is moved to another row, the checkboxes are centered, when they should be aligned to the left.
Steps To Reproduce- Open any window
- Click the Edit in Grid button.
- Check that the style is wrong

To reproduce the last problem:
- Open Organization
- Edit in grid view any organization
- Change the state of the summary level checkbox
- While still editing, click on another row
- Check that the checkboxes are now centered.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to feature request 0025574 closed dbaz Upgrade SmartClient 10.0d 
Attached Filespng EditingGridBefore.png (42,292) 2014-03-26 17:06
https://issues.openbravo.com/file_download.php?file_id=6782&type=bug
png

png EditingGridAfter.png (41,879) 2014-03-26 17:06
https://issues.openbravo.com/file_download.php?file_id=6783&type=bug
png

png CheckboxVerticalAlignment.png (14,722) 2014-04-01 21:17
https://issues.openbravo.com/file_download.php?file_id=6797&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2014-03-26 17:06AugustoMauchNew Issue
2014-03-26 17:06AugustoMauchAssigned To => dbaz
2014-03-26 17:06AugustoMauchModules => Core
2014-03-26 17:06AugustoMauchTriggers an Emergency Pack => No
2014-03-26 17:06AugustoMauchFile Added: EditingGridBefore.png
2014-03-26 17:06AugustoMauchFile Added: EditingGridAfter.png
2014-03-26 17:19AugustoMauchDescription Updatedbug_revision_view_page.php?rev_id=5626#r5626
2014-03-26 17:19AugustoMauchSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=5628#r5628
2014-03-27 07:53alostaleRegression level => Pre packaging ( pi )
2014-03-27 07:53alostaleRegression date => 2014-02-26
2014-03-27 07:53alostaleRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/20eb3426d990 [^]
2014-03-27 07:54alostaleSeveritycritical => minor
2014-03-27 07:55alostaleRelationship addedrelated to 0025574
2014-03-27 22:31dbazNote Added: 0065548
2014-03-31 22:34hgbotCheckin
2014-03-31 22:34hgbotNote Added: 0065637
2014-04-01 09:16hudsonbotCheckin
2014-04-01 09:16hudsonbotNote Added: 0065642
2014-04-01 21:13hgbotCheckin
2014-04-01 21:13hgbotNote Added: 0065684
2014-04-01 21:14hgbotCheckin
2014-04-01 21:14hgbotNote Added: 0065685
2014-04-01 21:17dbazFile Added: CheckboxVerticalAlignment.png
2014-04-01 21:24dbazNote Added: 0065686
2014-04-01 21:25dbazReview Assigned To => alostale
2014-04-01 21:25dbazStatusnew => scheduled
2014-04-01 21:25dbazfix_in_branch => pi
2014-04-01 21:25dbazStatusscheduled => resolved
2014-04-01 21:25dbazFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/a0ffafde2f77e0b28e9c3cce9163801954fd4d0b [^]
2014-04-01 21:25dbazResolutionopen => fixed
2014-04-02 09:04plujanNote Added: 0065999
2014-04-02 09:04plujanStatusresolved => closed
2014-04-02 12:19plujanNote Added: 0066064
2014-04-02 12:19plujanStatusclosed => new
2014-04-02 12:19plujanResolutionfixed => open
2014-04-02 12:19plujanStatusnew => scheduled
2014-04-02 12:19plujanStatusscheduled => resolved
2014-04-02 12:19plujanResolutionopen => fixed
2014-04-02 15:19alostaleNote Added: 0066078
2014-04-02 15:19alostaleStatusresolved => closed
2014-05-07 18:10hudsonbotCheckin
2014-05-07 18:10hudsonbotNote Added: 0066870
2014-05-07 18:10hudsonbotCheckin
2014-05-07 18:10hudsonbotNote Added: 0066871
2014-10-01 16:10plujanRegression introduced in release => pi
2014-10-01 16:10plujanfix_in_branchpi =>

Notes
(0065548)
dbaz   
2014-03-27 22:31   
The issue has been reported to Isomorphic:

http://forums.smartclient.com/showthread.php?p=118031 [^]
(0065637)
hgbot   
2014-03-31 22:34   
Repository: erp/devel/pi
Changeset: a0ffafde2f77e0b28e9c3cce9163801954fd4d0b
Author: David Baz Fayos <david.baz <at> openbravo.com>
Date: Mon Mar 31 22:33:47 2014 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/a0ffafde2f77e0b28e9c3cce9163801954fd4d0b [^]

Related to issue 26092: avoid input icons be cropped

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js
---
(0065642)
hudsonbot   
2014-04-01 09:16   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/648c4d0c52f8 [^]
Maturity status: Test
(0065684)
hgbot   
2014-04-01 21:13   
Repository: erp/devel/pi
Changeset: 003cc8c257f78ff5d5f905ff1048e289b45fbd5d
Author: David Baz Fayos <david.baz <at> openbravo.com>
Date: Tue Apr 01 21:11:15 2014 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/003cc8c257f78ff5d5f905ff1048e289b45fbd5d [^]

Related to issue 26092: Checkboxes are now always left-aligned in grid view
even after column resizing

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js
---
(0065685)
hgbot   
2014-04-01 21:14   
Repository: erp/devel/pi
Changeset: c0811054ce65644965eec4eedb478e5da1c75950
Author: David Baz Fayos <david.baz <at> openbravo.com>
Date: Tue Apr 01 21:13:44 2014 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/c0811054ce65644965eec4eedb478e5da1c75950 [^]

Related to issue 26092: inputs are now always centered while editing records in the grid

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js
---
(0065686)
dbaz   
2014-04-01 21:24   
All the issues have been fixed except "The checkboxes are not aligned vertically".
This issue is due to the way Smartclient now manages checkboxes position.

Anyway, as you can see in the attached "CheckboxVerticalAlignment.png" screenshot, inputs are not vertically aligned (due that the input height minus the grid row height has a odd value) and they were like this also in MP31, so now, the checkbox is aligned with the inputs.

A solution for both vertical alignment problems (checkbox + inputs) could be add (or substract) one pixel to the row heights, but this could break other components like query widgets where the grid just fits the container.

Summarizing: the vertical alignment problem is out of the scope.
(0065999)
plujan   
2014-04-02 09:04   
Closed as it was in Resolved for too long
(0066064)
plujan   
2014-04-02 12:19   
Reverted as wrongly closed
(0066078)
alostale   
2014-04-02 15:19   
code reviewed + tested
(0066870)
hudsonbot   
2014-05-07 18:10   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/02ca2648bcdc [^]
Maturity status: Test
(0066871)
hudsonbot   
2014-05-07 18:10   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/02ca2648bcdc [^]
Maturity status: Test