Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0026087
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajorhave not tried2014-03-26 09:492014-04-03 17:17
ReportermarvintmView Statuspublic 
Assigned Tomarvintm 
PrioritynormalResolutionfixedFixed in VersionRR14Q2
StatusclosedFix in branchpiFixed in SCM revision1133f42214ba
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomalsasua
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0026087: Ticket duplication detection is wrong and in some strange cases can lead to data loss

DescriptionCurrently there is a function in the OrderLoader which tries to detect if a ticket is duplicated or not. This function was created when there was still no id defined for the Order.

As this function uses a combination of document number, bpartner, and lines to check if the ticket is duplicated or not, in some weird cases it could happen that the ticket is mistakenly detected as duplicated. In this case, the ticket information would be lost.

Now, as the Order has an id, it is no longer needed to do this to detect if its a duplicated ticket or not. Therefore, it can be removed.
Steps To ReproduceThe problem will only happen if the document number sequence works incorrectly in the Web POS. Right now this should not happen because several issues with this have been fixed. However, in any case it is a good idea to remove this to ensure that it never happens again.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to design defect 0026020RR14Q3 closedmarvintm Failure proof ticket synchronisation with ERP system 

-  Notes
(0065460)
hgbot (developer)
2014-03-26 09:50

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 1133f42214ba10289fd14927c962e0a2a8d1d1e1
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Wed Mar 26 09:50:18 2014 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/1133f42214ba10289fd14927c962e0a2a8d1d1e1 [^]

Fixed issue 26087. Removed ticket duplication logic.

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
---
(0065497)
malsasua (developer)
2014-03-27 10:25

 verified
(0066139)
hgbot (developer)
2014-04-03 16:45

 Repository: erp/pmods/org.openbravo.retail.posterminal.cds
Changeset: 1133f42214ba10289fd14927c962e0a2a8d1d1e1
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Wed Mar 26 09:50:18 2014 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal.cds/rev/1133f42214ba10289fd14927c962e0a2a8d1d1e1 [^]

Fixed issue 26087. Removed ticket duplication logic.

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
---
(0066164)
malsasua (developer)
2014-04-03 17:17

 closed again

- Issue History
Date Modified Username Field Change
2014-03-26 09:49 marvintm New Issue
2014-03-26 09:49 marvintm Assigned To => marvintm
2014-03-26 09:49 marvintm Triggers an Emergency Pack => No
2014-03-26 09:50 hgbot Checkin
2014-03-26 09:50 hgbot Note Added: 0065460
2014-03-26 09:50 hgbot Status new => resolved
2014-03-26 09:50 hgbot Resolution open => fixed
2014-03-26 09:50 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/1133f42214ba10289fd14927c962e0a2a8d1d1e1 [^]
2014-03-26 09:51 marvintm Status resolved => new
2014-03-26 09:51 marvintm Resolution fixed => open
2014-03-26 09:51 marvintm Relationship added related to 0026020
2014-03-26 09:51 marvintm Status new => scheduled
2014-03-26 09:51 marvintm fix_in_branch => pi
2014-03-26 09:51 marvintm Status scheduled => resolved
2014-03-26 09:51 marvintm Resolution open => fixed
2014-03-27 10:25 malsasua Review Assigned To => malsasua
2014-03-27 10:25 malsasua Note Added: 0065497
2014-03-27 10:25 malsasua Status resolved => closed
2014-03-27 10:25 malsasua Fixed in Version => RR14Q2
2014-04-03 16:45 hgbot Checkin
2014-04-03 16:45 hgbot Note Added: 0066139
2014-04-03 16:45 hgbot Status closed => resolved
2014-04-03 16:45 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/1133f42214ba10289fd14927c962e0a2a8d1d1e1 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal.cds/rev/1133f42214ba10289fd14927c962e0a2a8d1d1e1 [^]
2014-04-03 17:17 malsasua Note Added: 0066164
2014-04-03 17:17 malsasua Status resolved => closed

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker