Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0026087Retail ModulesWeb POSpublic2014-03-26 09:492014-04-03 17:17
Reportermarvintm 
Assigned Tomarvintm 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR14Q2 
Merge Request Status
Review Assigned Tomalsasua
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0026087: Ticket duplication detection is wrong and in some strange cases can lead to data loss
DescriptionCurrently there is a function in the OrderLoader which tries to detect if a ticket is duplicated or not. This function was created when there was still no id defined for the Order.

As this function uses a combination of document number, bpartner, and lines to check if the ticket is duplicated or not, in some weird cases it could happen that the ticket is mistakenly detected as duplicated. In this case, the ticket information would be lost.

Now, as the Order has an id, it is no longer needed to do this to detect if its a duplicated ticket or not. Therefore, it can be removed.
Steps To ReproduceThe problem will only happen if the document number sequence works incorrectly in the Web POS. Right now this should not happen because several issues with this have been fixed. However, in any case it is a good idea to remove this to ensure that it never happens again.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0026020RR14Q3 closed marvintm Failure proof ticket synchronisation with ERP system 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2014-03-26 09:49marvintmNew Issue
2014-03-26 09:49marvintmAssigned To => marvintm
2014-03-26 09:49marvintmOBNetwork customer => No
2014-03-26 09:49marvintmTriggers an Emergency Pack => No
2014-03-26 09:50hgbotCheckin
2014-03-26 09:50hgbotNote Added: 0065460
2014-03-26 09:50hgbotStatusnew => resolved
2014-03-26 09:50hgbotResolutionopen => fixed
2014-03-26 09:50hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/1133f42214ba10289fd14927c962e0a2a8d1d1e1 [^]
2014-03-26 09:51marvintmStatusresolved => new
2014-03-26 09:51marvintmResolutionfixed => open
2014-03-26 09:51marvintmRelationship addedrelated to 0026020
2014-03-26 09:51marvintmStatusnew => scheduled
2014-03-26 09:51marvintmfix_in_branch => pi
2014-03-26 09:51marvintmStatusscheduled => resolved
2014-03-26 09:51marvintmResolutionopen => fixed
2014-03-27 10:25malsasuaReview Assigned To => malsasua
2014-03-27 10:25malsasuaNote Added: 0065497
2014-03-27 10:25malsasuaStatusresolved => closed
2014-03-27 10:25malsasuaFixed in Version => RR14Q2
2014-04-03 16:45hgbotCheckin
2014-04-03 16:45hgbotNote Added: 0066139
2014-04-03 16:45hgbotStatusclosed => resolved
2014-04-03 16:45hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/1133f42214ba10289fd14927c962e0a2a8d1d1e1 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal.cds/rev/1133f42214ba10289fd14927c962e0a2a8d1d1e1 [^]
2014-04-03 17:17malsasuaNote Added: 0066164
2014-04-03 17:17malsasuaStatusresolved => closed

Notes
(0065460)
hgbot   
2014-03-26 09:50   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 1133f42214ba10289fd14927c962e0a2a8d1d1e1
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Wed Mar 26 09:50:18 2014 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/1133f42214ba10289fd14927c962e0a2a8d1d1e1 [^]

Fixed issue 26087. Removed ticket duplication logic.

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
---
(0065497)
malsasua   
2014-03-27 10:25   
verified
(0066139)
hgbot   
2014-04-03 16:45   
Repository: erp/pmods/org.openbravo.retail.posterminal.cds
Changeset: 1133f42214ba10289fd14927c962e0a2a8d1d1e1
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Wed Mar 26 09:50:18 2014 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal.cds/rev/1133f42214ba10289fd14927c962e0a2a8d1d1e1 [^]

Fixed issue 26087. Removed ticket duplication logic.

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
---
(0066164)
malsasua   
2014-04-03 17:17   
closed again