0026087: Ticket duplication detection is wrong and in some strange cases can lead to data loss

Openbravo Issue Tracking System - Retail Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0026087

Retail Modules

Web POS

public

2014-03-26 09:49

2014-04-03 17:17

Reporter

marvintm

Assigned To

marvintm

Priority

normal

Severity

major

Reproducibility

have not tried

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

RR14Q2

Merge Request Status

Review Assigned To

malsasua

OBNetwork customer

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0026087: Ticket duplication detection is wrong and in some strange cases can lead to data loss

Description

Currently there is a function in the OrderLoader which tries to detect if a ticket is duplicated or not. This function was created when there was still no id defined for the Order.

As this function uses a combination of document number, bpartner, and lines to check if the ticket is duplicated or not, in some weird cases it could happen that the ticket is mistakenly detected as duplicated. In this case, the ticket information would be lost.

Now, as the Order has an id, it is no longer needed to do this to detect if its a duplicated ticket or not. Therefore, it can be removed.

Steps To Reproduce

The problem will only happen if the document number sequence works incorrectly in the Web POS. Right now this should not happen because several issues with this have been fixed. However, in any case it is a good idea to remove this to ensure that it never happens again.

Proposed Solution

Additional Information