Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0025743 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| feature request | [Openbravo ERP] Z. Others | trivial | N/A | 2014-02-16 14:05 | 2014-03-04 07:51 | |||
| Reporter | shuehner | View Status | public | |||||
| Assigned To | shuehner | |||||||
| Priority | none | Resolution | fixed | Fixed in Version | 3.0PR14Q2 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | c3bb94a4b13f | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Merge Request Status | ||||||||
| Review Assigned To | alostale | |||||||
| OBNetwork customer | No | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Support ticket | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0025743: There are many unused/non-publish xsql files (and methods in xsql files) - part1 | |||||||
| Description | Checking all non-public xsql files in pi shows many which are not used. Two cases: a.) Entire xsql file is not used b.) Some methods of xsql files not used This first issue is related to cleanup where either whole files are removed or SqlMethod inside a file are removed which are not the first method in that xsql file. That means that code-removal only affects java methods. List of fields in the generated java class is not modified meaning there can't be any code in callers which may fail because of missing fields used via getField (and not used directly). Diffstat: 119 files changed, 8382 deletions(-) Size-changes in build/classes 38M ../../branches/pi_unmodified_pg/build/classes/ 37M build/classes/ | |||||||
| Steps To Reproduce | Check generated java class or method and use i.e. eclipse search for references. Alternatively use a tool like UCDetector which can scan for unsued java code | |||||||
| Proposed Solution | Remove the unsused code. | |||||||
| Tags | Performance | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0064283) shuehner (administrator) 2014-02-16 14:17 |
Note: extra compile testing was done to ensure that the org.openbravo.importdata + org.openbravo.deprecated.cleanupv3 modules still compile as those ignore normal api and directly access some non-public methods (by being inside same java package). |
|
(0064316) hgbot (developer) 2014-02-18 10:55 |
Repository: erp/devel/pi Changeset: c3bb94a4b13f6e9ff87090493168f030c6cd0e72 Author: Stefan Hühner <stefan.huehner <at> openbravo.com> Date: Sun Feb 16 14:14:17 2014 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/c3bb94a4b13f6e9ff87090493168f030c6cd0e72 [^] Fixed 25743: Remove many unused,non-public xsql-files & - methods --- M src-wad/src/org/openbravo/wad/TableLink_data.xsql M src-wad/src/org/openbravo/wad/Wad_data.xsql M src/org/openbravo/base/secureApp/OrgTree_data.xsql M src/org/openbravo/erpCommon/ad_actionButton/CopyFromInvoice_data.xsql M src/org/openbravo/erpCommon/ad_actionButton/CopyFromOrder_data.xsql M src/org/openbravo/erpCommon/ad_actionButton/CopyFromPOOrder_data.xsql M src/org/openbravo/erpCommon/ad_actionButton/CreateFile34_data.xsql M src/org/openbravo/erpCommon/ad_actionButton/CreateFromMultiple_Receipt_data.xsql M src/org/openbravo/erpCommon/ad_actionButton/CreateFrom_CRemittance_data.xsql M src/org/openbravo/erpCommon/ad_actionButton/CreateRegFactAcct_data.xsql M src/org/openbravo/erpCommon/ad_actionButton/CreateVatRegisters_data.xsql M src/org/openbravo/erpCommon/ad_actionButton/EditCCPMeasureValues_Hours_data.xsql M src/org/openbravo/erpCommon/ad_actionButton/EditCCPMeasureValues_Values_data.xsql M src/org/openbravo/erpCommon/ad_actionButton/ExpenseSOrder_data.xsql M src/org/openbravo/erpCommon/ad_actionButton/Posted_data.xsql M src/org/openbravo/erpCommon/ad_actionButton/TaxPayment.xsql M src/org/openbravo/erpCommon/ad_callouts/SE_ProjectLine_Value_data.xsql M src/org/openbravo/erpCommon/ad_callouts/SL_GlobalUse_Product_data.xsql M src/org/openbravo/erpCommon/ad_callouts/SL_Invoice_Amt_data.xsql M src/org/openbravo/erpCommon/ad_callouts/SL_JournalLineAmt_data.xsql M src/org/openbravo/erpCommon/ad_callouts/SL_Order_Amt_data.xsql M src/org/openbravo/erpCommon/ad_callouts/SL_Payment_Amounts_data.xsql M src/org/openbravo/erpCommon/ad_callouts/SL_ProjectPlanned_Amt_data.xsql M src/org/openbravo/erpCommon/ad_callouts/SL_WorkRequirement_Sequence.xsql M src/org/openbravo/erpCommon/ad_forms/Account_data.xsql M src/org/openbravo/erpCommon/ad_forms/AcctSchema_data.xsql M src/org/openbravo/erpCommon/ad_forms/AcctServer_data.xsql M src/org/openbravo/erpCommon/ad_forms/DocCash_data.xsql M src/org/openbravo/erpCommon/ad_forms/DocInOut_data.xsql M src/org/openbravo/erpCommon/ad_forms/DocLineCash_data.xsql M src/org/openbravo/erpCommon/ad_forms/DocLinePayment_data.xsql M src/org/openbravo/erpCommon/ad_forms/DocMatchInv_data.xsql M src/org/openbravo/erpCommon/ad_forms/DocPayment_data.xsql M src/org/openbravo/erpCommon/ad_forms/FactLine_data.xsql M src/org/openbravo/erpCommon/ad_forms/GenerateInvoicesmanual_data.xsql M src/org/openbravo/erpCommon/ad_forms/GenerateShipmentsmanual_data.xsql M src/org/openbravo/erpCommon/ad_forms/Heartbeat_data.xsql M src/org/openbravo/erpCommon/ad_forms/LanguageCombo_data.xsql M src/org/openbravo/erpCommon/ad_forms/MaterialReceiptPendingLines_data.xsql M src/org/openbravo/erpCommon/ad_forms/MonedaCombo_data.xsql M src/org/openbravo/erpCommon/ad_forms/Organization_data.xsql M src/org/openbravo/erpCommon/ad_forms/SQLExecutor_data.xsql M src/org/openbravo/erpCommon/ad_forms/ShowSessionVariables_data.xsql M src/org/openbravo/erpCommon/ad_forms/UpdateReferenceData_data.xsql M src/org/openbravo/erpCommon/ad_forms/Warehouse_data.xsql M src/org/openbravo/erpCommon/ad_process/AlertProcess_data.xsql M src/org/openbravo/erpCommon/ad_process/CreateAccountingReport_data.xsql M src/org/openbravo/erpCommon/ad_process/CreateCashFlowStatement_data.xsql M src/org/openbravo/erpCommon/ad_process/CreateTaxReport_data.xsql M src/org/openbravo/erpCommon/ad_process/ExpenseAPInvoice_data.xsql M src/org/openbravo/erpCommon/ad_reports/GeneralAccountingReports_data.xsql M src/org/openbravo/erpCommon/ad_reports/InoutEdition_data.xsql M src/org/openbravo/erpCommon/ad_reports/InvoiceCustomerEdition_data.xsql M src/org/openbravo/erpCommon/ad_reports/InvoiceEdition_data.xsql M src/org/openbravo/erpCommon/ad_reports/MInOutTraceReports_data.xsql M src/org/openbravo/erpCommon/ad_reports/Organization_data.xsql M src/org/openbravo/erpCommon/ad_reports/ReportCashFlow_data.xsql M src/org/openbravo/erpCommon/ad_reports/ReportCashJR_data.xsql M src/org/openbravo/erpCommon/ad_reports/ReportGeneralLedgerJournalDetail_data.xsql M src/org/openbravo/erpCommon/ad_reports/ReportInvoiceCustomerDimensionalAnalysesJR_data.xsql M src/org/openbravo/erpCommon/ad_reports/ReportInvoiceCustomerDimensionalAnalysesJR_legacy_data.xsql M src/org/openbravo/erpCommon/ad_reports/ReportInvoiceDiscount_data.xsql M src/org/openbravo/erpCommon/ad_reports/ReportInvoiceVendorDimensionalAnalysesJR_data.xsql M src/org/openbravo/erpCommon/ad_reports/ReportMaterialDimensionalAnalysesJR_data.xsql M src/org/openbravo/erpCommon/ad_reports/ReportNotPosted_data.xsql M src/org/openbravo/erpCommon/ad_reports/ReportOffer_data.xsql M src/org/openbravo/erpCommon/ad_reports/ReportOrderNotInvoice_data.xsql M src/org/openbravo/erpCommon/ad_reports/ReportPendingProductionJr_data.xsql M src/org/openbravo/erpCommon/ad_reports/ReportPricelist_data.xsql M src/org/openbravo/erpCommon/ad_reports/ReportProductionRun_data.xsql M src/org/openbravo/erpCommon/ad_reports/ReportProjectProfitability_data.xsql M src/org/openbravo/erpCommon/ad_reports/ReportPurchaseDimensionalAnalysesJR_data.xsql M src/org/openbravo/erpCommon/ad_reports/ReportSalesDimensionalAnalyzeJR_data.xsql M src/org/openbravo/erpCommon/ad_reports/ReportShipmentDimensionalAnalyzeJR_data.xsql M src/org/openbravo/erpCommon/ad_reports/ReportShipper_data.xsql M src/org/openbravo/erpCommon/ad_reports/ReportTotalProductTemplate_data.xsql M src/org/openbravo/erpCommon/ad_reports/ReportTrialBalanceDetail_data.xsql M src/org/openbravo/erpCommon/ad_reports/ReportWarehousePartner_data.xsql M src/org/openbravo/erpCommon/ad_reports/ReportWorkRequirementDailyEnv_data.xsql M src/org/openbravo/erpCommon/ad_reports/ReportWorkRequirementDaily_data.xsql M src/org/openbravo/erpCommon/ad_reports/ReportWorkRequirementJR_data.xsql M src/org/openbravo/erpCommon/businessUtility/EndYearCloseUtility_data.xsql M src/org/openbravo/erpCommon/businessUtility/TabFilter_data.xsql M src/org/openbravo/erpCommon/businessUtility/Tax_data.xsql M src/org/openbravo/erpCommon/info/AccountElementValue_data.xsql M src/org/openbravo/erpCommon/info/AttributeSetInstance_data.xsql M src/org/openbravo/erpCommon/info/BusinessPartnerMultiple_data.xsql M src/org/openbravo/erpCommon/info/BusinessPartner_data.xsql M src/org/openbravo/erpCommon/info/DebtPayment_data.xsql M src/org/openbravo/erpCommon/info/InvoiceLine_data.xsql M src/org/openbravo/erpCommon/info/Invoice_data.xsql M src/org/openbravo/erpCommon/info/Locator_data.xsql M src/org/openbravo/erpCommon/info/ProductComplete_data.xsql M src/org/openbravo/erpCommon/info/ProductMultiple_data.xsql M src/org/openbravo/erpCommon/info/Product_data.xsql M src/org/openbravo/erpCommon/info/ProjectMultiple_data.xsql M src/org/openbravo/erpCommon/info/Project_data.xsql M src/org/openbravo/erpCommon/info/SalesOrderLine_data.xsql M src/org/openbravo/erpCommon/info/SalesOrder_data.xsql M src/org/openbravo/erpCommon/info/ShipmentReceiptLine_data.xsql M src/org/openbravo/erpCommon/info/ShipmentReceipt_data.xsql M src/org/openbravo/erpCommon/utility/SystemInfo_data.xsql M src/org/openbravo/erpCommon/utility/reporting/printing/Email_data.xsql M src/org/openbravo/erpReports/ReportRegisterLineJR_data.xsql M src/org/openbravo/erpReports/RptC_ProposalJr_data.xsql M src/org/openbravo/erpReports/RptC_Remittance_data.xsql M src/org/openbravo/erpReports/RptMA_CCP_Measures_Hours_data.xsql M src/org/openbravo/erpReports/RptMA_CCP_Measures_Values_data.xsql M src/org/openbravo/erpReports/RptM_Inout_Header_data.xsql M src/org/openbravo/erpReports/RptM_Inout_Lines_data.xsql M src/org/openbravo/erpReports/RptM_Inout_data.xsql R src-wad/src/org/openbravo/wad/CallOutsStructure.java R src-wad/src/org/openbravo/wad/KeyStructure.java R src-wad/src/org/openbravo/wad/TableDirRelation_data.xsql R src-wad/src/org/openbravo/wad/controls/WADControl_data.xsql R src/org/openbravo/costing/Costing_data.xsql R src/org/openbravo/erpCommon/ad_callouts/SE_Supplier_BPartner_data.xsql R src/org/openbravo/erpCommon/ad_callouts/SL_Inventory_Product_data.xsql R src/org/openbravo/erpCommon/ad_help/DisplayHelp_Edit_Element_data.xsql R src/org/openbravo/erpCommon/ad_help/DisplayHelp_Edit_Field_data.xsql R src/org/openbravo/erpCommon/ad_process/ApplyModules_data.xsql R src/org/openbravo/erpCommon/ad_process/PrintInvoices_data.xsql R src/org/openbravo/erpCommon/ad_process/ProcedureProcess_data.xsql R src/org/openbravo/erpCommon/utility/reporting/Order_data.xsql R src/org/openbravo/erpCommon/utility/reporting/printing/Document_data.xsql --- |
|
(0064776) alostale (viewer) 2014-03-04 07:51 |
code reviewed |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2014-02-16 14:05 | shuehner | New Issue | |
| 2014-02-16 14:05 | shuehner | Assigned To | => dmiguelez |
| 2014-02-16 14:05 | shuehner | Modules | => Core |
| 2014-02-16 14:05 | shuehner | OBNetwork customer | => No |
| 2014-02-16 14:05 | shuehner | Triggers an Emergency Pack | => No |
| 2014-02-16 14:05 | shuehner | Assigned To | dmiguelez => shuehner |
| 2014-02-16 14:17 | shuehner | Note Added: 0064283 | |
| 2014-02-18 10:55 | hgbot | Checkin | |
| 2014-02-18 10:55 | hgbot | Note Added: 0064316 | |
| 2014-02-18 10:55 | hgbot | Status | new => resolved |
| 2014-02-18 10:55 | hgbot | Resolution | open => fixed |
| 2014-02-18 10:55 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/c3bb94a4b13f6e9ff87090493168f030c6cd0e72 [^] |
| 2014-02-18 10:56 | alostale | Tag Attached: Performance | |
| 2014-02-18 10:57 | shuehner | Review Assigned To | => alostale |
| 2014-03-04 07:51 | alostale | Note Added: 0064776 | |
| 2014-03-04 07:51 | alostale | Status | resolved => closed |
| 2014-03-04 07:51 | alostale | Fixed in Version | => 3.0MP32 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |