Openbravo Issue Tracking System - Openbravo ERP | |||||
| View Issue Details | |||||
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0025743 | Openbravo ERP | Z. Others | public | 2014-02-16 14:05 | 2014-03-04 07:51 |
| Reporter | shuehner | ||||
| Assigned To | shuehner | ||||
| Priority | none | Severity | trivial | Reproducibility | N/A |
| Status | closed | Resolution | fixed | ||
| Platform | OS | 5 | OS Version | ||
| Product Version | |||||
| Target Version | Fixed in Version | 3.0PR14Q2 | |||
| Merge Request Status | |||||
| Review Assigned To | alostale | ||||
| OBNetwork customer | |||||
| Web browser | |||||
| Modules | Core | ||||
| Support ticket | |||||
| Regression level | |||||
| Regression date | |||||
| Regression introduced in release | |||||
| Regression introduced by commit | |||||
| Triggers an Emergency Pack | No | ||||
| Summary | 0025743: There are many unused/non-publish xsql files (and methods in xsql files) - part1 | ||||
| Description | Checking all non-public xsql files in pi shows many which are not used. Two cases: a.) Entire xsql file is not used b.) Some methods of xsql files not used This first issue is related to cleanup where either whole files are removed or SqlMethod inside a file are removed which are not the first method in that xsql file. That means that code-removal only affects java methods. List of fields in the generated java class is not modified meaning there can't be any code in callers which may fail because of missing fields used via getField (and not used directly). Diffstat: 119 files changed, 8382 deletions(-) Size-changes in build/classes 38M ../../branches/pi_unmodified_pg/build/classes/ 37M build/classes/ | ||||
| Steps To Reproduce | Check generated java class or method and use i.e. eclipse search for references. Alternatively use a tool like UCDetector which can scan for unsued java code | ||||
| Proposed Solution | Remove the unsused code. | ||||
| Additional Information | |||||
| Tags | Performance | ||||
| Relationships | |||||
| Attached Files | |||||
| Issue History | |||||
| Date Modified | Username | Field | Change | ||
| 2014-02-16 14:05 | shuehner | New Issue | |||
| 2014-02-16 14:05 | shuehner | Assigned To | => dmiguelez | ||
| 2014-02-16 14:05 | shuehner | Modules | => Core | ||
| 2014-02-16 14:05 | shuehner | Triggers an Emergency Pack | => No | ||
| 2014-02-16 14:05 | shuehner | Assigned To | dmiguelez => shuehner | ||
| 2014-02-16 14:17 | shuehner | Note Added: 0064283 | |||
| 2014-02-18 10:55 | hgbot | Checkin | |||
| 2014-02-18 10:55 | hgbot | Note Added: 0064316 | |||
| 2014-02-18 10:55 | hgbot | Status | new => resolved | ||
| 2014-02-18 10:55 | hgbot | Resolution | open => fixed | ||
| 2014-02-18 10:55 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/c3bb94a4b13f6e9ff87090493168f030c6cd0e72 [^] | ||
| 2014-02-18 10:56 | alostale | Tag Attached: Performance | |||
| 2014-02-18 10:57 | shuehner | Review Assigned To | => alostale | ||
| 2014-03-04 07:51 | alostale | Note Added: 0064776 | |||
| 2014-03-04 07:51 | alostale | Status | resolved => closed | ||
| 2014-03-04 07:51 | alostale | Fixed in Version | => 3.0MP32 | ||
| Notes | |||||
|
|
|||||
|
|
||||
|
|
|||||
|
|
||||
|
|
|||||
|
|
||||