Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0024914
TypeCategorySeverityReproducibilityDate SubmittedLast Update
feature request[Openbravo ERP] A. Platformminoralways2013-10-08 23:422013-10-17 18:36
ReporterdbazView Statuspublic 
Assigned Todbaz 
PrioritynormalResolutionfixedFixed in Version3.0MP29
StatusclosedFix in branchFixed in SCM revision08694941dab4
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned ToAugustoMauch
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0024914: Way needed to determine if an issue is caused by OBGrid or OBViewGrid

DescriptionThere are some situations where a fast way (for a developer) to determine if an issue is caused by OBGrid or OBViewGrid is needed.

The easiest and fastest operation could be just replace

isc.ClassFactory.defineClass('OBViewGrid', isc.OBGrid);

by

isc.ClassFactory.defineClass('OBViewGrid', isc.ListGrid);

in ob-view-grid.js

But this causes several JS errors. This is what should be avoided
Steps To ReproduceReplace

isc.ClassFactory.defineClass('OBViewGrid', isc.OBGrid);

by

isc.ClassFactory.defineClass('OBViewGrid', isc.ListGrid);

in ob-view-grid.js

and ensure that any window in grid mode still loads (although with bad style and without sheet/pencil icons)
TagsNo tags attached.
Attached Files? file icon advTest.js [^] (30,266 bytes) 2013-10-08 23:42

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0061621)
dbaz (developer)
2013-10-08 23:44

Another interesting test case to just load a view but outside the tab structure, could be just copy the "advTest.js" code and paste inside the console of a web developer tool.

This should display the grid (altough some JS could also happen), but it should be shown.
(0061622)
hgbot (developer)
2013-10-08 23:47

Repository: erp/devel/pi
Changeset: 08694941dab44b4dff3b8be31e09edef29e838d7
Author: David Baz Fayos <david.baz <at> openbravo.com>
Date: Tue Oct 08 23:47:04 2013 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/08694941dab44b4dff3b8be31e09edef29e838d7 [^]

Fixed issue 24914: Added statements to avoid JS errors
while trying to prepare a simplification of OBViewGrid (based in ListGrid) to debug

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view-datasource.js
---
(0061733)
hudsonbot (developer)
2013-10-16 19:46

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/51315988909a [^]

Maturity status: Test
(0061793)
AugustoMauch (manager)
2013-10-17 18:36

Code reviewed and verified in pi@eb0f3ecbdae4

- Issue History
Date Modified Username Field Change
2013-10-08 23:42 dbaz New Issue
2013-10-08 23:42 dbaz Assigned To => dbaz
2013-10-08 23:42 dbaz Modules => Core
2013-10-08 23:42 dbaz Triggers an Emergency Pack => No
2013-10-08 23:42 dbaz File Added: advTest.js
2013-10-08 23:44 dbaz Note Added: 0061621
2013-10-08 23:45 dbaz Review Assigned To => AugustoMauch
2013-10-08 23:45 dbaz Issue Monitored: AugustoMauch
2013-10-08 23:47 hgbot Checkin
2013-10-08 23:47 hgbot Note Added: 0061622
2013-10-08 23:47 hgbot Status new => resolved
2013-10-08 23:47 hgbot Resolution open => fixed
2013-10-08 23:47 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/08694941dab44b4dff3b8be31e09edef29e838d7 [^]
2013-10-16 19:46 hudsonbot Checkin
2013-10-16 19:46 hudsonbot Note Added: 0061733
2013-10-17 18:36 AugustoMauch Note Added: 0061793
2013-10-17 18:36 AugustoMauch Status resolved => closed
2013-10-17 18:36 AugustoMauch Fixed in Version => 3.0MP29


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker