Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0024914Openbravo ERPA. Platformpublic2013-10-08 23:422013-10-17 18:36
Reporterdbaz 
Assigned Todbaz 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0MP29 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0024914: Way needed to determine if an issue is caused by OBGrid or OBViewGrid
DescriptionThere are some situations where a fast way (for a developer) to determine if an issue is caused by OBGrid or OBViewGrid is needed.

The easiest and fastest operation could be just replace

isc.ClassFactory.defineClass('OBViewGrid', isc.OBGrid);

by

isc.ClassFactory.defineClass('OBViewGrid', isc.ListGrid);

in ob-view-grid.js

But this causes several JS errors. This is what should be avoided
Steps To ReproduceReplace

isc.ClassFactory.defineClass('OBViewGrid', isc.OBGrid);

by

isc.ClassFactory.defineClass('OBViewGrid', isc.ListGrid);

in ob-view-grid.js

and ensure that any window in grid mode still loads (although with bad style and without sheet/pencil icons)
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files? advTest.js (30,266) 2013-10-08 23:42
https://issues.openbravo.com/file_download.php?file_id=6443&type=bug
Issue History
Date ModifiedUsernameFieldChange
2013-10-08 23:42dbazNew Issue
2013-10-08 23:42dbazAssigned To => dbaz
2013-10-08 23:42dbazModules => Core
2013-10-08 23:42dbazOBNetwork customer => No
2013-10-08 23:42dbazTriggers an Emergency Pack => No
2013-10-08 23:42dbazFile Added: advTest.js
2013-10-08 23:44dbazNote Added: 0061621
2013-10-08 23:45dbazReview Assigned To => AugustoMauch
2013-10-08 23:45dbazIssue Monitored: AugustoMauch
2013-10-08 23:47hgbotCheckin
2013-10-08 23:47hgbotNote Added: 0061622
2013-10-08 23:47hgbotStatusnew => resolved
2013-10-08 23:47hgbotResolutionopen => fixed
2013-10-08 23:47hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/08694941dab44b4dff3b8be31e09edef29e838d7 [^]
2013-10-16 19:46hudsonbotCheckin
2013-10-16 19:46hudsonbotNote Added: 0061733
2013-10-17 18:36AugustoMauchNote Added: 0061793
2013-10-17 18:36AugustoMauchStatusresolved => closed
2013-10-17 18:36AugustoMauchFixed in Version => 3.0MP29

Notes
(0061621)
dbaz   
2013-10-08 23:44   
Another interesting test case to just load a view but outside the tab structure, could be just copy the "advTest.js" code and paste inside the console of a web developer tool.

This should display the grid (altough some JS could also happen), but it should be shown.
(0061622)
hgbot   
2013-10-08 23:47   
Repository: erp/devel/pi
Changeset: 08694941dab44b4dff3b8be31e09edef29e838d7
Author: David Baz Fayos <david.baz <at> openbravo.com>
Date: Tue Oct 08 23:47:04 2013 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/08694941dab44b4dff3b8be31e09edef29e838d7 [^]

Fixed issue 24914: Added statements to avoid JS errors
while trying to prepare a simplification of OBViewGrid (based in ListGrid) to debug

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view-datasource.js
---
(0061733)
hudsonbot   
2013-10-16 19:46   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/51315988909a [^]

Maturity status: Test
(0061793)
AugustoMauch   
2013-10-17 18:36   
Code reviewed and verified in pi@eb0f3ecbdae4