Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0024834
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformcriticalhave not tried2013-09-26 10:252013-09-30 21:40
ReporteralostaleView Statuspublic 
Assigned Toalostale 
PriorityimmediateResolutionfixedFixed in Version3.0MP28
StatusclosedFix in branchFixed in SCM revision127f9823d66b
ProjectionnoneETAnoneTarget Version3.0MP28
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression levelPre packaging ( pi )
Regression date2013-09-11
Regression introduced in release
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/290c9b12a211 [^]
Triggers an Emergency PackNo
Summary

0024834: Return from Customer P&E is not working

DescriptionWhen a line is selected in P&E and Returned quantity is entered, a javascript error occurs. At this point the popup gets frozen and it is not possible to continue.
Steps To Reproduce-Go to Return from Customer window
-Create a new Record
-Click on Pick/Edit lines
-Select one line in the popup
-Enter any number in returned field
-Move cursor away from the field
  Check in js console, this error appears: "BigDecimal(): Not a number: u,n,d,e,f,i,n,e,d"
-It is not possible to continue working with that P&E
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0061408)
alostale (viewer)
2013-09-26 10:28

 Regression affecting PI, not reproducible in MP27
(0061409)
alostale (viewer)
2013-09-26 10:32
edited on: 2013-09-26 10:44

 The error is thrown in OB.RM.RMOrderQtyValidate function in

returnedQty = record.returnQtyOtherRM !== null ? new BigDecimal(String(record.returnQtyOtherRM)) : BigDecimal.prototype.ZERO


The problem is value for record.returnQtyOtherRM is undefined; checking it in MP27 it was null.

In both cases, pi and MP27, response from DataSource looks the same, having returnQtyOtherRM null value.
(0061415)
alostale (viewer)
2013-09-26 14:59
edited on: 2013-09-26 15:00

 The regression was introduced by adaptive filtering project. Prior to this the fields in datasource definition were just the one suffering transformation from retrieved response (date and enum references), for adaptive filtering to work all fields needs to be present in the definition.

SmartClient, when handling DataSource JSON response, changes null values to undefined, making this issue to appear.

This has been reported to SmartClient expecting to be solved there, in the meanwhile current patch workarounds the issue.

http://forums.smartclient.com/showthread.php?p=110346#post110346 [^]
(0061416)
hgbot (developer)
2013-09-26 15:09

 Repository: erp/devel/pi
Changeset: 127f9823d66bb35666bf7d159509a35ef13d800c
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu Sep 26 15:03:56 2013 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/127f9823d66bb35666bf7d159509a35ef13d800c [^]

fixed bug 24834: Return from Customer P&E is not working

 This patch workaround a SC issue, it should be reverted once SC solves it

---
M modules/org.openbravo.service.datasource/web/org.openbravo.service.datasource/js/ob-datasource-utilities.js
---
(0061417)
AugustoMauch (administrator)
2013-09-26 15:45

 Code reviewed and verified in pi@127f9823d66b
(0061434)
hudsonbot (viewer)
2013-09-27 03:11

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/71a3ba7a4af8 [^]

Maturity status: Test
(0061476)
hgbot (developer)
2013-09-30 12:08

 Repository: erp/mods/org.openbravo.userinterface.smartclient.dev
Changeset: 1e2623738c466b72080f5bfaa68f0bfe3ebce6a5
Author: David Baz Fayos <david.baz <at> openbravo.com>
Date: Mon Sep 30 12:07:55 2013 +0200
URL: http://code.openbravo.com/erp/mods/org.openbravo.userinterface.smartclient.dev/rev/1e2623738c466b72080f5bfaa68f0bfe3ebce6a5 [^]

Modified Smartclient 8.3d 2012-05-26 SNAPSHOT to fix issue 24834

---
M web/org.openbravo.userinterface.smartclient/isomorphic/client/application/DataSource.js
M web/org.openbravo.userinterface.smartclient/isomorphic/system/development/ISC_DataBinding.js
M web/org.openbravo.userinterface.smartclient/isomorphic/system/modules/ISC_DataBinding.js
---
(0061477)
hgbot (developer)
2013-09-30 12:10

 Repository: erp/devel/pi
Changeset: 50c111e5cff83d180c9bec28602cd607c41c6b91
Author: David Baz Fayos <david.baz <at> openbravo.com>
Date: Mon Sep 30 12:09:46 2013 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/50c111e5cff83d180c9bec28602cd607c41c6b91 [^]

Related to issue 24834: Transplant to Smartclient to fix the issue
instead of fixing the issue in our sources

---
M modules/org.openbravo.service.datasource/web/org.openbravo.service.datasource/js/ob-datasource-utilities.js
M modules/org.openbravo.userinterface.smartclient/web/org.openbravo.userinterface.smartclient/isomorphic/ISC_Combined.js
---
(0061501)
hudsonbot (viewer)
2013-09-30 21:40

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/efb12cdf8699 [^]

Maturity status: Test

- Issue History
Date Modified Username Field Change
2013-09-26 10:25 alostale New Issue
2013-09-26 10:25 alostale Assigned To => alostale
2013-09-26 10:25 alostale Modules => Core
2013-09-26 10:25 alostale OBNetwork customer => No
2013-09-26 10:25 alostale Triggers an Emergency Pack => No
2013-09-26 10:28 alostale Regression level => Pre packaging ( pi )
2013-09-26 10:28 alostale Note Added: 0061408
2013-09-26 10:32 alostale Note Added: 0061409
2013-09-26 10:44 alostale Note Edited: 0061409 View Revisions
2013-09-26 14:55 alostale Review Assigned To => AugustoMauch
2013-09-26 14:55 alostale Regression date => 2013-09-11
2013-09-26 14:55 alostale Regression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/290c9b12a211 [^]
2013-09-26 14:59 alostale Note Added: 0061415
2013-09-26 14:59 alostale Note Edited: 0061415 View Revisions
2013-09-26 15:00 alostale Note Edited: 0061415 View Revisions
2013-09-26 15:09 hgbot Checkin
2013-09-26 15:09 hgbot Note Added: 0061416
2013-09-26 15:09 hgbot Status new => resolved
2013-09-26 15:09 hgbot Resolution open => fixed
2013-09-26 15:09 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/127f9823d66bb35666bf7d159509a35ef13d800c [^]
2013-09-26 15:45 AugustoMauch Note Added: 0061417
2013-09-26 15:45 AugustoMauch Status resolved => closed
2013-09-26 15:45 AugustoMauch Fixed in Version => 3.0MP28
2013-09-27 03:11 hudsonbot Checkin
2013-09-27 03:11 hudsonbot Note Added: 0061434
2013-09-30 12:08 hgbot Checkin
2013-09-30 12:08 hgbot Note Added: 0061476
2013-09-30 12:10 hgbot Checkin
2013-09-30 12:10 hgbot Note Added: 0061477
2013-09-30 21:40 hudsonbot Checkin
2013-09-30 21:40 hudsonbot Note Added: 0061501

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker