Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0024834Openbravo ERPA. Platformpublic2013-09-26 10:252013-09-30 21:40
Reporteralostale 
Assigned Toalostale 
PriorityimmediateSeveritycriticalReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0MP28Fixed in Version3.0MP28 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelPre packaging ( pi )
Regression date2013-09-11
Regression introduced in release
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/290c9b12a211 [^]
Triggers an Emergency PackNo
Summary0024834: Return from Customer P&E is not working
DescriptionWhen a line is selected in P&E and Returned quantity is entered, a javascript error occurs. At this point the popup gets frozen and it is not possible to continue.
Steps To Reproduce-Go to Return from Customer window
-Create a new Record
-Click on Pick/Edit lines
-Select one line in the popup
-Enter any number in returned field
-Move cursor away from the field
  Check in js console, this error appears: "BigDecimal(): Not a number: u,n,d,e,f,i,n,e,d"
-It is not possible to continue working with that P&E
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2013-09-26 10:25alostaleNew Issue
2013-09-26 10:25alostaleAssigned To => alostale
2013-09-26 10:25alostaleModules => Core
2013-09-26 10:25alostaleTriggers an Emergency Pack => No
2013-09-26 10:28alostaleRegression level => Pre packaging ( pi )
2013-09-26 10:28alostaleNote Added: 0061408
2013-09-26 10:32alostaleNote Added: 0061409
2013-09-26 10:44alostaleNote Edited: 0061409bug_revision_view_page.php?bugnote_id=0061409#r5059
2013-09-26 14:55alostaleReview Assigned To => AugustoMauch
2013-09-26 14:55alostaleRegression date => 2013-09-11
2013-09-26 14:55alostaleRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/290c9b12a211 [^]
2013-09-26 14:59alostaleNote Added: 0061415
2013-09-26 14:59alostaleNote Edited: 0061415bug_revision_view_page.php?bugnote_id=0061415#r5061
2013-09-26 15:00alostaleNote Edited: 0061415bug_revision_view_page.php?bugnote_id=0061415#r5062
2013-09-26 15:09hgbotCheckin
2013-09-26 15:09hgbotNote Added: 0061416
2013-09-26 15:09hgbotStatusnew => resolved
2013-09-26 15:09hgbotResolutionopen => fixed
2013-09-26 15:09hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/127f9823d66bb35666bf7d159509a35ef13d800c [^]
2013-09-26 15:45AugustoMauchNote Added: 0061417
2013-09-26 15:45AugustoMauchStatusresolved => closed
2013-09-26 15:45AugustoMauchFixed in Version => 3.0MP28
2013-09-27 03:11hudsonbotCheckin
2013-09-27 03:11hudsonbotNote Added: 0061434
2013-09-30 12:08hgbotCheckin
2013-09-30 12:08hgbotNote Added: 0061476
2013-09-30 12:10hgbotCheckin
2013-09-30 12:10hgbotNote Added: 0061477
2013-09-30 21:40hudsonbotCheckin
2013-09-30 21:40hudsonbotNote Added: 0061501

Notes
(0061408)
alostale   
2013-09-26 10:28   
Regression affecting PI, not reproducible in MP27
(0061409)
alostale   
2013-09-26 10:32   
(edited on: 2013-09-26 10:44)
The error is thrown in OB.RM.RMOrderQtyValidate function in

returnedQty = record.returnQtyOtherRM !== null ? new BigDecimal(String(record.returnQtyOtherRM)) : BigDecimal.prototype.ZERO


The problem is value for record.returnQtyOtherRM is undefined; checking it in MP27 it was null.

In both cases, pi and MP27, response from DataSource looks the same, having returnQtyOtherRM null value.
(0061415)
alostale   
2013-09-26 14:59   
(edited on: 2013-09-26 15:00)
The regression was introduced by adaptive filtering project. Prior to this the fields in datasource definition were just the one suffering transformation from retrieved response (date and enum references), for adaptive filtering to work all fields needs to be present in the definition.

SmartClient, when handling DataSource JSON response, changes null values to undefined, making this issue to appear.

This has been reported to SmartClient expecting to be solved there, in the meanwhile current patch workarounds the issue.

http://forums.smartclient.com/showthread.php?p=110346#post110346 [^]
(0061416)
hgbot   
2013-09-26 15:09   
Repository: erp/devel/pi
Changeset: 127f9823d66bb35666bf7d159509a35ef13d800c
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu Sep 26 15:03:56 2013 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/127f9823d66bb35666bf7d159509a35ef13d800c [^]

fixed bug 24834: Return from Customer P&E is not working

 This patch workaround a SC issue, it should be reverted once SC solves it

---
M modules/org.openbravo.service.datasource/web/org.openbravo.service.datasource/js/ob-datasource-utilities.js
---
(0061417)
AugustoMauch   
2013-09-26 15:45   
Code reviewed and verified in pi@127f9823d66b
(0061434)
hudsonbot   
2013-09-27 03:11   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/71a3ba7a4af8 [^]

Maturity status: Test
(0061476)
hgbot   
2013-09-30 12:08   
Repository: erp/mods/org.openbravo.userinterface.smartclient.dev
Changeset: 1e2623738c466b72080f5bfaa68f0bfe3ebce6a5
Author: David Baz Fayos <david.baz <at> openbravo.com>
Date: Mon Sep 30 12:07:55 2013 +0200
URL: http://code.openbravo.com/erp/mods/org.openbravo.userinterface.smartclient.dev/rev/1e2623738c466b72080f5bfaa68f0bfe3ebce6a5 [^]

Modified Smartclient 8.3d 2012-05-26 SNAPSHOT to fix issue 24834

---
M web/org.openbravo.userinterface.smartclient/isomorphic/client/application/DataSource.js
M web/org.openbravo.userinterface.smartclient/isomorphic/system/development/ISC_DataBinding.js
M web/org.openbravo.userinterface.smartclient/isomorphic/system/modules/ISC_DataBinding.js
---
(0061477)
hgbot   
2013-09-30 12:10   
Repository: erp/devel/pi
Changeset: 50c111e5cff83d180c9bec28602cd607c41c6b91
Author: David Baz Fayos <david.baz <at> openbravo.com>
Date: Mon Sep 30 12:09:46 2013 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/50c111e5cff83d180c9bec28602cd607c41c6b91 [^]

Related to issue 24834: Transplant to Smartclient to fix the issue
instead of fixing the issue in our sources

---
M modules/org.openbravo.service.datasource/web/org.openbravo.service.datasource/js/ob-datasource-utilities.js
M modules/org.openbravo.userinterface.smartclient/web/org.openbravo.userinterface.smartclient/isomorphic/ISC_Combined.js
---
(0061501)
hudsonbot   
2013-09-30 21:40   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/efb12cdf8699 [^]

Maturity status: Test